[GitHub] mistercrunch commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression

2018-05-22 Thread GitBox
mistercrunch commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-391161200 Valid SQL was always the assumption, for simplicity and clarity. `MetricsControl` kind of changes the

[GitHub] mistercrunch commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression

2018-05-22 Thread GitBox
mistercrunch commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-391161200 Valid SQL was always the assumption, for simplicity and clarity. `MetricsControl` kind of changes the

[GitHub] mistercrunch commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression

2018-05-17 Thread GitBox
mistercrunch commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389936762 All examples get executed as integration test, so if you add a new example chart that cover this use