[GitHub] mistercrunch commented on issue #5152: Use Rison for the explore URL

2018-06-11 Thread GitBox
mistercrunch commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-396419762 How about bringing it into our staging and then production for a while and revisiting?

[GitHub] mistercrunch commented on issue #5152: Use Rison for the explore URL

2018-06-11 Thread GitBox
mistercrunch commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-396416232 @williaster the main driver is mostly readable, and maybe hackable urls. I really wish Rison was more popular / supported. Note that we

[GitHub] mistercrunch commented on issue #5152: Use Rison for the explore URL

2018-06-09 Thread GitBox
mistercrunch commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-396019487 Only thing is this may have some intricacies that are hard to predict (maybe around `null`, `NaN`, `infinity` handling). The assumption

[GitHub] mistercrunch commented on issue #5152: Use Rison for the explore URL

2018-06-09 Thread GitBox
mistercrunch commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-396019388 This LGTM. It could be good to add an entry in the FAQ ("How are the URL formatted?"), or mentioning Rison somewhere else in the docs.

[GitHub] mistercrunch commented on issue #5152: Use Rison for the explore URL

2018-06-06 Thread GitBox
mistercrunch commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-395289500 Did you have to modify anything from python-rison? We could ask the maintainer for write-rights and pypi access on rison too.

[GitHub] mistercrunch commented on issue #5152: Use Rison for the explore URL

2018-06-06 Thread GitBox
mistercrunch commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-395288787 READABLE URLS! This is an automated message from the Apache Git Service.