lilykuang merged PR #27716:
URL: https://github.com/apache/superset/pull/27716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Antonio-RiveroMartnez commented on code in PR #27716:
URL: https://github.com/apache/superset/pull/27716#discussion_r1548463091
##
superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx:
##
@@ -520,41 +598,41 @@ const config: ControlPanelConfig = {
],
zhaoyongjie commented on PR #27716:
URL: https://github.com/apache/superset/pull/27716#issuecomment-2025906499
@Antonio-RiveroMartnez It makes sense! Thanks for the clarification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Antonio-RiveroMartnez commented on PR #27716:
URL: https://github.com/apache/superset/pull/27716#issuecomment-2025851889
> @lilykuang please hold on this PR, because the entire time comparison is
waiting for the SIP.
This is not pointing to master but rather a custom `Feature Branch`
zhaoyongjie commented on PR #27716:
URL: https://github.com/apache/superset/pull/27716#issuecomment-2025818770
@lilykuang please keep this PR, because the entire time comparison is
waiting for the SIP.
--
This is an automated message from the Apache Git Service.
To respond to the
john-bodley commented on PR #27716:
URL: https://github.com/apache/superset/pull/27716#issuecomment-2025742893
My only comment regarding this is I hope we're thinking in a holistic manner
in terms of how best to define color options across all chart types as opposed
to a specific chart.
codecov[bot] commented on PR #27716:
URL: https://github.com/apache/superset/pull/27716#issuecomment-2023905109
##
[Codecov](https://app.codecov.io/gh/apache/superset/pull/27716?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
lilykuang opened a new pull request, #27716:
URL: https://github.com/apache/superset/pull/27716
### SUMMARY
Adding color option for table with time comparison
- Create a new collapsible section titled "Visual formatting."
- Inside, include a subsection called "Cell bars"
