github-actions[bot] commented on PR #27717:
URL: https://github.com/apache/superset/pull/27717#issuecomment-2040218218
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
justinpark merged PR #27717:
URL: https://github.com/apache/superset/pull/27717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
justinpark commented on PR #27717:
URL: https://github.com/apache/superset/pull/27717#issuecomment-2038473445
> justinpark If you resize the left panel, it's cutting the text.
@michael-s-molina I fixed by the text ellipsis.
michael-s-molina commented on PR #27717:
URL: https://github.com/apache/superset/pull/27717#issuecomment-2036959077
@justinpark If you resize the left panel, it's cutting the text.
https://github.com/apache/superset/assets/70410625/7fcbfaed-3cba-498f-909d-5f7ba50067f2;>
--
This is
github-actions[bot] commented on PR #27717:
URL: https://github.com/apache/superset/pull/27717#issuecomment-2036882893
@michael-s-molina Ephemeral environment spinning up at
http://35.94.26.119:8080. Credentials are `admin`/`admin`. Please allow several
minutes for bootstrapping and
michael-s-molina commented on PR #27717:
URL: https://github.com/apache/superset/pull/27717#issuecomment-2036866320
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
justinpark commented on PR #27717:
URL: https://github.com/apache/superset/pull/27717#issuecomment-2035327513
> I would only keep the background white to not mix it with the draggable
items and because this looks like a secondary information that does not need to
be highlighted frequently.
michael-s-molina commented on PR #27717:
URL: https://github.com/apache/superset/pull/27717#issuecomment-2034325536
This looks nice @justinpark. We won't have the Undo link right? I'm assuming
that you can't undo the applicability of columns because they depend on what's
already configured
justinpark commented on PR #27717:
URL: https://github.com/apache/superset/pull/27717#issuecomment-2033242316
@michael-s-molina If you are interested in considering feedback, this
proposal suggests adopting a Gmail-style approach.
michael-s-molina commented on PR #27717:
URL: https://github.com/apache/superset/pull/27717#issuecomment-2027598144
@justinpark I think it would be important to show some kind of
message/feedback to the users when we have columns or metrics hidden because
they can't be used anywhere. Maybe
michael-s-molina commented on PR #27717:
URL: https://github.com/apache/superset/pull/27717#issuecomment-2027591888
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
justinpark commented on code in PR #27717:
URL: https://github.com/apache/superset/pull/27717#discussion_r1543424149
##
superset-frontend/src/explore/components/DatasourcePanel/index.tsx:
##
@@ -122,18 +127,48 @@ const StyledInfoboxWrapper = styled.div`
const BORDER_WIDTH =
12 matches
Mail list logo
