Re: [PR] chore(translations): fix translations order [superset]

2024-04-22 Thread via GitHub
rusackas merged PR #28031: URL: https://github.com/apache/superset/pull/28031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] chore(translations): fix translations order [superset]

2024-04-19 Thread via GitHub
rusackas commented on PR #28031: URL: https://github.com/apache/superset/pull/28031#issuecomment-2067169093 Running Ci... then we'll merge it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] chore(translations): fix translations order [superset]

2024-04-19 Thread via GitHub
lscheibel commented on PR #28031: URL: https://github.com/apache/superset/pull/28031#issuecomment-2066244030 Thanks for taking a look everyone. I fixed the line endings of the .po and .pot files, which were failing the CI. -- This is an automated message from the Apache Git Service. To re

Re: [PR] chore(translations): fix translations order [superset]

2024-04-18 Thread via GitHub
rusackas commented on PR #28031: URL: https://github.com/apache/superset/pull/28031#issuecomment-2064201114 Running CI 🤞 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] chore(translations): fix translations order [superset]

2024-04-18 Thread via GitHub
rusackas commented on code in PR #28031: URL: https://github.com/apache/superset/pull/28031#discussion_r1570961303 ## superset/sql_parse.py: ## @@ -765,8 +765,8 @@ def _extract_tables_from_sql(self) -> set[Table]: SupersetError( error_type=S

Re: [PR] chore(translations): fix translations order [superset]

2024-04-16 Thread via GitHub
john-bodley commented on code in PR #28031: URL: https://github.com/apache/superset/pull/28031#discussion_r1567715496 ## superset/sql_parse.py: ## @@ -765,8 +765,8 @@ def _extract_tables_from_sql(self) -> set[Table]: SupersetError( error_typ

Re: [PR] chore(translations): fix translations order [superset]

2024-04-15 Thread via GitHub
rusackas commented on code in PR #28031: URL: https://github.com/apache/superset/pull/28031#discussion_r1566230444 ## superset/sql_parse.py: ## @@ -765,8 +765,8 @@ def _extract_tables_from_sql(self) -> set[Table]: SupersetError( error_type=S