rusackas merged PR #27773:
URL: https://github.com/apache/superset/pull/27773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
fisjac closed pull request #27773: feat(alert report tabs): adding feature flag
URL: https://github.com/apache/superset/pull/27773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
michael-s-molina commented on PR #27773:
URL: https://github.com/apache/superset/pull/27773#issuecomment-2045764543
Hi @fisjac. Both options are valid but if you opt for the feature flag
(useful if multiple developers), you need to update the `FEATURE_FLAGS.md` file.
--
This is an
rusackas commented on PR #27773:
URL: https://github.com/apache/superset/pull/27773#issuecomment-2045755351
Hey @fisjac - I think @michael-s-molina means that you just need to add an
entry to [this
file](https://github.com/apache/superset/blob/master/RESOURCES/FEATURE_FLAGS.md).
fisjac commented on PR #27773:
URL: https://github.com/apache/superset/pull/27773#issuecomment-2045739890
@michael-s-molina could you clarify what you mean. It seems we have a couple
options here:
1. build the feature flag and merge in. This would enable building smaller
PRs to build
michael-s-molina commented on PR #27773:
URL: https://github.com/apache/superset/pull/27773#issuecomment-2027129919
@fisjac Is it possible to implement the feature in a branch which is merged
when the feature is complete? We're trying to avoid creating additional feature
flags unless
codecov[bot] commented on PR #27773:
URL: https://github.com/apache/superset/pull/27773#issuecomment-2026264646
##
[Codecov](https://app.codecov.io/gh/apache/superset/pull/27773?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
