[GitHub] [incubator-superset] pducic commented on issue #5984: +1 to addition of Elasticsearch support.
pducic commented on issue #5984: +1 to addition of Elasticsearch support. URL: https://github.com/apache/incubator-superset/issues/5984#issuecomment-521143698 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] semantiDan opened a new pull request #8045: Added WPSemantix to list of companies using Apache Superset in README file
semantiDan opened a new pull request #8045: Added WPSemantix to list of companies using Apache Superset in README file URL: https://github.com/apache/incubator-superset/pull/8045 ### CATEGORY - [x] Documentation ### SUMMARY Added WP-Semantix to list of companies using Apache Superset in README.md file ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF **BEFORE:** List of companies using Apache Superset from the README.md file:  **AFTER:** List of companies using Apache Superset from the README.md file:  ### TEST PLAN None needed ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] semantiDan opened a new pull request #8045: Added WPSemantix to list of companies using Apache Superset in README file
semantiDan opened a new pull request #8045: Added WPSemantix to list of companies using Apache Superset in README file URL: https://github.com/apache/incubator-superset/pull/8045 ### CATEGORY - [x] Documentation ### SUMMARY Added WP-Semantix to list of companies using Apache Superset in README.md file ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF **BEFORE:** List of companies using Apache Superset from the README.md file:  **AFTER:** List of companies using Apache Superset from the README.md file:  ### TEST PLAN None needed ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] semantiDan closed pull request #8045: Added WPSemantix to list of companies using Apache Superset in README file
semantiDan closed pull request #8045: Added WPSemantix to list of companies using Apache Superset in README file URL: https://github.com/apache/incubator-superset/pull/8045 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mashciku commented on issue #7923: Admin and alpha account cannot access dashboard
mashciku commented on issue #7923: Admin and alpha account cannot access
dashboard
URL:
https://github.com/apache/incubator-superset/issues/7923#issuecomment-521182486
Here it is; this is the error I get every time I try to access the dashboard
using alpha and admin accounts or if I try to add charts to new dashboards
2019-08-14 12:54:10,370:INFO:werkzeug:41.215.58.118 - - [14/Aug/2019
12:54:10] "GET /dashboard/list/ HTTP/1.1" 500 -
Traceback (most recent call last):
File "/home/cmacharia/superset/lib/python3.6/site-packages/flask/app.py",
line 1997, in __call__
return self.wsgi_app(environ, start_response)
File "/home/cmacharia/superset/lib/python3.6/site-packages/flask/app.py",
line 1985, in wsgi_app
response = self.handle_exception(e)
File "/home/cmacharia/superset/lib/python3.6/site-packages/flask/app.py",
line 1540, in handle_exception
reraise(exc_type, exc_value, tb)
File
"/home/cmacharia/superset/lib/python3.6/site-packages/flask/_compat.py", line
33, in reraise
raise value
File "/home/cmacharia/superset/lib/python3.6/site-packages/flask/app.py",
line 1982, in wsgi_app
response = self.full_dispatch_request()
File "/home/cmacharia/superset/lib/python3.6/site-packages/flask/app.py",
line 1614, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/cmacharia/superset/lib/python3.6/site-packages/flask/app.py",
line 1517, in handle_user_exception
reraise(exc_type, exc_value, tb)
File
"/home/cmacharia/superset/lib/python3.6/site-packages/flask/_compat.py", line
33, in reraise
raise value
File "/home/cmacharia/superset/lib/python3.6/site-packages/flask/app.py",
line 1612, in full_dispatch_request
rv = self.dispatch_request()
File "/home/cmacharia/superset/lib/python3.6/site-packages/flask/app.py",
line 1598, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File
"/home/cmacharia/superset/lib/python3.6/site-packages/flask_appbuilder/security/decorators.py",
line 123, in wraps
return f(self, *args, **kwargs)
File
"/home/cmacharia/superset/lib/python3.6/site-packages/flask_appbuilder/views.py",
line 531, in list
self.list_template, title=self.list_title, widgets=widgets
File
"/home/cmacharia/superset/lib/python3.6/site-packages/flask_appbuilder/baseviews.py",
line 224, in render_template
template, **dict(list(kwargs.items()) + list(self.extra_args.items()))
File
"/home/cmacharia/superset/lib/python3.6/site-packages/flask/templating.py",
line 134, in render_template
context, ctx.app)
File
"/home/cmacharia/superset/lib/python3.6/site-packages/flask/templating.py",
line 116, in _render
rv = template.render(context)
File
"/home/cmacharia/superset/lib/python3.6/site-packages/jinja2/asyncsupport.py",
line 76, in render
return original_render(self, *args, **kwargs)
File
"/home/cmacharia/superset/lib/python3.6/site-packages/jinja2/environment.py",
line 1008, in render
return self.environment.handle_exception(exc_info, True)
File
"/home/cmacharia/superset/lib/python3.6/site-packages/jinja2/environment.py",
line 780, in handle_exception
reraise(exc_type, exc_value, tb)
File
"/home/cmacharia/superset/lib/python3.6/site-packages/jinja2/_compat.py", line
37, in reraise
raise value.with_traceback(tb)
File
"/home/cmacharia/superset/lib/python3.6/site-packages/superset/templates/appbuilder/general/model/list.html",
line 2, in top-level template code
{% import 'appbuilder/general/lib.html' as lib %}
File
"/home/cmacharia/superset/lib/python3.6/site-packages/flask_appbuilder/templates/appbuilder/base.html",
line 1, in top-level template code
{% extends base_template %}
File
"/home/cmacharia/superset/lib/python3.6/site-packages/superset/templates/superset/base.html",
line 1, in top-level template code
{% extends "appbuilder/baselayout.html" %}
File
"/home/cmacharia/superset/lib/python3.6/site-packages/superset/templates/appbuilder/baselayout.html",
line 2, in top-level template code
{% import 'appbuilder/baselib.html' as baselib %}
File
"/home/cmacharia/superset/lib/python3.6/site-packages/flask_appbuilder/templates/appbuilder/init.html",
line 46, in top-level template code
{% block body %}
File
"/home/cmacharia/superset/lib/python3.6/site-packages/superset/templates/appbuilder/baselayout.html",
line 21, in block "body"
{% block content %}
File
"/home/cmacharia/superset/lib/python3.6/site-packages/superset/templates/appbuilder/general/model/list.html",
line 12, in block "content"
{% block list_list scoped %}
File
"/home/cmacharia/superset/lib/python3.6/site-packages/superset/templates/appbuilder/general/model/list.html",
line 13, in block "list_list"
{{ widgets.get('list')()|safe }}
File
"
[GitHub] [incubator-superset] guanpei commented on issue #7495: unhashable type: 'dict'
guanpei commented on issue #7495: unhashable type: 'dict' URL: https://github.com/apache/incubator-superset/issues/7495#issuecomment-521183520 谢谢 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] hemantaggarwal commented on issue #3489: Publish Superset dashboard online and remote login
hemantaggarwal commented on issue #3489: Publish Superset dashboard online and remote login URL: https://github.com/apache/incubator-superset/issues/3489#issuecomment-521185735 I know this is closed but I have similar issue and I tried binding superset to different IP using option "-a" but after running command it says "no such option -a". I tried to run following command: superset run -a "192.168.89.107" -p 8088 --with-threads --reload --debugger Superset version: 0.28.1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] hemantaggarwal edited a comment on issue #3489: Publish Superset dashboard online and remote login
hemantaggarwal edited a comment on issue #3489: Publish Superset dashboard online and remote login URL: https://github.com/apache/incubator-superset/issues/3489#issuecomment-521185735 I know this is closed but I have similar issue and I tried binding superset to different IP using option "-a" but after running command it says "no such option -a". I tried to run following command: "superset run -a "192.168.89.107" -p 8088 --with-threads --reload --debugger" Superset version: 0.28.1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] hemantaggarwal removed a comment on issue #3489: Publish Superset dashboard online and remote login
hemantaggarwal removed a comment on issue #3489: Publish Superset dashboard online and remote login URL: https://github.com/apache/incubator-superset/issues/3489#issuecomment-521185735 I know this is closed but I have similar issue and I tried binding superset to different IP using option "-a" but after running command it says "no such option -a". I tried to run following command: "superset run -a "192.168.89.107" -p 8088 --with-threads --reload --debugger" Superset version: 0.28.1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8046: json web token authentication to acces api inside the superset
issue-label-bot[bot] commented on issue #8046: json web token authentication to acces api inside the superset URL: https://github.com/apache/incubator-superset/issues/8046#issuecomment-521207926 Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.75. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] kalimuthu123 opened a new issue #8046: json web token authentication to acces api inside the superset
kalimuthu123 opened a new issue #8046: json web token authentication to acces api inside the superset URL: https://github.com/apache/incubator-superset/issues/8046 **Is your feature request related to a problem? Please describe.** i want to use the superset as a api source for many different application **Describe the solution you'd like** Flask-protorian // jwt-extended **Describe alternatives you've considered** when adding the configurations to tht superset the problems occurs in the loading the superset **Additional context** api level of source outside with safety login This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] kalimuthu123 commented on issue #2488: How to authenticate with REST API
kalimuthu123 commented on issue #2488: How to authenticate with REST API URL: https://github.com/apache/incubator-superset/issues/2488#issuecomment-521238255 i need authentication by using json web tokens This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] semantiDan opened a new pull request #8045: Added WPSemantix to list of companies using Apache Superset in README file
semantiDan opened a new pull request #8045: Added WPSemantix to list of companies using Apache Superset in README file URL: https://github.com/apache/incubator-superset/pull/8045 ### CATEGORY - [x] Documentation ### SUMMARY Added WP-Semantix to list of companies using Apache Superset in README.md file ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF **BEFORE:** List of companies using Apache Superset from the README.md file:  **AFTER:** List of companies using Apache Superset from the README.md file:  ### TEST PLAN None needed ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] semantiDan closed pull request #8045: Added WPSemantix to list of companies using Apache Superset in README file
semantiDan closed pull request #8045: Added WPSemantix to list of companies using Apache Superset in README file URL: https://github.com/apache/incubator-superset/pull/8045 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8045: Added WPSemantix to list of companies using Apache Superset in README file
codecov-io commented on issue #8045: Added WPSemantix to list of companies using Apache Superset in README file URL: https://github.com/apache/incubator-superset/pull/8045#issuecomment-521247301 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8045?src=pr&el=h1) Report > Merging [#8045](https://codecov.io/gh/apache/incubator-superset/pull/8045?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/613dcf5def6b6c7e3eedbaac442614edd38a95b8?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8045?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#8045 +/- ## === Coverage 65.56% 65.56% === Files 469 469 Lines 2247822478 Branches 2442 2442 === Hits1473814738 Misses 7620 7620 Partials 120 120 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8045?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8045?src=pr&el=footer). Last update [613dcf5...87b4ffb](https://codecov.io/gh/apache/incubator-superset/pull/8045?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8045: Added WPSemantix to list of companies using Apache Superset in README file
codecov-io edited a comment on issue #8045: Added WPSemantix to list of companies using Apache Superset in README file URL: https://github.com/apache/incubator-superset/pull/8045#issuecomment-521247301 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8045?src=pr&el=h1) Report > Merging [#8045](https://codecov.io/gh/apache/incubator-superset/pull/8045?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/613dcf5def6b6c7e3eedbaac442614edd38a95b8?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8045?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#8045 +/- ## === Coverage 65.56% 65.56% === Files 469 469 Lines 2247822478 Branches 2442 2442 === Hits1473814738 Misses 7620 7620 Partials 120 120 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8045?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8045?src=pr&el=footer). Last update [613dcf5...87b4ffb](https://codecov.io/gh/apache/incubator-superset/pull/8045?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar opened a new pull request #8047: [database] Improve connection URI validation
dpgaspar opened a new pull request #8047: [database] Improve connection URI validation URL: https://github.com/apache/incubator-superset/pull/8047 ### CATEGORY - [ ] Bug Fix - [X] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Improves database connection form validation (and API data submission). Before a user would only know about URI parse validation errors after form submission, now an error is show to the user while still editing the form. This change Introduces 2 optional config keys: `SUPERSET_SUPPORTED_DB_DRIVERS` and `SUPERSET_ENFORCE_DB_ARGUMENTS` ex: ``` python SUPERSET_SUPPORTED_DB_DRIVERS = ['postgresql', 'mysql'] SUPERSET_ENFORCE_DB_ARGUMENTS = ['sslmode'] ``` ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [X] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [X] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #8045: Added WPSemantix to list of companies using Apache Superset in README file
villebro merged pull request #8045: Added WPSemantix to list of companies using Apache Superset in README file URL: https://github.com/apache/incubator-superset/pull/8045 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #8039: Disable flaky cypress test
mistercrunch merged pull request #8039: Disable flaky cypress test URL: https://github.com/apache/incubator-superset/pull/8039 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #8044: fix: issues #8041 - bubble support for complex metrics
mistercrunch merged pull request #8044: fix: issues #8041 - bubble support for complex metrics URL: https://github.com/apache/incubator-superset/pull/8044 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #8044: fix: issues #8041 - bubble support for complex metrics
mistercrunch commented on issue #8044: fix: issues #8041 - bubble support for complex metrics URL: https://github.com/apache/incubator-superset/pull/8044#issuecomment-521318727 Yes ideally we'd do something better upfront, but this fixes the bug. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #8047: [database] Improve connection URI validation
mistercrunch commented on issue #8047: [database] Improve connection URI validation URL: https://github.com/apache/incubator-superset/pull/8047#issuecomment-521347785 I was thinking something more generic, that would get a handle on the database model instance and raise if things aren't ok. I'm thinking this gets super engine-specific and it's unclear what other implementations/environment may want. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] suvarnaC opened a new issue #8048: Dashboard emails/chart emails schedules menu not showing up with master branch code
suvarnaC opened a new issue #8048: Dashboard emails/chart emails schedules menu
not showing up with master branch code
URL: https://github.com/apache/incubator-superset/issues/8048
A clear and concise description of what the bug is.
The Dashboard emails/Chart emails schedule menu is not showing up even after
config file is edited with email specific settings. Only seen in latest master
branch code that i deployed.
### Expected results
The menu should be visibile if we enable email in the config.py file
### Actual results
No menus showsn
Screenshots
If applicable, add screenshots to help explain your problem.
How to reproduce the bug
1. get latest master code from github and deploy it
2. Edit config.py and enable email
3. Login to superset and Click on manage menu
4. No email specific menus shown
### Environment
(please complete the following information):
- superset version: master
- python version: 3.6.8
- node.js version: `node -v`
- npm version: `npm -v`
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included
it here as text if there are any.
- [ ] I have reproduced the issue with at least the latest released version
of superset.
- [ ] I have checked the issue tracker for the same issue and I haven't
found one similar.
### Additional context
Add any other context about the problem here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8048: Dashboard emails/chart emails schedules menu not showing up with master branch code
issue-label-bot[bot] commented on issue #8048: Dashboard emails/chart emails schedules menu not showing up with master branch code URL: https://github.com/apache/incubator-superset/issues/8048#issuecomment-521396546 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.94. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on issue #7413: feature: see Presto row and array data types
john-bodley commented on issue #7413: feature: see Presto row and array data
types
URL:
https://github.com/apache/incubator-superset/pull/7413#issuecomment-521397338
@betodealmeida @khtruong @DiggidyDave we're running into issues with this
feature as it doesn't seem to handle all the Presto [structural
types](https://prestodb.github.io/docs/current/language/types) i.e., it's
missing the the `MAP`. This isn't problematic in itself but it's an issue when
the `ROW` or `ARRAY` contains a `MAP` object, i.e, `array(map(varchar,
varchar))`.
The failure is:
```
{"error": "list index out of range", "stacktrace": "Traceback (most recent
call last):\n File \"/srv/superset/superset/views/core.py\", line 2284, in
table\ncolumns = mydb.get_columns(table_name, schema)\n File
\"/srv/superset/superset/models/core.py\", line 1154, in get_columns\n
return self.db_engine_spec.get_columns(self.inspector, table_name, schema)\n
File \"/srv/superset/superset/db_engine_specs/presto.py\", line 235, in
get_columns\ncls._parse_structural_column(column.Column, column.Type,
result)\n File \"/srv/superset/superset/db_engine_specs/presto.py\", line 157,
in _parse_structural_column\nif field_info[1] == \"array\" or field_info[1]
== \"row\":\nIndexError: list index out of range\n"}
```
I looked into trying to fix (checking the length of `field_info`) but I
don't fully follow the logic and I'm unsure whether a `MAP` needs to be handled
like an `ARRAY` or `ROW` and thus where I should fix this. Note that a `MAP`
can consist of other structural types.
Note I'm uncertain how complex the fix is but could Lyft either i) look into
fixing this in the next 48 hours, ii) put the feature behind a feature flag, or
iii) revert the change whilst a long term solution is found.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on issue #7413: feature: see Presto row and array data types
betodealmeida commented on issue #7413: feature: see Presto row and array data types URL: https://github.com/apache/incubator-superset/pull/7413#issuecomment-521399092 @john-bodley I started working on a PR simplifying a lot of the logic here, let me see if it fixes this case, and if so how much work would be needed to finish it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8037: fix: handle case where result exists but corresponding query cannot be found
etr2460 commented on a change in pull request #8037: fix: handle case where result exists but corresponding query cannot be found URL: https://github.com/apache/incubator-superset/pull/8037#discussion_r314090865 ## File path: superset/views/core.py ## @@ -2398,7 +2398,13 @@ def results(self, key): status=410, ) -query = db.session.query(Query).filter_by(results_key=key).one() +query = db.session.query(Query).filter_by(results_key=key).one_or_none() +if query is None: +return json_error_response( +"Data could not be retrieved. You may want to re-run the query.", +status=410, Review comment: Is this the proper status code? if the query isn't found, then I think 404 might be better This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8037: fix: handle case where result exists but corresponding query cannot be found
serenajiang commented on a change in pull request #8037: fix: handle case where result exists but corresponding query cannot be found URL: https://github.com/apache/incubator-superset/pull/8037#discussion_r314099639 ## File path: superset/views/core.py ## @@ -2398,7 +2398,13 @@ def results(self, key): status=410, ) -query = db.session.query(Query).filter_by(results_key=key).one() +query = db.session.query(Query).filter_by(results_key=key).one_or_none() +if query is None: +return json_error_response( +"Data could not be retrieved. You may want to re-run the query.", +status=410, Review comment: I was debating whether to use 404, which I think fits better, or 410 like a previous similar error message used. I'll use 404 to make it easier to differentiate. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8037: fix: handle case where result exists but corresponding query cannot be found
codecov-io commented on issue #8037: fix: handle case where result exists but corresponding query cannot be found URL: https://github.com/apache/incubator-superset/pull/8037#issuecomment-521437032 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8037?src=pr&el=h1) Report > Merging [#8037](https://codecov.io/gh/apache/incubator-superset/pull/8037?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/075b5a5d33e78c6da6ec72d9c2ece37d8a0adce7?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8037?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8037 +/- ## == + Coverage 65.54% 65.55% +0.01% == Files 469 469 Lines 2247622482 +6 Branches 2440 2442 +2 == + Hits1473214739 +7 + Misses 7624 7623 -1 Partials 120 120 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8037?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.11% <0%> (-0.11%)` | :arrow_down: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/8037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.58% <0%> (-0.03%)` | :arrow_down: | | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `87.83% <0%> (ø)` | :arrow_up: | | [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXJBY3Rpb25zRHJvcGRvd24uanN4) | `69.56% <0%> (+0.67%)` | :arrow_up: | | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9SZWZyZXNoSW50ZXJ2YWxNb2RhbC5qc3g=) | `100% <0%> (+30.76%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8037?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8037?src=pr&el=footer). Last update [075b5a5...0c90753](https://codecov.io/gh/apache/incubator-superset/pull/8037?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8037: fix: handle case where result exists but corresponding query cannot be found
codecov-io edited a comment on issue #8037: fix: handle case where result exists but corresponding query cannot be found URL: https://github.com/apache/incubator-superset/pull/8037#issuecomment-521437032 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8037?src=pr&el=h1) Report > Merging [#8037](https://codecov.io/gh/apache/incubator-superset/pull/8037?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/075b5a5d33e78c6da6ec72d9c2ece37d8a0adce7?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8037?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8037 +/- ## == + Coverage 65.54% 65.55% +0.01% == Files 469 469 Lines 2247622482 +6 Branches 2440 2442 +2 == + Hits1473214739 +7 + Misses 7624 7623 -1 Partials 120 120 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8037?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.11% <0%> (-0.11%)` | :arrow_down: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/8037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.58% <0%> (-0.03%)` | :arrow_down: | | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `87.83% <0%> (ø)` | :arrow_up: | | [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXJBY3Rpb25zRHJvcGRvd24uanN4) | `69.56% <0%> (+0.67%)` | :arrow_up: | | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9SZWZyZXNoSW50ZXJ2YWxNb2RhbC5qc3g=) | `100% <0%> (+30.76%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8037?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8037?src=pr&el=footer). Last update [075b5a5...0c90753](https://codecov.io/gh/apache/incubator-superset/pull/8037?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch opened a new pull request #8049: fix: onSave datasource raises React error
mistercrunch opened a new pull request #8049: fix: onSave datasource raises React error URL: https://github.com/apache/incubator-superset/pull/8049 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY When saving a datasource in the explore view, React throws up ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF https://user-images.githubusercontent.com/487433/63065975-fa101d80-bebc-11e9-86cd-4cfae4a58a45.png";> ### TEST PLAN Wrote a unit test to make sure React doesn't fail when props are null This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8049: fix: onSave datasource raises React error
codecov-io commented on issue #8049: fix: onSave datasource raises React error URL: https://github.com/apache/incubator-superset/pull/8049#issuecomment-521480198 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8049?src=pr&el=h1) Report > Merging [#8049](https://codecov.io/gh/apache/incubator-superset/pull/8049?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed8bb1b694e95df661bb99ff877097d749a0c9e0?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8049?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8049 +/- ## == + Coverage 65.56% 65.56% +<.01% == Files 469 469 Lines 2248022482 +2 Branches 2442 2444 +2 == + Hits1473914741 +2 Misses 7621 7621 Partials 120 120 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8049?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvTWV0cmljc0NvbnRyb2wuanN4) | `80.13% <100%> (+0.26%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8049?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8049?src=pr&el=footer). Last update [ed8bb1b...055eaa9](https://codecov.io/gh/apache/incubator-superset/pull/8049?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8050: Some pages are missing causing css to fail
issue-label-bot[bot] commented on issue #8050: Some pages are missing causing css to fail URL: https://github.com/apache/incubator-superset/issues/8050#issuecomment-521487824 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.99. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] REmango opened a new issue #8050: Some pages are missing causing css to fail
REmango opened a new issue #8050: Some pages are missing causing css to fail URL: https://github.com/apache/incubator-superset/issues/8050 This bug has appeared in previous versions, but it has not been fixed. ### Superset version 0.28.1 ### Performance on Chrome In the project, missing will cause ‘line-height’ to fail in some cases. ### Affected page sqllab, dashboard, explore, addSlice etc. ### fix bug Add on basic.html This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch opened a new pull request #8051: bump a set of test-related JS libs
mistercrunch opened a new pull request #8051: bump a set of test-related JS libs URL: https://github.com/apache/incubator-superset/pull/8051 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [x] Build / Development Environment - [ ] Documentation ### SUMMARY Mostly upgrading jest as I was trying to tackle issues related to wrong source-maps reporting in jest. Bumping did not address the issue, but figured I'd still open a PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #8051: bump a set of test-related JS libs
mistercrunch commented on a change in pull request #8051: bump a set of test-related JS libs URL: https://github.com/apache/incubator-superset/pull/8051#discussion_r314175530 ## File path: .pre-commit-config.yaml ## @@ -27,7 +27,6 @@ repos: - id: trailing-whitespace - id: end-of-file-fixer - id: check-docstring-first -- id: check-json Review comment: This was giving me trouble with he `.babelrc` changes... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #8051: bump a set of test-related JS libs
mistercrunch commented on a change in pull request #8051: bump a set of
test-related JS libs
URL:
https://github.com/apache/incubator-superset/pull/8051#discussion_r314175575
##
File path: superset/assets/.babelrc
##
@@ -17,6 +17,8 @@
* under the License.
*/
{
+ "sourceMaps": true,
Review comment:
These 2 lines are the actual fix.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #8051: bump a set of test-related JS libs
mistercrunch commented on a change in pull request #8051: bump a set of test-related JS libs URL: https://github.com/apache/incubator-superset/pull/8051#discussion_r314175872 ## File path: superset/assets/spec/helpers/shim.js ## @@ -17,7 +17,8 @@ * under the License. */ /* eslint no-native-reassign: 0 */ -import '@babel/polyfill'; Review comment: This got deprecated in favor of the new approach described here https://www.npmjs.com/package/@babel/polyfill This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #7714: Unable to use FilterBox, seems some react error, Superset version "release--0.31"
stale[bot] commented on issue #7714: Unable to use FilterBox, seems some react error, Superset version "release--0.31" URL: https://github.com/apache/incubator-superset/issues/7714#issuecomment-521517521 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8051: bump a set of test-related JS libs
codecov-io commented on issue #8051: bump a set of test-related JS libs URL: https://github.com/apache/incubator-superset/pull/8051#issuecomment-521521811 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8051?src=pr&el=h1) Report > Merging [#8051](https://codecov.io/gh/apache/incubator-superset/pull/8051?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed8bb1b694e95df661bb99ff877097d749a0c9e0?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8051?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8051 +/- ## == - Coverage 65.56% 65.55% -0.01% == Files 469 469 Lines 2248022485 +5 Branches 2442 2446 +4 == + Hits1473914741 +2 - Misses 7621 7624 +3 Partials 120 120 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8051?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/assets/src/query/Metric.ts](https://codecov.io/gh/apache/incubator-superset/pull/8051/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9xdWVyeS9NZXRyaWMudHM=) | `0% <0%> (ø)` | :arrow_up: | | [superset/assets/src/utils/safeStringify.ts](https://codecov.io/gh/apache/incubator-superset/pull/8051/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy91dGlscy9zYWZlU3RyaW5naWZ5LnRz) | `100% <0%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8051?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8051?src=pr&el=footer). Last update [ed8bb1b...cfa33de](https://codecov.io/gh/apache/incubator-superset/pull/8051?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
