lilila edited a comment on issue #6799: Table view as dashboard filter - don't
highlight item or clear filter
URL:
https://github.com/apache/incubator-superset/issues/6799#issuecomment-530721558
I have the same issue with superset 0.34: When selected elements are clicked
a second time
codecov-io edited a comment on issue #8163: [SQLLab] Refactor sql json endpoint
URL:
https://github.com/apache/incubator-superset/pull/8163#issuecomment-529036459
#
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=h1)
Report
> Merging
codecov-io edited a comment on issue #8163: [SQLLab] Refactor sql json endpoint
URL:
https://github.com/apache/incubator-superset/pull/8163#issuecomment-529036459
#
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=h1)
Report
> Merging
codecov-io edited a comment on issue #8163: [SQLLab] Refactor sql json endpoint
URL:
https://github.com/apache/incubator-superset/pull/8163#issuecomment-529036459
#
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=h1)
Report
> Merging
graceguo-supercat edited a comment on issue #8060: SIP-23: Persist SQL Lab
state in the backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-530622944
Report a few bugs:
1. if you have multiple queries in the same tab, select the 1st query and
run, refresh
codecov-io edited a comment on issue #8163: [SQLLab] Refactor sql json endpoint
URL:
https://github.com/apache/incubator-superset/pull/8163#issuecomment-529036459
#
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=h1)
Report
> Merging
codecov-io edited a comment on issue #8163: [SQLLab] Refactor sql json endpoint
URL:
https://github.com/apache/incubator-superset/pull/8163#issuecomment-529036459
#
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=h1)
Report
> Merging
stale[bot] commented on issue #6348: Mapbox dosen't show anything
URL:
https://github.com/apache/incubator-superset/issues/6348#issuecomment-530775380
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs.
graceguo-supercat edited a comment on issue #8060: SIP-23: Persist SQL Lab
state in the backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-530622944
Report a few bugs:
1. if you have multiple queries in the same tab, select the 1st query and
run, refresh
lilila commented on issue #6799: Table view as dashboard filter - don't
highlight item or clear filter
URL:
https://github.com/apache/incubator-superset/issues/6799#issuecomment-530721558
I have the same issue with superset 0.34: Filter are not clear clear out.
(but highlighting is OK).
datinho commented on issue #5845: [READY] [feature] Added dashboard read only
with new Rho role
URL:
https://github.com/apache/incubator-superset/pull/5845#issuecomment-530737689
The check fails on TOXENV=cypress-dashboard, it seems a timeout problem
(Travis CI side?) that
I don't
kalimuthu123 commented on issue #5269: Filters as a native dashboard (v2)
construct
URL:
https://github.com/apache/incubator-superset/issues/5269#issuecomment-530856989
the global idea filter request is good we will move forward to nxt levels
bkyryliuk opened a new pull request #8219: [WIP] Build better support for
schema permissions
URL: https://github.com/apache/incubator-superset/pull/8219
NOTE: WIP on testing on the staging and prod @ dropbox
### CATEGORY
Choose one
- [X] Bug Fix
- [X] Enhancement (new
bkyryliuk closed pull request #8189: [Ready] Show databases for users with
schema access in sqllab
URL: https://github.com/apache/incubator-superset/pull/8189
This is an automated message from the Apache Git Service.
To
bkyryliuk commented on issue #8189: [Ready] Show databases for users with
schema access in sqllab
URL:
https://github.com/apache/incubator-superset/pull/8189#issuecomment-530932720
Moved changes to the https://github.com/apache/incubator-superset/pull/8219
closing this RP.
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the
backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-530943398
Thanks for testing it, @graceguo-supercat! I'll work on it today!
paulvic commented on issue #7739: Custom OAuth issue
URL:
https://github.com/apache/incubator-superset/issues/7739#issuecomment-530988166
I've seen a few comments here suggesting the fix didn't work for them. I
don't see them any longer so hopefully they were just config/setup problems.
paulvic edited a comment on issue #7739: Custom OAuth issue
URL:
https://github.com/apache/incubator-superset/issues/7739#issuecomment-530988166
I've seen a few comments here suggesting the fix didn't work for them. I
don't see them any longer so hopefully they were just config/setup
etr2460 commented on a change in pull request #8172: Allow users to estimate
query cost before executing it
URL:
https://github.com/apache/incubator-superset/pull/8172#discussion_r323965557
##
File path: superset/db_engine_specs/presto.py
##
@@ -373,6 +380,79 @@ def
etr2460 commented on a change in pull request #8172: Allow users to estimate
query cost before executing it
URL:
https://github.com/apache/incubator-superset/pull/8172#discussion_r323965788
##
File path: superset/db_engine_specs/base.py
##
@@ -148,6 +149,10 @@ class
etr2460 commented on a change in pull request #8172: Allow users to estimate
query cost before executing it
URL:
https://github.com/apache/incubator-superset/pull/8172#discussion_r323965488
##
File path: superset/db_engine_specs/presto.py
##
@@ -373,6 +380,79 @@ def
serenajiang opened a new pull request #8220: [wip][sqllab] use celery worker
for stop_query
URL: https://github.com/apache/incubator-superset/pull/8220
### CATEGORY
Choose one
- [ ] Bug Fix
- [X] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
etr2460 commented on a change in pull request #8172: Allow users to estimate
query cost before executing it
URL:
https://github.com/apache/incubator-superset/pull/8172#discussion_r323965639
##
File path: superset/models/core.py
##
@@ -773,6 +773,13 @@ def name(self):
etr2460 commented on a change in pull request #8172: Allow users to estimate
query cost before executing it
URL:
https://github.com/apache/incubator-superset/pull/8172#discussion_r323965707
##
File path: superset/views/core.py
##
@@ -2391,6 +2396,34 @@ def
etr2460 commented on a change in pull request #8172: Allow users to estimate
query cost before executing it
URL:
https://github.com/apache/incubator-superset/pull/8172#discussion_r323965087
##
File path: superset/db_engine_specs/presto.py
##
@@ -373,6 +380,79 @@ def
felixcodes commented on issue #8221: fix: initialize control state for inline
control config object
URL:
https://github.com/apache/incubator-superset/pull/8221#issuecomment-531029198
LGTM, but can't approve since I'm not an apache member
robdiciuccio commented on issue #8218: Make pyarrow and msgpack optional
URL:
https://github.com/apache/incubator-superset/pull/8218#issuecomment-530998909
Based on the performance gains of msgpack + pyarrow over raw JSON, it would
be ideal to standardize on this serialization approach
bkyryliuk commented on issue #8218: [WIP] Make pyarrow and msgpack optional
URL:
https://github.com/apache/incubator-superset/pull/8218#issuecomment-531002832
@robdiciuccio pyarrow has only binary distributions for the 0.14.1 and
bkyryliuk edited a comment on issue #8218: [WIP] Make pyarrow and msgpack
optional
URL:
https://github.com/apache/incubator-superset/pull/8218#issuecomment-531002832
@robdiciuccio pyarrow has only binary distributions for the 0.14.1 and
vbassa commented on issue #1952: Add the ability to make annotations on a slice
URL:
https://github.com/apache/incubator-superset/issues/1952#issuecomment-530963066
Has this been implemented? Thanks in advance
This is an
codecov-io commented on issue #8220: [wip][sqllab] use celery worker for
stop_query
URL:
https://github.com/apache/incubator-superset/pull/8220#issuecomment-531025654
#
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8220?src=pr=h1)
Report
> Merging
kristw opened a new pull request #8221: fix: initialize control state for
inline control config object
URL: https://github.com/apache/incubator-superset/pull/8221
### CATEGORY
Choose one
- [X] Bug Fix
### SUMMARY
The initial state was incorrect when using
john-bodley commented on issue #8175: [metric] Exposing security methods for
visualizations and query-context
URL:
https://github.com/apache/incubator-superset/pull/8175#issuecomment-531035257
@mistercrunch thanks for deprecating the restricted metrics (as a side note
I wonder if there
john-bodley edited a comment on issue #8175: [metric] Exposing security methods
for visualizations and query-context
URL:
https://github.com/apache/incubator-superset/pull/8175#issuecomment-531035257
@mistercrunch thanks for deprecating the restricted metrics (as a side note
I wonder if
kristw opened a new pull request #8222: refactor: prepare control panel configs
for separation into plugins
URL: https://github.com/apache/incubator-superset/pull/8222
### CATEGORY
Choose one
- [X] Refactor
### SUMMARY
Prepare control panel configs for separation into
codecov-io commented on issue #8222: refactor: prepare control panel configs
for separation into plugins
URL:
https://github.com/apache/incubator-superset/pull/8222#issuecomment-531036694
#
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8222?src=pr=h1)
Report
>
codecov-io edited a comment on issue #8222: refactor: prepare control panel
configs for separation into plugins
URL:
https://github.com/apache/incubator-superset/pull/8222#issuecomment-531036694
#
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8222?src=pr=h1)
Report
>
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL
Lab state in the backend
URL:
https://github.com/apache/incubator-superset/pull/8060#discussion_r324000859
##
File path: superset/assets/src/SqlLab/components/TabbedSqlEditors.jsx
##
@@ -68,6
john-bodley merged pull request #8214: [talisman] Enforcing HTTP for status
checks
URL: https://github.com/apache/incubator-superset/pull/8214
This is an automated message from the Apache Git Service.
To respond to the
zhaoyongjie opened a new pull request #8223: Fix sync failed when datasource is
schema-less
URL: https://github.com/apache/incubator-superset/pull/8223
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the
backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-531098189
@graceguo-supercat, thanks for testing this thoroughly, I had completely
missed those two cases. I fixed them, and did
betodealmeida commented on a change in pull request #8172: Allow users to
estimate query cost before executing it
URL:
https://github.com/apache/incubator-superset/pull/8172#discussion_r324039248
##
File path: superset/views/core.py
##
@@ -2391,6 +2396,34 @@ def
betodealmeida commented on a change in pull request #8172: Allow users to
estimate query cost before executing it
URL:
https://github.com/apache/incubator-superset/pull/8172#discussion_r324039462
##
File path: superset/db_engine_specs/base.py
##
@@ -148,6 +149,10 @@
betodealmeida commented on a change in pull request #8172: Allow users to
estimate query cost before executing it
URL:
https://github.com/apache/incubator-superset/pull/8172#discussion_r324041463
##
File path: superset/db_engine_specs/presto.py
##
@@ -373,6 +380,79 @@
betodealmeida commented on issue #8172: Allow users to estimate query cost
before executing it
URL:
https://github.com/apache/incubator-superset/pull/8172#issuecomment-531105306
@etr2460, I added types and cleaned up the query execution.
villebro commented on issue #8213: Better distinction between tables and views,
and show CREATE VIEW
URL:
https://github.com/apache/incubator-superset/pull/8213#issuecomment-531108760
LGTM. It hit me, that we should also offer a "get CREATE TABLE statement". I
often like to add comments
stale[bot] closed issue #7364: Firefox Error while fetching Database list
URL: https://github.com/apache/incubator-superset/issues/7364
This is an automated message from the Apache Git Service.
To respond to the message,
betodealmeida commented on a change in pull request #8172: Allow users to
estimate query cost before executing it
URL:
https://github.com/apache/incubator-superset/pull/8172#discussion_r324036255
##
File path: superset/db_engine_specs/presto.py
##
@@ -373,6 +380,79 @@
betodealmeida commented on a change in pull request #8172: Allow users to
estimate query cost before executing it
URL:
https://github.com/apache/incubator-superset/pull/8172#discussion_r324036500
##
File path: superset/db_engine_specs/presto.py
##
@@ -373,6 +380,79 @@
betodealmeida commented on issue #8213: Better distinction between tables and
views, and show CREATE VIEW
URL:
https://github.com/apache/incubator-superset/pull/8213#issuecomment-531098278
@mistercrunch is this good to go as soon as tests pass?
betodealmeida commented on a change in pull request #8172: Allow users to
estimate query cost before executing it
URL:
https://github.com/apache/incubator-superset/pull/8172#discussion_r324038995
##
File path: superset/models/core.py
##
@@ -773,6 +773,13 @@ def
villebro commented on a change in pull request #8172: Allow users to estimate
query cost before executing it
URL:
https://github.com/apache/incubator-superset/pull/8172#discussion_r324043052
##
File path: superset/db_engine_specs/presto.py
##
@@ -373,6 +380,79 @@ def
52 matches
Mail list logo
