[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8167: PUT requests to /tablecolumninlineview/api/update/ fail
issue-label-bot[bot] commented on issue #8167: PUT requests to /tablecolumninlineview/api/update/ fail URL: https://github.com/apache/incubator-superset/issues/8167#issuecomment-527699466 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.93. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 opened a new issue #8167: PUT requests to /tablecolumninlineview/api/update/ fail
etr2460 opened a new issue #8167: PUT requests to
/tablecolumninlineview/api/update/ fail
URL: https://github.com/apache/incubator-superset/issues/8167
Making a PUT request to the tablecolumninlineview api fails when not all
required fields are provided.
### Expected results
Expect a 200 when providing a payload of `{"description": description}`.
### Actual results
Get a 500
`{"error_details":{"column_name":["This field is
required."]},"message":"Validation error","severity":"warning"}`
How to reproduce the bug
1. Create a dimension in superset
2. Hit the API to change the dimension description
3. Get an error
Note that when I include the `column_name` field, this doesn't fail. It
seems like there's an issue with merging the payload with the existing object,
perhaps with the model or in FAB. I would expect to not need the `column_name`
field when making a PUT request
### Environment
Repros on superset master, up to date versions of python and js
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included
it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version
of superset.
- [x] I have checked the issue tracker for the same issue and I haven't
found one similar.
cc @john-bodley @dpgaspar
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #8166: [feature][dashboard] Show filter indicator on the applicable charts when filter is open
graceguo-supercat opened a new pull request #8166: [feature][dashboard] Show filter indicator on the applicable charts when filter is open URL: https://github.com/apache/incubator-superset/pull/8166 ### CATEGORY Choose one - [ ] Bug Fix - [x] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY This is part of dashboard filter indicator design: - when user clicks on indicator, dashboard will navigate to the actual filter_box (done in #7908) - when user open options on a filter_box, the indicators in applicable charts should show up. (thanks for upgrade in #8115 ). See demo below:  This PR also fixed a couple of issue after #7908 is release: 1. show ellipsis for long filter name in tooltip 2. show color bar when filter is applied. 3. when user clicks filter indicator, we used to outline the filter_box. This outline will draw user attention, but after user worked on other area in the dashboard, I feel it is a little annoying with outline still on the old filter_box. So in this PR i make the outline only on about 2 seconds, and will turn off by itself. ### TEST PLAN ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @kristw @etr2460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat merged pull request #8139: [sqllab] add retries for stop_query
graceguo-supercat merged pull request #8139: [sqllab] add retries for stop_query URL: https://github.com/apache/incubator-superset/pull/8139 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8164: [WIP] More detailed async error messages for sqllab
codecov-io commented on issue #8164: [WIP] More detailed async error messages for sqllab URL: https://github.com/apache/incubator-superset/pull/8164#issuecomment-527671948 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8164?src=pr=h1) Report > Merging [#8164](https://codecov.io/gh/apache/incubator-superset/pull/8164?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/436261e703e7b939afe4503ad3f3af2dfe2a6da8?src=pr=desc) will **not change** coverage. > The diff coverage is `60%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8164?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #8164 +/- ## == Coverage66.2% 66.2% == Files 479 479 Lines 22930 22930 Branches 25242524 == Hits15180 15180 Misses 76167616 Partials 134 134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8164?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/8164/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `77.8% <0%> (ø)` | :arrow_up: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/8164/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `40.36% <100%> (ø)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8164/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <100%> (ø)` | :arrow_up: | | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8164/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.05% <50%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8164?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8164?src=pr=footer). Last update [436261e...9cda5f9](https://codecov.io/gh/apache/incubator-superset/pull/8164?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8164: [WIP] More detailed async error messages for sqllab
codecov-io edited a comment on issue #8164: [WIP] More detailed async error messages for sqllab URL: https://github.com/apache/incubator-superset/pull/8164#issuecomment-527671948 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8164?src=pr=h1) Report > Merging [#8164](https://codecov.io/gh/apache/incubator-superset/pull/8164?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/436261e703e7b939afe4503ad3f3af2dfe2a6da8?src=pr=desc) will **not change** coverage. > The diff coverage is `60%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8164?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #8164 +/- ## == Coverage66.2% 66.2% == Files 479 479 Lines 22930 22930 Branches 25242524 == Hits15180 15180 Misses 76167616 Partials 134 134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8164?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/8164/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `77.8% <0%> (ø)` | :arrow_up: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/8164/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `40.36% <100%> (ø)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8164/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <100%> (ø)` | :arrow_up: | | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8164/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.05% <50%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8164?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8164?src=pr=footer). Last update [436261e...9cda5f9](https://codecov.io/gh/apache/incubator-superset/pull/8164?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang opened a new pull request #8164: [WIP] More detailed async error messages for sqllab
serenajiang opened a new pull request #8164: [WIP] More detailed async error messages for sqllab URL: https://github.com/apache/incubator-superset/pull/8164 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Add source of error (presto, hive, etc.) into error messages for sqllab. This will hopefully confuse users a little less. ### REVIEWERS @etr2460 @graceguo-supercat This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang closed pull request #8164: [WIP] More detailed async error messages for sqllab
serenajiang closed pull request #8164: [WIP] More detailed async error messages for sqllab URL: https://github.com/apache/incubator-superset/pull/8164 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common
codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#issuecomment-525919765 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=h1) Report > Merging [#8138](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6aa10dc016455728c7da4dfabd849c59dc9f7f66?src=pr=desc) will **decrease** coverage by `7.36%`. > The diff coverage is `93.13%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8138 +/- ## == - Coverage 73.71% 66.34% -7.37% == Files 115 479 +364 Lines 1205923033 +10974 Branches0 2524+2524 == + Hits 888915282+6393 - Misses 3170 7617+4447 - Partials0 134 +134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `50% <80%> (+22.22%)` | :arrow_up: | | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `25.95% <85%> (+4.35%)` | :arrow_up: | | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `86.36% <85.71%> (-1.52%)` | :arrow_down: | | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.47% <94.87%> (+0.42%)` | :arrow_up: | | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.31% <96.29%> (+0.65%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `85.08% <98.14%> (+0.7%)` | :arrow_up: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.27% <0%> (ø)` | :arrow_up: | | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | | | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | | | [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | `88.23% <0%> (ø)` | | | ... and [363 more](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=footer). Last update [6aa10dc...a44502a](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common
codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#issuecomment-525919765 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=h1) Report > Merging [#8138](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6aa10dc016455728c7da4dfabd849c59dc9f7f66?src=pr=desc) will **decrease** coverage by `7.36%`. > The diff coverage is `93.13%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8138 +/- ## == - Coverage 73.71% 66.34% -7.37% == Files 115 479 +364 Lines 1205923033 +10974 Branches0 2524+2524 == + Hits 888915282+6393 - Misses 3170 7617+4447 - Partials0 134 +134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `50% <80%> (+22.22%)` | :arrow_up: | | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `25.95% <85%> (+4.35%)` | :arrow_up: | | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `86.36% <85.71%> (-1.52%)` | :arrow_down: | | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.47% <94.87%> (+0.42%)` | :arrow_up: | | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.31% <96.29%> (+0.65%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `85.08% <98.14%> (+0.7%)` | :arrow_up: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.27% <0%> (ø)` | :arrow_up: | | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | | | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | | | [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | `88.23% <0%> (ø)` | | | ... and [363 more](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=footer). Last update [6aa10dc...a44502a](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common
codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#issuecomment-525919765 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=h1) Report > Merging [#8138](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6aa10dc016455728c7da4dfabd849c59dc9f7f66?src=pr=desc) will **decrease** coverage by `7.36%`. > The diff coverage is `93.13%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8138 +/- ## == - Coverage 73.71% 66.34% -7.37% == Files 115 479 +364 Lines 1205923033 +10974 Branches0 2524+2524 == + Hits 888915282+6393 - Misses 3170 7617+4447 - Partials0 134 +134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `50% <80%> (+22.22%)` | :arrow_up: | | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `25.95% <85%> (+4.35%)` | :arrow_up: | | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `86.36% <85.71%> (-1.52%)` | :arrow_down: | | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.47% <94.87%> (+0.42%)` | :arrow_up: | | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.31% <96.29%> (+0.65%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `85.08% <98.14%> (+0.7%)` | :arrow_up: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.27% <0%> (ø)` | :arrow_up: | | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | | | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | | | [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | `88.23% <0%> (ø)` | | | ... and [363 more](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=footer). Last update [6aa10dc...a44502a](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common
codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#issuecomment-525919765 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=h1) Report > Merging [#8138](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6aa10dc016455728c7da4dfabd849c59dc9f7f66?src=pr=desc) will **decrease** coverage by `7.36%`. > The diff coverage is `93.13%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8138 +/- ## == - Coverage 73.71% 66.34% -7.37% == Files 115 479 +364 Lines 1205923033 +10974 Branches0 2524+2524 == + Hits 888915282+6393 - Misses 3170 7617+4447 - Partials0 134 +134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `50% <80%> (+22.22%)` | :arrow_up: | | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `25.95% <85%> (+4.35%)` | :arrow_up: | | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `86.36% <85.71%> (-1.52%)` | :arrow_down: | | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.47% <94.87%> (+0.42%)` | :arrow_up: | | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.31% <96.29%> (+0.65%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `85.08% <98.14%> (+0.7%)` | :arrow_up: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.27% <0%> (ø)` | :arrow_up: | | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | | | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | | | [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | `88.23% <0%> (ø)` | | | ... and [363 more](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=footer). Last update [6aa10dc...a44502a](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8139: [sqllab] add retries for stop_query
codecov-io edited a comment on issue #8139: [sqllab] add retries for stop_query URL: https://github.com/apache/incubator-superset/pull/8139#issuecomment-526066743 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=h1) Report > Merging [#8139](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ee24539bd2dc0c66a204015ebcb957a924a55452?src=pr=desc) will **increase** coverage by `0.14%`. > The diff coverage is `42.85%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=tree) ```diff @@Coverage Diff@@ ## master #8139 +/- ## = + Coverage 66.06% 66.2% +0.14% = Files 479 479 Lines 22930 22929 -1 Branches 25242524 = + Hits15148 15180 +32 + Misses 76487615 -33 Partials 134 134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.53% <33.33%> (+0.27%)` | :arrow_up: | | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `77.51% <50%> (+0.04%)` | :arrow_up: | | [superset/assets/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9jaGFydEFjdGlvbi5qcw==) | `49.63% <0%> (ø)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.76% <0%> (+0.64%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=footer). Last update [ee24539...96564d6](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common
etr2460 commented on a change in pull request #8138: [typing] add typing for
superset/connectors and superset/common
URL:
https://github.com/apache/incubator-superset/pull/8138#discussion_r320497728
##
File path: superset/connectors/druid/models.py
##
@@ -146,53 +151,53 @@ def __html__(self):
return self.__repr__()
@property
-def data(self):
+def data(self) -> Dict:
return {"id": self.id, "name": self.cluster_name, "backend": "druid"}
@staticmethod
-def get_base_url(host, port):
+def get_base_url(host, port) -> str:
if not re.match("http(s)?://", host):
host = "http://; + host
url = "{0}:{1}".format(host, port) if port else host
return url
-def get_base_broker_url(self):
+def get_base_broker_url(self) -> str:
base_url = self.get_base_url(self.broker_host, self.broker_port)
return f"{base_url}/{self.broker_endpoint}"
-def get_pydruid_client(self):
+def get_pydruid_client(self) -> PyDruid:
cli = PyDruid(
self.get_base_url(self.broker_host, self.broker_port),
self.broker_endpoint
)
if self.broker_user and self.broker_pass:
cli.set_basic_auth_credentials(self.broker_user, self.broker_pass)
return cli
-def get_datasources(self):
+def get_datasources(self) -> List[Dict]:
endpoint = self.get_base_broker_url() + "/datasources"
auth = requests.auth.HTTPBasicAuth(self.broker_user, self.broker_pass)
return json.loads(requests.get(endpoint, auth=auth).text)
-def get_druid_version(self):
+def get_druid_version(self) -> str:
endpoint = self.get_base_url(self.broker_host, self.broker_port) +
"/status"
auth = requests.auth.HTTPBasicAuth(self.broker_user, self.broker_pass)
return json.loads(requests.get(endpoint, auth=auth).text)["version"]
-@property
+@property # noqa
Review comment:
Got it, can we add this comment instead then to only block certain linting
and not all of it on this line? `# type: ignore`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8165: [bugfix] fix timegrain addon regression
codecov-io commented on issue #8165: [bugfix] fix timegrain addon regression URL: https://github.com/apache/incubator-superset/pull/8165#issuecomment-527652389 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8165?src=pr=h1) Report > Merging [#8165](https://codecov.io/gh/apache/incubator-superset/pull/8165?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ee24539bd2dc0c66a204015ebcb957a924a55452?src=pr=desc) will **increase** coverage by `7.7%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8165?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8165 +/- ## == + Coverage 66.06% 73.76%+7.7% == Files 479 115 -364 Lines 2293012057 -10873 Branches 25240-2524 == - Hits15148 8894-6254 + Misses 7648 3163-4485 + Partials 1340 -134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8165?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `52.23% <100%> (ø)` | :arrow_up: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `77.8% <100%> (ø)` | :arrow_up: | | [superset/db\_engine\_specs/drill.py](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyaWxsLnB5) | `54.16% <100%> (ø)` | :arrow_up: | | [superset/db\_engine\_specs/kylin.py](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2t5bGluLnB5) | `53.84% <100%> (ø)` | :arrow_up: | | [superset/db\_engine\_specs/db2.py](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RiMi5weQ==) | `85.71% <100%> (ø)` | :arrow_up: | | [superset/db\_engine\_specs/teradata.py](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RlcmFkYXRhLnB5) | `88.88% <100%> (ø)` | :arrow_up: | | [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | `57.89% <100%> (ø)` | :arrow_up: | | [superset/db\_engine\_specs/druid.py](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RydWlkLnB5) | `100% <100%> (ø)` | :arrow_up: | | [superset/db\_engine\_specs/impala.py](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2ltcGFsYS5weQ==) | `65% <100%> (ø)` | :arrow_up: | | [superset/db\_engine\_specs/snowflake.py](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Nub3dmbGFrZS5weQ==) | `59.09% <100%> (ø)` | :arrow_up: | | ... and [375 more](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8165?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8165?src=pr=footer). Last update [ee24539...2609c3b](https://codecov.io/gh/apache/incubator-superset/pull/8165?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat merged pull request #8143: [Codemod] Rename react unsafe lifecycles
graceguo-supercat merged pull request #8143: [Codemod] Rename react unsafe lifecycles URL: https://github.com/apache/incubator-superset/pull/8143 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro opened a new pull request #8165: [bugfix] fix timegrain addon regression
villebro opened a new pull request #8165: [bugfix] fix timegrain addon regression URL: https://github.com/apache/incubator-superset/pull/8165 ### CATEGORY - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [x] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Custom timegrains defined in `superset_config.py` stopped working between 0.32 and 0.34. This fixes the regression and renames some functions and variables to more clearly indicate what is public and private. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TEST PLAN Local testing + CI ### ADDITIONAL INFORMATION - [ ] Has associated issue: #8162 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @lilila @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang opened a new pull request #8164: [WIP] More detailed async error messages for sqllab
serenajiang opened a new pull request #8164: [WIP] More detailed async error messages for sqllab URL: https://github.com/apache/incubator-superset/pull/8164 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Add source of error (presto, hive, etc.) into error messages for sqllab. This will hopefully confuse users a little less. ### REVIEWERS @etr2460 @graceguo-supercat This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8143: [Codemod] Rename react unsafe lifecycles
codecov-io edited a comment on issue #8143: [Codemod] Rename react unsafe lifecycles URL: https://github.com/apache/incubator-superset/pull/8143#issuecomment-526351465 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8143?src=pr=h1) Report > Merging [#8143](https://codecov.io/gh/apache/incubator-superset/pull/8143?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ee24539bd2dc0c66a204015ebcb957a924a55452?src=pr=desc) will **increase** coverage by `0.13%`. > The diff coverage is `58.06%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8143?src=pr=tree) ```diff @@Coverage Diff@@ ## master #8143 +/- ## = + Coverage 66.06% 66.2% +0.13% = Files 479 479 Lines 22930 22930 Branches 25242524 = + Hits15148 15180 +32 + Misses 76487616 -32 Partials 134 134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8143?src=pr=tree) | Coverage Δ | | |---|---|---| | [...erset/assets/src/visualizations/deckgl/factory.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvZmFjdG9yeS5qc3g=) | `0% <0%> (ø)` | :arrow_up: | | [superset/assets/src/components/AnchorLink.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0FuY2hvckxpbmsuanN4) | `83.33% <0%> (ø)` | :arrow_up: | | [...t/assets/src/visualizations/deckgl/Multi/Multi.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvTXVsdGkvTXVsdGkuanN4) | `0% <0%> (ø)` | :arrow_up: | | [...s/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9UYWJzLmpzeA==) | `61.11% <0%> (ø)` | :arrow_up: | | [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9NYXJrZG93bi5qc3g=) | `91.3% <0%> (ø)` | :arrow_up: | | [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQWRob2NGaWx0ZXJDb250cm9sLmpzeA==) | `65.43% <0%> (ø)` | :arrow_up: | | [...uperset/assets/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXIuanN4) | `42.2% <0%> (ø)` | :arrow_up: | | [...sualizations/deckgl/CategoricalDeckGLContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvQ2F0ZWdvcmljYWxEZWNrR0xDb250YWluZXIuanN4) | `0% <0%> (ø)` | :arrow_up: | | [superset/assets/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9jaGFydEFjdGlvbi5qcw==) | `49.63% <0%> (ø)` | :arrow_up: | | [superset/assets/src/CRUD/CollectionTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9DUlVEL0NvbGxlY3Rpb25UYWJsZS5qc3g=) | `62.88% <0%> (ø)` | :arrow_up: | | ... and [23 more](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8143?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8143?src=pr=footer). Last update [ee24539...9cbf841](https://codecov.io/gh/apache/incubator-superset/pull/8143?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at:
[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common
serenajiang commented on a change in pull request #8138: [typing] add typing
for superset/connectors and superset/common
URL:
https://github.com/apache/incubator-superset/pull/8138#discussion_r320423101
##
File path: superset/connectors/druid/models.py
##
@@ -146,53 +151,53 @@ def __html__(self):
return self.__repr__()
@property
-def data(self):
+def data(self) -> Dict:
return {"id": self.id, "name": self.cluster_name, "backend": "druid"}
@staticmethod
-def get_base_url(host, port):
+def get_base_url(host, port) -> str:
if not re.match("http(s)?://", host):
host = "http://; + host
url = "{0}:{1}".format(host, port) if port else host
return url
-def get_base_broker_url(self):
+def get_base_broker_url(self) -> str:
base_url = self.get_base_url(self.broker_host, self.broker_port)
return f"{base_url}/{self.broker_endpoint}"
-def get_pydruid_client(self):
+def get_pydruid_client(self) -> PyDruid:
cli = PyDruid(
self.get_base_url(self.broker_host, self.broker_port),
self.broker_endpoint
)
if self.broker_user and self.broker_pass:
cli.set_basic_auth_credentials(self.broker_user, self.broker_pass)
return cli
-def get_datasources(self):
+def get_datasources(self) -> List[Dict]:
endpoint = self.get_base_broker_url() + "/datasources"
auth = requests.auth.HTTPBasicAuth(self.broker_user, self.broker_pass)
return json.loads(requests.get(endpoint, auth=auth).text)
-def get_druid_version(self):
+def get_druid_version(self) -> str:
endpoint = self.get_base_url(self.broker_host, self.broker_port) +
"/status"
auth = requests.auth.HTTPBasicAuth(self.broker_user, self.broker_pass)
return json.loads(requests.get(endpoint, auth=auth).text)["version"]
-@property
+@property # noqa
Review comment:
I get this error: [Decorated property not
supported](https://github.com/python/mypy/issues/1362).
The typechecker has a problem with decorated properties for some reason, and
the typechecker only gets run on the file if there is at least one type hint
used or something from `typing` is imported. So, what changed is that there is
now typing in this file.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common
serenajiang commented on a change in pull request #8138: [typing] add typing
for superset/connectors and superset/common
URL:
https://github.com/apache/incubator-superset/pull/8138#discussion_r320393779
##
File path: superset/connectors/druid/models.py
##
@@ -146,53 +151,53 @@ def __html__(self):
return self.__repr__()
@property
-def data(self):
+def data(self) -> Dict:
return {"id": self.id, "name": self.cluster_name, "backend": "druid"}
@staticmethod
-def get_base_url(host, port):
+def get_base_url(host, port) -> str:
if not re.match("http(s)?://", host):
host = "http://; + host
url = "{0}:{1}".format(host, port) if port else host
return url
-def get_base_broker_url(self):
+def get_base_broker_url(self) -> str:
base_url = self.get_base_url(self.broker_host, self.broker_port)
return f"{base_url}/{self.broker_endpoint}"
-def get_pydruid_client(self):
+def get_pydruid_client(self) -> PyDruid:
cli = PyDruid(
self.get_base_url(self.broker_host, self.broker_port),
self.broker_endpoint
)
if self.broker_user and self.broker_pass:
cli.set_basic_auth_credentials(self.broker_user, self.broker_pass)
return cli
-def get_datasources(self):
+def get_datasources(self) -> List[Dict]:
endpoint = self.get_base_broker_url() + "/datasources"
auth = requests.auth.HTTPBasicAuth(self.broker_user, self.broker_pass)
return json.loads(requests.get(endpoint, auth=auth).text)
-def get_druid_version(self):
+def get_druid_version(self) -> str:
endpoint = self.get_base_url(self.broker_host, self.broker_port) +
"/status"
auth = requests.auth.HTTPBasicAuth(self.broker_user, self.broker_pass)
return json.loads(requests.get(endpoint, auth=auth).text)["version"]
-@property
+@property # noqa
Review comment:
My bad - I was using `mypy` instead of `flake8` to find typing errors,
thinking they did the same thing. `mypy` seems to be a bit stricter, and it
thought this line was an error even though it passed `flake8`, so I removed the
unnecessary `# noqa`s that I had put in.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items
codecov-io commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items URL: https://github.com/apache/incubator-superset/pull/8117#issuecomment-527578626 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8117?src=pr=h1) Report > Merging [#8117](https://codecov.io/gh/apache/incubator-superset/pull/8117?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ee24539bd2dc0c66a204015ebcb957a924a55452?src=pr=desc) will **increase** coverage by `7.68%`. > The diff coverage is `33.33%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8117?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8117 +/- ## == + Coverage 66.06% 73.75% +7.68% == Files 479 115 -364 Lines 2293012054 -10876 Branches 25240-2524 == - Hits15148 8890-6258 + Misses 7648 3164-4484 + Partials 1340 -134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8117?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/8117/diff?src=pr=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | `75% <0%> (-0.79%)` | :arrow_down: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/8117/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `88.7% <100%> (+0.06%)` | :arrow_up: | | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8117/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | | | | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8117/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | | | | [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8117/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | | | | [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8117/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | | | | [...c/visualizations/deckgl/layers/Polygon/Polygon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8117/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbi5qc3g=) | | | | [superset/assets/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8117/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0VkaXRhYmxlVGl0bGUuanN4) | | | | [superset/assets/src/setup/setupPlugins.js](https://codecov.io/gh/apache/incubator-superset/pull/8117/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9zZXR1cC9zZXR1cFBsdWdpbnMuanM=) | | | | [...t/assets/src/components/InfoTooltipWithTrigger.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8117/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0luZm9Ub29sdGlwV2l0aFRyaWdnZXIuanN4) | | | | ... and [359 more](https://codecov.io/gh/apache/incubator-superset/pull/8117/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8117?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8117?src=pr=footer). Last update [ee24539...4273d1f](https://codecov.io/gh/apache/incubator-superset/pull/8117?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on issue #7929: Fix tooltips not visible for NVD3 charts on Firefox (#7822)
graceguo-supercat commented on issue #7929: Fix tooltips not visible for NVD3 charts on Firefox (#7822) URL: https://github.com/apache/incubator-superset/pull/7929#issuecomment-527571150 @schoel-bis This PR has to be reverted from Master branch. Please see details in #8147. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ericandrewmeadows commented on a change in pull request #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items
ericandrewmeadows commented on a change in pull request #8117: Fix to Werkzeug
ProxyFix; expose ProxyFix configuration items
URL:
https://github.com/apache/incubator-superset/pull/8117#discussion_r320401487
##
File path: Untitled.ipynb
##
@@ -0,0 +1,66 @@
+{
Review comment:
100% was not intended to be in there.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] janantos commented on issue #7991: can't add clickhouse database (allways connecting as default user)
janantos commented on issue #7991: can't add clickhouse database (allways connecting as default user) URL: https://github.com/apache/incubator-superset/issues/7991#issuecomment-527568099 Both of this has been tested using 0.29b7 from PIP and 0.34 from GitHub This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] janantos commented on issue #7991: can't add clickhouse database (allways connecting as default user)
janantos commented on issue #7991: can't add clickhouse database (allways connecting as default user) URL: https://github.com/apache/incubator-superset/issues/7991#issuecomment-527567387 yes I have been successful, as mentioned earlier. I have found solution. You need to downgrade infi.clickhouse_orm to version 1.0.4 and then it will work. Also you will be receiving errors about decimal data types, his can be solved with installing sqlalchemy-clickhouse from GitHub and not from PIP. You can install it using pip command. Also in superset 0.34 the SQL Lab save as table functionality will not work, as Clickhouse does not use standard SQL. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items
mistercrunch commented on a change in pull request #8117: Fix to Werkzeug
ProxyFix; expose ProxyFix configuration items
URL:
https://github.com/apache/incubator-superset/pull/8117#discussion_r320398355
##
File path: Untitled.ipynb
##
@@ -0,0 +1,66 @@
+{
Review comment:
? I think this file was not intended to be added here
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common
serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r320398039 ## File path: superset/connectors/base/models.py ## @@ -60,8 +60,8 @@ class BaseDatasource(AuditMixinNullable, ImportMixin): perm = Column(String(1000)) sql = None -owners = None Review comment: I don't think `owners` and `update_from_object_fields` are ever referenced before they are assigned, so the default value isn't really necessary. But tbh, I just removed the default value so I could add a non optional type, so I'm fine with putting it back in. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common
serenajiang commented on a change in pull request #8138: [typing] add typing
for superset/connectors and superset/common
URL:
https://github.com/apache/incubator-superset/pull/8138#discussion_r320393779
##
File path: superset/connectors/druid/models.py
##
@@ -146,53 +151,53 @@ def __html__(self):
return self.__repr__()
@property
-def data(self):
+def data(self) -> Dict:
return {"id": self.id, "name": self.cluster_name, "backend": "druid"}
@staticmethod
-def get_base_url(host, port):
+def get_base_url(host, port) -> str:
if not re.match("http(s)?://", host):
host = "http://; + host
url = "{0}:{1}".format(host, port) if port else host
return url
-def get_base_broker_url(self):
+def get_base_broker_url(self) -> str:
base_url = self.get_base_url(self.broker_host, self.broker_port)
return f"{base_url}/{self.broker_endpoint}"
-def get_pydruid_client(self):
+def get_pydruid_client(self) -> PyDruid:
cli = PyDruid(
self.get_base_url(self.broker_host, self.broker_port),
self.broker_endpoint
)
if self.broker_user and self.broker_pass:
cli.set_basic_auth_credentials(self.broker_user, self.broker_pass)
return cli
-def get_datasources(self):
+def get_datasources(self) -> List[Dict]:
endpoint = self.get_base_broker_url() + "/datasources"
auth = requests.auth.HTTPBasicAuth(self.broker_user, self.broker_pass)
return json.loads(requests.get(endpoint, auth=auth).text)
-def get_druid_version(self):
+def get_druid_version(self) -> str:
endpoint = self.get_base_url(self.broker_host, self.broker_port) +
"/status"
auth = requests.auth.HTTPBasicAuth(self.broker_user, self.broker_pass)
return json.loads(requests.get(endpoint, auth=auth).text)["version"]
-@property
+@property # noqa
Review comment:
My bad - I was using `mypy` instead of `flake8` to find typing errors,
thinking they did the same thing. `mypy` seems to be a bit stricter, and it
thought this line was an error even though it passed `flake8`, so I removed the
unnecessary `# noqa`s that I had put in.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] CoryChaplin opened a new issue #7822: Line chart tooltips broken on Firefox
CoryChaplin opened a new issue #7822: Line chart tooltips broken on Firefox
URL: https://github.com/apache/incubator-superset/issues/7822
A clear and concise description of what the bug is.
### Expected results
Hover point on the line, see a tooltip.
### Actual results
No visible tooltip on Firefox (but it works on Chrome).
Screenshots
https://user-images.githubusercontent.com/5139669/60676736-eca85200-9e7f-11e9-9062-43b4b9bded9c.png;>
How to reproduce the bug
1. Go to Explore view or a Dashboard with a line chart
2. Hover a point on the line
3. See no tooltip
### Environment
(please complete the following information):
- superset version: 0.33.0.rc1
- python version: 3.6
- node.js version: 12.5.0
- npm version: 6.1.0
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included
it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version
of superset.
- [x] I have checked the issue tracker for the same issue and I haven't
found one similar.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ericandrewmeadows commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items
ericandrewmeadows commented on issue #8117: Fix to Werkzeug ProxyFix; expose
ProxyFix configuration items
URL:
https://github.com/apache/incubator-superset/pull/8117#issuecomment-527557625
1) I first fixed my instance, then @dpgaspar pointed out the defaults from
Airflow so I followed that convention. For me, I use the following settings:
```
ENABLE_PROXY_FIX = True
PROXY_FIX_CONFIG = {
"x_for": 1,
"x_proto": 0,
"x_host": 1,
"x_port": 0,
"x_prefix": 0,
}
```
2) I'll add that to `UPDATING.md`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch edited a comment on issue #8158: chore: bump cypress from 3.1.5 to 3.4.1
mistercrunch edited a comment on issue #8158: chore: bump cypress from 3.1.5 to 3.4.1 URL: https://github.com/apache/incubator-superset/pull/8158#issuecomment-527556112 The cypress package is pretty heavy and it makes Docker images significantly bigger and longer to build. In cases where we don't want to run cypress tests from inside the docker, but do want to build, we'd have to import the large cypress package... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar opened a new pull request #8163: [SQLLab] Refactor sql json endpoint
dpgaspar opened a new pull request #8163: [SQLLab] Refactor sql json endpoint URL: https://github.com/apache/incubator-superset/pull/8163 ### CATEGORY - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [X] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TEST PLAN ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #7991: can't add clickhouse database (allways connecting as default user)
villebro commented on issue #7991: can't add clickhouse database (allways connecting as default user) URL: https://github.com/apache/incubator-superset/issues/7991#issuecomment-527556855 This got messier than expected, mostly due to poor standardization in the python dbapi spec, hence my issues were mostly unrelated to clickhouse. Will be looking at those later. However, while I was able to get SqlLab working with clickhouse, I was unable to add tables using the stable version from `PyPI` or the bleeding edge version from github. Were you successful with that? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #8158: chore: bump cypress from 3.1.5 to 3.4.1
mistercrunch commented on issue #8158: chore: bump cypress from 3.1.5 to 3.4.1 URL: https://github.com/apache/incubator-superset/pull/8158#issuecomment-527556112 The cypress package is pretty heavy and it makes Docker images significantly bigger and longer to build. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8139: [sqllab] add retries for stop_query
serenajiang commented on a change in pull request #8139: [sqllab] add retries
for stop_query
URL:
https://github.com/apache/incubator-superset/pull/8139#discussion_r320387055
##
File path: superset/views/core.py
##
@@ -2430,14 +2432,30 @@ def results(self, key):
@has_access_api
@expose("/stop_query/", methods=["POST"])
@event_logger.log_this
+@backoff.on_exception(
+backoff.constant,
+DatabaseError,
Review comment:
Yes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8162: TIME_GRAIN_ADDON_FUNCTIONS not working in superset 0.34
villebro commented on issue #8162: TIME_GRAIN_ADDON_FUNCTIONS not working in superset 0.34 URL: https://github.com/apache/incubator-superset/issues/8162#issuecomment-527554818 Will look into this This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8038: Prevent 'main' database connection creation
villebro commented on issue #8038: Prevent 'main' database connection creation URL: https://github.com/apache/incubator-superset/pull/8038#issuecomment-527554492 Will review shortly This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8139: [sqllab] add retries for stop_query
serenajiang commented on a change in pull request #8139: [sqllab] add retries
for stop_query
URL:
https://github.com/apache/incubator-superset/pull/8139#discussion_r320385315
##
File path: superset/sql_lab.py
##
@@ -70,23 +70,31 @@ def handle_query_error(msg, query, session, payload=None):
return payload
-def get_query(query_id, session, retry_count=5):
-"""attemps to get the query and retry if it cannot"""
-query = None
-attempt = 0
-while not query and attempt < retry_count:
-try:
-query = session.query(Query).filter_by(id=query_id).one()
-except Exception:
-attempt += 1
-logging.error(f"Query with id `{query_id}` could not be retrieved")
-stats_logger.incr("error_attempting_orm_query_" + str(attempt))
-logging.error(f"Query {query_id}: Sleeping for a sec before
retrying...")
-sleep(1)
-if not query:
-stats_logger.incr("error_failed_at_getting_orm_query")
+def backoff_handler(details):
+query_id = details["kwargs"]["query_id"]
+logging.error(f"Query with id `{query_id}` could not be retrieved")
+stats_logger.incr("error_attempting_orm_query_{}".format(details["tries"]
- 1))
+logging.error(f"Query {query_id}: Sleeping for a sec before retrying...")
+
+
+def giveup_handler(details):
+stats_logger.incr("error_failed_at_getting_orm_query")
+
+
+@backoff.on_exception(
+backoff.constant,
+SqlLabException,
+interval=1,
+on_backoff=backoff_handler,
+on_giveup=giveup_handler,
+max_tries=5,
+)
+def get_query(query_id, session):
Review comment:
nope, all good.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common
etr2460 commented on a change in pull request #8138: [typing] add typing for
superset/connectors and superset/common
URL:
https://github.com/apache/incubator-superset/pull/8138#discussion_r320382172
##
File path: superset/connectors/druid/models.py
##
@@ -146,53 +151,53 @@ def __html__(self):
return self.__repr__()
@property
-def data(self):
+def data(self) -> Dict:
return {"id": self.id, "name": self.cluster_name, "backend": "druid"}
@staticmethod
-def get_base_url(host, port):
+def get_base_url(host, port) -> str:
if not re.match("http(s)?://", host):
host = "http://; + host
url = "{0}:{1}".format(host, port) if port else host
return url
-def get_base_broker_url(self):
+def get_base_broker_url(self) -> str:
base_url = self.get_base_url(self.broker_host, self.broker_port)
return f"{base_url}/{self.broker_endpoint}"
-def get_pydruid_client(self):
+def get_pydruid_client(self) -> PyDruid:
cli = PyDruid(
self.get_base_url(self.broker_host, self.broker_port),
self.broker_endpoint
)
if self.broker_user and self.broker_pass:
cli.set_basic_auth_credentials(self.broker_user, self.broker_pass)
return cli
-def get_datasources(self):
+def get_datasources(self) -> List[Dict]:
endpoint = self.get_base_broker_url() + "/datasources"
auth = requests.auth.HTTPBasicAuth(self.broker_user, self.broker_pass)
return json.loads(requests.get(endpoint, auth=auth).text)
-def get_druid_version(self):
+def get_druid_version(self) -> str:
endpoint = self.get_base_url(self.broker_host, self.broker_port) +
"/status"
auth = requests.auth.HTTPBasicAuth(self.broker_user, self.broker_pass)
return json.loads(requests.get(endpoint, auth=auth).text)["version"]
-@property
+@property # noqa
Review comment:
what changed here requiring the `noqa` comment?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common
etr2460 commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r320381394 ## File path: superset/connectors/base/models.py ## @@ -60,8 +60,8 @@ class BaseDatasource(AuditMixinNullable, ImportMixin): perm = Column(String(1000)) sql = None -owners = None Review comment: What's the implication of removing this default value? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8139: [sqllab] add retries for stop_query
etr2460 commented on a change in pull request #8139: [sqllab] add retries for
stop_query
URL:
https://github.com/apache/incubator-superset/pull/8139#discussion_r320374368
##
File path: superset/views/core.py
##
@@ -2430,14 +2432,30 @@ def results(self, key):
@has_access_api
@expose("/stop_query/", methods=["POST"])
@event_logger.log_this
+@backoff.on_exception(
+backoff.constant,
+DatabaseError,
Review comment:
This will now throw and return a 500 when there's an exception other than a
DatabaseError, correct? I think that is an improvement to the generic Exception
catching before, but wanted to make sure
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8139: [sqllab] add retries for stop_query
etr2460 commented on a change in pull request #8139: [sqllab] add retries for
stop_query
URL:
https://github.com/apache/incubator-superset/pull/8139#discussion_r320373575
##
File path: superset/sql_lab.py
##
@@ -70,23 +70,31 @@ def handle_query_error(msg, query, session, payload=None):
return payload
-def get_query(query_id, session, retry_count=5):
-"""attemps to get the query and retry if it cannot"""
-query = None
-attempt = 0
-while not query and attempt < retry_count:
-try:
-query = session.query(Query).filter_by(id=query_id).one()
-except Exception:
-attempt += 1
-logging.error(f"Query with id `{query_id}` could not be retrieved")
-stats_logger.incr("error_attempting_orm_query_" + str(attempt))
-logging.error(f"Query {query_id}: Sleeping for a sec before
retrying...")
-sleep(1)
-if not query:
-stats_logger.incr("error_failed_at_getting_orm_query")
+def backoff_handler(details):
Review comment:
naming nit: I'd call this `get_query_backoff_handler` since this is only for
that function specifically.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8139: [sqllab] add retries for stop_query
etr2460 commented on a change in pull request #8139: [sqllab] add retries for
stop_query
URL:
https://github.com/apache/incubator-superset/pull/8139#discussion_r320373241
##
File path: superset/sql_lab.py
##
@@ -70,23 +70,31 @@ def handle_query_error(msg, query, session, payload=None):
return payload
-def get_query(query_id, session, retry_count=5):
-"""attemps to get the query and retry if it cannot"""
-query = None
-attempt = 0
-while not query and attempt < retry_count:
-try:
-query = session.query(Query).filter_by(id=query_id).one()
-except Exception:
-attempt += 1
-logging.error(f"Query with id `{query_id}` could not be retrieved")
-stats_logger.incr("error_attempting_orm_query_" + str(attempt))
-logging.error(f"Query {query_id}: Sleeping for a sec before
retrying...")
-sleep(1)
-if not query:
-stats_logger.incr("error_failed_at_getting_orm_query")
+def backoff_handler(details):
+query_id = details["kwargs"]["query_id"]
+logging.error(f"Query with id `{query_id}` could not be retrieved")
+stats_logger.incr("error_attempting_orm_query_{}".format(details["tries"]
- 1))
+logging.error(f"Query {query_id}: Sleeping for a sec before retrying...")
+
+
+def giveup_handler(details):
+stats_logger.incr("error_failed_at_getting_orm_query")
+
+
+@backoff.on_exception(
+backoff.constant,
+SqlLabException,
+interval=1,
+on_backoff=backoff_handler,
+on_giveup=giveup_handler,
+max_tries=5,
+)
+def get_query(query_id, session):
Review comment:
I assume this wasn't called anywhere before with the `retry_count` argument?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8139: [sqllab] add retries for stop_query
etr2460 commented on a change in pull request #8139: [sqllab] add retries for
stop_query
URL:
https://github.com/apache/incubator-superset/pull/8139#discussion_r320373679
##
File path: superset/sql_lab.py
##
@@ -70,23 +70,31 @@ def handle_query_error(msg, query, session, payload=None):
return payload
-def get_query(query_id, session, retry_count=5):
-"""attemps to get the query and retry if it cannot"""
-query = None
-attempt = 0
-while not query and attempt < retry_count:
-try:
-query = session.query(Query).filter_by(id=query_id).one()
-except Exception:
-attempt += 1
-logging.error(f"Query with id `{query_id}` could not be retrieved")
-stats_logger.incr("error_attempting_orm_query_" + str(attempt))
-logging.error(f"Query {query_id}: Sleeping for a sec before
retrying...")
-sleep(1)
-if not query:
-stats_logger.incr("error_failed_at_getting_orm_query")
+def backoff_handler(details):
+query_id = details["kwargs"]["query_id"]
+logging.error(f"Query with id `{query_id}` could not be retrieved")
+stats_logger.incr("error_attempting_orm_query_{}".format(details["tries"]
- 1))
+logging.error(f"Query {query_id}: Sleeping for a sec before retrying...")
+
+
+def giveup_handler(details):
Review comment:
same nit here: `get_query_giveup_handler`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ericandrewmeadows commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items
ericandrewmeadows commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items URL: https://github.com/apache/incubator-superset/pull/8117#issuecomment-527543393 @dpgaspar - can this be merged? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] lilila opened a new issue #8162: TIME_GRAIN_ADDON_FUNCTIONS not working in superset 0.34
lilila opened a new issue #8162: TIME_GRAIN_ADDON_FUNCTIONS not working in
superset 0.34
URL: https://github.com/apache/incubator-superset/issues/8162
I changed from superset 0.rc32.2 to 0.34 and the time grains added in the
config file are not working anymore.
I have set up :
```
TIME_GRAIN_ADDONS = {"1969-12-31T00:00:00Z/P1W": 'week_start_wednesday'}
TIME_GRAIN_ADDON_FUNCTIONS = {
'mysql':
{"1969-12-31T00:00:00Z/P1W":
'DATE(DATE_SUB({col}, ''INTERVAL DAYOFWEEK(DATE_SUB({col},
INTERVAL 3 DAY)) - 1 DAY))'}
}
```
And when I select `week_start_wednesday` I get the following error :
> No grain spec for 1969-12-31T00:00:00Z/P1W for database mysql
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8162: TIME_GRAIN_ADDON_FUNCTIONS not working in superset 0.34
issue-label-bot[bot] commented on issue #8162: TIME_GRAIN_ADDON_FUNCTIONS not working in superset 0.34 URL: https://github.com/apache/incubator-superset/issues/8162#issuecomment-527541930 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.88. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] srikanth-reddy-m closed issue #8160: In HTTPS Change of data source not working on Table and Dashboards
srikanth-reddy-m closed issue #8160: In HTTPS Change of data source not working on Table and Dashboards URL: https://github.com/apache/incubator-superset/issues/8160 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] srikanth-reddy-m commented on issue #8160: In HTTPS Change of data source not working on Table and Dashboards
srikanth-reddy-m commented on issue #8160: In HTTPS Change of data source not working on Table and Dashboards URL: https://github.com/apache/incubator-superset/issues/8160#issuecomment-527539573 This issue is solved, I have missed roxy_set_header X-Forwarded-Proto 'https' header setting in nginx. If we are using nginx as a reverse proxy with https we have to add this header to flask-app builder to know schema information. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] closed issue #7794: How to auto refresh a chart without flashing?
stale[bot] closed issue #7794: How to auto refresh a chart without flashing? URL: https://github.com/apache/incubator-superset/issues/7794 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] uchihaabhijit commented on issue #8092: Write custom backend logic for visualizing superset graphs
uchihaabhijit commented on issue #8092: Write custom backend logic for visualizing superset graphs URL: https://github.com/apache/incubator-superset/issues/8092#issuecomment-527456076 @ayushbilala That is what I am currently struggling at. Where do I put the python code, the route and the view inside the superset directories ?? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8082: add GeoJSON encoding support to deck.gl Polygon chart
codecov-io commented on issue #8082: add GeoJSON encoding support to deck.gl Polygon chart URL: https://github.com/apache/incubator-superset/pull/8082#issuecomment-527445947 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8082?src=pr=h1) Report > Merging [#8082](https://codecov.io/gh/apache/incubator-superset/pull/8082?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0d76fc755cd4cdcccf8238311ab00678d38230af?src=pr=desc) will **increase** coverage by `0.3%`. > The diff coverage is `64.3%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8082?src=pr=tree) ```diff @@Coverage Diff@@ ## master#8082 +/- ## = + Coverage 65.83% 66.14% +0.3% = Files 486 479 -7 Lines 2292122950 +29 Branches 2521 2530 +9 = + Hits1509015180 +90 + Misses 7700 7636 -64 - Partials 131 134 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8082?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8082/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `42.85% <ø> (ø)` | :arrow_up: | | [...et/assets/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/incubator-superset/pull/8082/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9wcmVzZXRzL01haW5QcmVzZXQuanM=) | `0% <ø> (ø)` | :arrow_up: | | [superset/assets/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/8082/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9zZXR1cC9zZXR1cEZvcm1hdHRlcnMuanM=) | `0% <ø> (ø)` | :arrow_up: | | [superset/assets/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8082/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9DaGFydC5qc3g=) | `11.11% <ø> (ø)` | :arrow_up: | | [...ets/src/visualizations/FilterBox/transformProps.js](https://codecov.io/gh/apache/incubator-superset/pull/8082/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9GaWx0ZXJCb3gvdHJhbnNmb3JtUHJvcHMuanM=) | `0% <0%> (ø)` | :arrow_up: | | [...ets/src/visualizations/TimeTable/transformProps.js](https://codecov.io/gh/apache/incubator-superset/pull/8082/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9UaW1lVGFibGUvdHJhbnNmb3JtUHJvcHMuanM=) | `0% <0%> (ø)` | :arrow_up: | | [...sets/src/SqlLab/components/ScheduleQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8082/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TY2hlZHVsZVF1ZXJ5QnV0dG9uLmpzeA==) | `8.62% <0%> (-0.16%)` | :arrow_down: | | [...assets/src/visualizations/deckgl/transformProps.js](https://codecov.io/gh/apache/incubator-superset/pull/8082/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvdHJhbnNmb3JtUHJvcHMuanM=) | `0% <0%> (ø)` | :arrow_up: | | [superset/assets/src/components/ErrorBoundary.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8082/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0Vycm9yQm91bmRhcnkuanN4) | `18.18% <0%> (ø)` | :arrow_up: | | [superset/assets/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8082/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9DaGFydFJlbmRlcmVyLmpzeA==) | `7.35% <0%> (-0.72%)` | :arrow_down: | | ... and [21 more](https://codecov.io/gh/apache/incubator-superset/pull/8082/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8082?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8082?src=pr=footer). Last update [0d76fc7...7d25965](https://codecov.io/gh/apache/incubator-superset/pull/8082?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-superset] squalou commented on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard
squalou commented on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard URL: https://github.com/apache/incubator-superset/issues/8121#issuecomment-527430690 Closing this, as anyway it's no more related to the initial issue. Fix works great. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] squalou closed issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard
squalou closed issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard URL: https://github.com/apache/incubator-superset/issues/8121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] noelalonso commented on issue #5984: +1 to addition of Elasticsearch support.
noelalonso commented on issue #5984: +1 to addition of Elasticsearch support. URL: https://github.com/apache/incubator-superset/issues/5984#issuecomment-527414347 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] lshunran commented on issue #8161: navbar_menu.html is not found
lshunran commented on issue #8161: navbar_menu.html is not found URL: https://github.com/apache/incubator-superset/issues/8161#issuecomment-527394049 I have saw the issue#7901.But I still cannot see the menu. And where could I find the Flask-Appbuilder Package? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] lshunran opened a new issue #8161: navbar_menu.html is not found
lshunran opened a new issue #8161: navbar_menu.html is not found URL: https://github.com/apache/incubator-superset/issues/8161 Hi,I am a newer to superset.I have a problem today.when I finish instruction in 《Setup Local Environment for Development》in CONTRIBUTING.md. I successfully started my front-end server and back-end server. I also init a admin account. But when I login into homepage.I cannot see menus in navbar and I cannot do anything for next step.Then I found there is no navbar_menus.html In folder superset/templates/appbuilder/navbar_menu.html.Is this the cause?   This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] lshunran closed issue #8161: navbar_menu.html is not found
lshunran closed issue #8161: navbar_menu.html is not found URL: https://github.com/apache/incubator-superset/issues/8161 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8161: navbar_menu.html is not found
issue-label-bot[bot] commented on issue #8161: navbar_menu.html is not found URL: https://github.com/apache/incubator-superset/issues/8161#issuecomment-527385832 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.67. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] lshunran opened a new issue #8161: navbar_menu.html is not found
lshunran opened a new issue #8161: navbar_menu.html is not found URL: https://github.com/apache/incubator-superset/issues/8161 Hi,I am a newer to superset.I have a problem today.when I finish instruction in 《Setup Local Environment for Development》in CONTRIBUTING.md. I successfully started my front-end server and back-end server. I also init a admin account. But when I login into homepage.I cannot see menus in navbar and I cannot do anything for next step.Then I found there is no navbar_menus.html In folder superset/templates/appbuilder/navbar_menu.html.Is this the cause?   This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] breizh24 commented on issue #5420: Superset how to support custom add Color Scheme?
breizh24 commented on issue #5420: Superset how to support custom add Color
Scheme?
URL:
https://github.com/apache/incubator-superset/issues/5420#issuecomment-527380844
@ilyakam To add custom schemes, in case of a "Categorical Scheme" you need
to import the CategoricalScheme class from the module "@superset-ui/color",
here is an example:
```javascript
import { CategoricalScheme } from '@superset-ui/color';
const schemes = [
{
id: 'testColors',
label: 'Test Colors',
colors: ['#2d51a3', '#7d7f82', '#2061e0', '00'],
},
].map(s => new CategoricalScheme(s));
export default schemes;
```
then you need to import this into /superset/assets/src/setup/setupColors.js
and add it to the already existing schemes, you should end up with something
like this:
```javascript
import testColors from '../myColors/myColorSchemes';
export default function setupColors() {
// Register color schemes
const categoricalSchemeRegistry = getCategoricalSchemeRegistry();
[airbnb, categoricalD3, google, lyft, testColors].forEach((group) => {
group.forEach((scheme) => {
categoricalSchemeRegistry.registerValue(scheme.id, scheme);
});
});
categoricalSchemeRegistry.setDefaultKey('bnbColors');
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] pkesso closed issue #8154: FORMAT TabSeparatedWithNamesAndTypes is unknown when db upgrading on clickhouse
pkesso closed issue #8154: FORMAT TabSeparatedWithNamesAndTypes is unknown when db upgrading on clickhouse URL: https://github.com/apache/incubator-superset/issues/8154 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] pkesso commented on issue #8154: FORMAT TabSeparatedWithNamesAndTypes is unknown when db upgrading on clickhouse
pkesso commented on issue #8154: FORMAT TabSeparatedWithNamesAndTypes is unknown when db upgrading on clickhouse URL: https://github.com/apache/incubator-superset/issues/8154#issuecomment-527374961 Oh... my bad. I figured out, it works fine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8160: In HTTPS Change of data source not working on Table and Dashboards
issue-label-bot[bot] commented on issue #8160: In HTTPS Change of data source not working on Table and Dashboards URL: https://github.com/apache/incubator-superset/issues/8160#issuecomment-527370954 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.94. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] srikanth-reddy-m opened a new issue #8160: In HTTPS Change of data source not working on Table and Dashboards
srikanth-reddy-m opened a new issue #8160: In HTTPS Change of data source not
working on Table and Dashboards
URL: https://github.com/apache/incubator-superset/issues/8160
A clear and concise description of what the bug is.
CodeBase: Master Branch
When trying to change superset data source from HTTPS it is trying to open
Url in HTTP in which it is creating the error.
Error: Unsafe attempt to load URL, Domains, protocols, and ports must match
### Expected results
It should load URL's with only HTTps
what you expected to happen.
### Actual results
what actually happens.
Screenshots
If applicable, add screenshots to help explain your problem.
How to reproduce the bug
1. Go to Superset sources and select Tables.
2. Click on any source this will open that source
3. Now click on Data Source drop-down and select change data source and
select any data source.
4. This will show error
### Environment
(please complete the following information):
- superset version: `superset version`
- python version: `python --version`
- node.js version: `node -v`
- npm version: `npm -v`
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included
it here as text if there are any.
- [ ] I have reproduced the issue with at least the latest released version
of superset.
- [ ] I have checked the issue tracker for the same issue and I haven't
found one similar.
### Additional context
Add any other context about the problem here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] squalou opened a new issue #8159: standalone cause blank screen (within 'explore' endpoint)
squalou opened a new issue #8159: standalone cause blank screen (within
'explore' endpoint)
URL: https://github.com/apache/incubator-superset/issues/8159
When using an "explore" url with =true, the display is blank on
master (used to work on 0.28 and 0.34)
see additional context for a manual investigation/css trick workaround.
### Expected results
display the chart without menu on top. Ideal for iframe embedding for
instance.
### Actual results
Superset 'infinite icon' animation is shown, then stops when query ends,
then the display is completely blank
Screenshots
completely white area, no need of a screenshot I guess :)
How to reproduce the bug
1. Go to '...'
2. Click on ''
3. Scroll down to ''
4. See error
### Environment
- superset version: master build on 2019-08-27
- python version: 3.6
- node.js version: 3.12
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [x ] I have checked the superset logs for python stacktraces and included
it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version
of superset.
- [x ] I have checked the issue tracker for the same issue and I haven't
found one similar.
### Additional context
In my browser , if I open the web console then type `$("#app div
div").css({height:"100px"})` after the superset icon animation has ended, this
causes the chart to reveal itself as expected.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8159: standalone cause blank screen (within 'explore' endpoint)
issue-label-bot[bot] commented on issue #8159: standalone cause blank screen (within 'explore' endpoint) URL: https://github.com/apache/incubator-superset/issues/8159#issuecomment-527367002 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.97. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the backend
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#issuecomment-527324021 @graceguo-supercat that's expected if you don't have a results backend set up. In that case, we don't store the results anywhere, and users need to re-run the query every time to get the results. If the results backend are configured, though, the results are loaded from it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
