[GitHub] [incubator-superset] ranugoldan commented on issue #9125: Time Grain for BigQuery type: DATE & DATETIME is not available
ranugoldan commented on issue #9125: Time Grain for BigQuery type: DATE & DATETIME is not available URL: https://github.com/apache/incubator-superset/issues/9125#issuecomment-585591867 @villebro noted, will try it today. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on issue #9123: [SIP-37] Proposal to implement CSS-in-JS using Emotion
rusackas commented on issue #9123: [SIP-37] Proposal to implement CSS-in-JS using Emotion URL: https://github.com/apache/incubator-superset/issues/9123#issuecomment-585584944 @etr2460 For the `css` prop (using object styles), Emotion uses the [`csstype`](https://www.npmjs.com/package/csstype) package under the hood to check for valid CSS properties and values. There's a pragma to add at the top of the file for this to work (unless using babel plugin, apparently). For the `` styled(someElement)`...` `` syntax, it lets you type props, and checks their validity. The docs/examples on the matter [here](https://emotion.sh/docs/typescript) explain it more eloquently than I can :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on issue #9109: [migration] metadata for dashboard filters
graceguo-supercat commented on issue #9109: [migration] metadata for dashboard filters URL: https://github.com/apache/incubator-superset/pull/9109#issuecomment-585541741 ping @john-bodley This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on issue #9123: [SIP-37] Proposal to implement CSS-in-JS using Emotion
etr2460 commented on issue #9123: [SIP-37] Proposal to implement CSS-in-JS using Emotion URL: https://github.com/apache/incubator-superset/issues/9123#issuecomment-585502983 What sort of TypeScript guarantees do we get with Emotion? When adding the css tag to a component to we get safety of only being able to set valid CSS properties and valid values for these properties? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript
etr2460 commented on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript URL: https://github.com/apache/incubator-superset/issues/9101#issuecomment-585502092 FWIW, Facebook has stopped pushing flow but has started adapting TypeScript in some projects (Jest for example). Using elm or reason in the chart plugins seems like a good idea, if someone wanted to implement their new plugin in a non JS/TS language This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on issue #9119: Update PyArrow to 0.16.0
robdiciuccio commented on issue #9119: Update PyArrow to 0.16.0 URL: https://github.com/apache/incubator-superset/pull/9119#issuecomment-585491641 Seeing a potential issue with this new version raising `OSError: Invalid flatbuffers message.`. Investigating. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] eugeniamz opened a new issue #9130: Box plot does not filter in dashboard
eugeniamz opened a new issue #9130: Box plot does not filter in dashboard
URL: https://github.com/apache/incubator-superset/issues/9130
When applying filters in the dashboard the box plot does not filter, not
even when force refresh.
However, the filter does apply when select Edit Dashboard.
### Expected results
When applying filters in the filter box, box plot should also filter.
### Actual results
When applying filters all the charts get filter, except the box plot; but if
you click Edit Dashboard the box plot gets updated.
Screenshots
If applicable, add screenshots to help explain your problem.
How to reproduce the bug
1. Go to "World Bank's Data" dashboard
2. Select a region in Filter
3. See Box Plot does not get updated
4. Force Refresh in Box Plot
5. See Box Plot does not get updated
6. Edit Dashboard
7. Box Plot get updated
### Environment
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included
it here as text if there are any.
- [X] I have reproduced the issue with at least the latest released version
of superset.
- [X] I have checked the issue tracker for the same issue and I haven't
found one similar.
### Additional context
I am using Superset version installed in Preset Alpha.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #9120: Add feature flags to control query sharing, KV exposure
willbarrett commented on issue #9120: Add feature flags to control query sharing, KV exposure URL: https://github.com/apache/incubator-superset/pull/9120#issuecomment-585464421 @etr2460 I'll expand directly with you in Slack. I don't wish to have a detailed security-related conversation publicly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on issue #9120: Add feature flags to control query sharing, KV exposure
etr2460 commented on issue #9120: Add feature flags to control query sharing, KV exposure URL: https://github.com/apache/incubator-superset/pull/9120#issuecomment-585462901 Could you expand a bit on the insecure nature of the `/kv` endpoints? It was my understanding that they'd let you view a query/chart form data, but actually running the query would still be dependent on the security manager granting you access to the base level datasources. They seem not unlike the google doc link sharing feature, and if the predictable nature of the urls is an issue then simply using a random key would resolve that issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #9120: Add feature flags to control query sharing, KV exposure
willbarrett commented on issue #9120: Add feature flags to control query sharing, KV exposure URL: https://github.com/apache/incubator-superset/pull/9120#issuecomment-585461820 @etr2460 the unsecured/unvalidated/unowned `/kv/` endpoints are unacceptable from a security standpoint to Preset. We've provided feature flags so that other organizations can continue using the system as-is. The Cartel designs have a different model entirely for sharing, so we view this fix as a stop-gap in advance of that work. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on issue #9120: Add feature flags to control query sharing, KV exposure
etr2460 commented on issue #9120: Add feature flags to control query sharing, KV exposure URL: https://github.com/apache/incubator-superset/pull/9120#issuecomment-585460932 This seems like a pretty major product/functionality change as far as completely removing the concept of one-off query sharing (i'm pretty sure the kv endpoints are also used for one-off chart sharing too). What tradeoffs were considered when thinking about this feature removal? I personally make use of the query and chart sharing features all the time. cc @sylvia-tomiyama for her take too This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #9034: [table] feat: REST API
villebro commented on a change in pull request #9034: [table] feat: REST API
URL:
https://github.com/apache/incubator-superset/pull/9034#discussion_r378530428
##
File path: tests/dataset_api_tests.py
##
@@ -0,0 +1,612 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Unit tests for Superset"""
+import json
+from typing import List
+
+import prison
+
+from superset import db, security_manager
+from superset.connectors.sqla.models import SqlaTable, TableColumn
+from superset.models.core import Database
+from superset.utils.core import get_example_database
+
+from .base_tests import SupersetTestCase
+
+
+class DatasetApiTests(SupersetTestCase):
+
+example_create_column_data = {
+"column_name": "col_exp",
+"verbose_name": "col verbose name",
+"description": "col description",
+"type": "VARCHAR",
+"groupby": False,
+"filterable": True,
+"expression": "col expression",
Review comment:
nit: perhaps put some ANSI SQL here: `case when 1 = 1 then 'abc' else
'qwerty' end`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #9034: [table] feat: REST API
villebro commented on a change in pull request #9034: [table] feat: REST API
URL:
https://github.com/apache/incubator-superset/pull/9034#discussion_r378529035
##
File path: superset/connectors/sqla/api.py
##
@@ -0,0 +1,812 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import logging
+from typing import Dict, List
+
+from flask import g, request, Response
+from flask_appbuilder import permission_name
+from flask_appbuilder.api import (
+BaseApi,
+expose,
+get_info_schema,
+get_item_schema,
+get_list_schema,
+merge_response_func,
+protect,
+rison,
+safe,
+)
+from flask_appbuilder.api.schemas import API_FILTERS_RIS_KEY,
API_PERMISSIONS_RIS_KEY
+from flask_appbuilder.models.sqla.interface import SQLAInterface
+from marshmallow import fields, post_load, ValidationError
+from marshmallow.validate import Length
+
+from superset.connectors.sqla.decorators import (
+check_dataset_exists,
+check_ownership_dataset_exists,
+)
+from superset.connectors.sqla.models import SqlaTable, SqlMetric, TableColumn
+from superset.connectors.sqla.validators import (
+validate_database,
+validate_python_date_format,
+validate_table_column_name,
+validate_table_exists,
+validate_table_metric_name,
+validate_table_uniqueness,
+)
+from superset.constants import RouteMethod
+from superset.views.base import DatasourceFilter
+from superset.views.base_api import BaseOwnedModelRestApi,
BaseSupersetModelRestApi
+from superset.views.base_schemas import BaseOwnedSchema, validate_owner
+
+logger = logging.getLogger(__name__)
+
+
+class DatasetPostSchema(BaseOwnedSchema):
+__class_model__ = SqlaTable
+
+database = fields.Integer(required=True, validate=validate_database)
+schema = fields.String()
+table_name = fields.String(required=True, allow_none=False,
validate=Length(1, 250))
+owners = fields.List(fields.Integer(validate=validate_owner))
+
+@post_load
+def make_object(self, data: Dict, discard: List[str] = None) -> SqlaTable:
+instance = super().make_object(data, discard=["database"])
+instance.database = g.tmp_database
+return instance
+
+
+class DatasetPutSchema(BaseOwnedSchema):
+__class_model__ = SqlaTable
+
+table_name = fields.String(allow_none=True, validate=Length(1, 250))
+sql = fields.String(allow_none=True)
+filter_select_enabled = fields.Boolean(allow_none=True)
+fetch_values_predicate = fields.String(allow_none=True, validate=Length(0,
1000))
+schema = fields.String(allow_none=True, validate=Length(1, 255))
+description = fields.String(allow_none=True)
+main_dttm_col = fields.String(allow_none=True)
+offset = fields.Integer(allow_none=True)
+default_endpoint = fields.String(allow_none=True)
+cache_timeout = fields.Integer(allow_none=True)
+is_sqllab_view = fields.Boolean(allow_none=True)
+template_params = fields.String(allow_none=True)
+owners = fields.List(fields.Integer(validate=validate_owner))
+
+
+class DatasetRestApi(BaseOwnedModelRestApi):
+datamodel = SQLAInterface(SqlaTable)
+base_filters = [["id", DatasourceFilter, lambda: []]]
+
+resource_name = "dataset"
+allow_browser_login = True
+
+class_permission_name = "TableModelView"
+include_route_methods = RouteMethod.REST_MODEL_VIEW_CRUD_SET |
{RouteMethod.RELATED}
+
+list_columns = [
+"database_name",
+"changed_by.username",
+"changed_on",
+"table_name",
+"schema",
+]
+show_columns = [
+"database.database_name",
+"database.id",
+"table_name",
+"sql",
+"filter_select_enabled",
+"fetch_values_predicate",
+"schema",
+"description",
+"main_dttm_col",
+"offset",
+"default_endpoint",
+"cache_timeout",
+"is_sqllab_view",
+"template_params",
+"owners.id",
+"owners.username",
+]
+add_model_schema = DatasetPostSchema()
+edit_model_schema = DatasetPutSchema()
+add_columns = ["database", "schema", "table_name", "owners"]
+edit_columns = [
+"table_name",
+"sql",
+"filter_select_enabled",
+
[GitHub] [incubator-superset] villebro commented on a change in pull request #9034: [table] feat: REST API
villebro commented on a change in pull request #9034: [table] feat: REST API URL: https://github.com/apache/incubator-superset/pull/9034#discussion_r378518210 ## File path: requirements.txt ## @@ -21,7 +21,7 @@ croniter==0.3.31 cryptography==2.8 decorator==4.4.1 # via retry defusedxml==0.6.0 # via python3-openid -flask-appbuilder==2.2.2 +flask-appbuilder==2.2.3rc5 Review comment: I think this needs a rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #9034: [table] feat: REST API
villebro commented on a change in pull request #9034: [table] feat: REST API
URL:
https://github.com/apache/incubator-superset/pull/9034#discussion_r378532733
##
File path: tests/dataset_api_tests.py
##
@@ -0,0 +1,612 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Unit tests for Superset"""
+import json
+from typing import List
+
+import prison
+
+from superset import db, security_manager
+from superset.connectors.sqla.models import SqlaTable, TableColumn
+from superset.models.core import Database
+from superset.utils.core import get_example_database
+
+from .base_tests import SupersetTestCase
+
+
+class DatasetApiTests(SupersetTestCase):
+
+example_create_column_data = {
+"column_name": "col_exp",
+"verbose_name": "col verbose name",
+"description": "col description",
+"type": "VARCHAR",
+"groupby": False,
+"filterable": True,
+"expression": "col expression",
+"is_dttm": False,
+"python_date_format": "epoch_s",
+}
+
+@staticmethod
+def insert_dataset(
+table_name: str, schema: str, owners: List[int], database: Database
+) -> SqlaTable:
+obj_owners = list()
+for owner in owners:
+user = db.session.query(security_manager.user_model).get(owner)
+obj_owners.append(user)
+table = SqlaTable(
+table_name=table_name, schema=schema, owners=obj_owners,
database=database
+)
+db.session.add(table)
+db.session.commit()
+return table
+
+@staticmethod
+def insert_dataset_column(
+table_id: int,
+column_name: str,
+verbose_name: str = "",
+description: str = "",
+type: str = "",
+groupby: bool = True,
+filterable: bool = True,
+is_dttm: bool = True,
+expression: str = "",
+python_date_format: str = "",
Review comment:
Is there some reason the `str`s aren't `Optional[str] = None`? In the
datamodel these seem to be nullable.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] Maria28281 commented on issue #6685: Druid Column Type does not get updated
Maria28281 commented on issue #6685: Druid Column Type does not get updated URL: https://github.com/apache/incubator-superset/issues/6685#issuecomment-585437755 > If I remember correctly, the column type gets updated one week after it has been changed, as superset requests metadata for the last week of available druid data for every topic. So you either need to wait one week or re-add the datasource to superset. Could you tell me, where can i find the code in superset to change that time, because i think is a lot of time to wait and see the change if i need to change column types frecuently its imposible to wait. And thank you very much , your help was so helpfull. Best regards This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] PRamia commented on issue #7466: Dockerfile does not install browser and web driver, preventing emailer from working
PRamia commented on issue #7466: Dockerfile does not install browser and web driver, preventing emailer from working URL: https://github.com/apache/incubator-superset/issues/7466#issuecomment-585427276 > Wow that's pretty big. I made a Superset image for internal use that is `< 200mb` Hi, could you share that image with the community? i am looking for something like that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #9125: Time Grain for BigQuery type: DATE & DATETIME is not available
villebro commented on issue #9125: Time Grain for BigQuery type: DATE &
DATETIME is not available
URL:
https://github.com/apache/incubator-superset/issues/9125#issuecomment-585409090
@ranugoldan as a quick fix/check, would you mind adding the following to
your `superset_config.py` file and see if it solves your problem:
```python
TIME_GRAIN_ADDON_FUNCTIONS = {
'bigquery': {
"PT1S": "TIMESTAMP_TRUNC(CAST({col} AS TIMESTAMP), SECOND)",
"PT1M": "TIMESTAMP_TRUNC(CAST({col} AS TIMESTAMP), MINUTE)",
"PT1H": "TIMESTAMP_TRUNC(CAST({col} AS TIMESTAMP), HOUR)",
"P1D": "TIMESTAMP_TRUNC(CAST({col} AS TIMESTAMP), DAY)",
"P1W": "TIMESTAMP_TRUNC(CAST({col} AS TIMESTAMP), WEEK)",
"P1M": "TIMESTAMP_TRUNC(CAST({col} AS TIMESTAMP), MONTH)",
"P0.25Y": "TIMESTAMP_TRUNC(CAST({col} AS TIMESTAMP), QUARTER)",
"P1Y": "TIMESTAMP_TRUNC(CAST({col} AS TIMESTAMP), YEAR)",
}
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] saurabhdhupar commented on issue #9127: "Exception: No ldap library for python" when running Superset with Docker
saurabhdhupar commented on issue #9127: "Exception: No ldap library for python" when running Superset with Docker URL: https://github.com/apache/incubator-superset/issues/9127#issuecomment-585396979 If you login to docker container and try pip freeze you should be able to find if this dependency is missing. You can add a dependency to requirements-dev.txt and rebuild the docker image. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar opened a new pull request #9129: [datasets] new, API using command pattern
dpgaspar opened a new pull request #9129: [datasets] new, API using command pattern URL: https://github.com/apache/incubator-superset/pull/9129 ### CATEGORY Choose one - [ ] Bug Fix - [X] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TEST PLAN ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9122: [fix] Fix table viz column order
john-bodley commented on a change in pull request #9122: [fix] Fix table viz column order URL: https://github.com/apache/incubator-superset/pull/9122#discussion_r378482103 ## File path: superset/viz.py ## @@ -554,46 +555,50 @@ def query_obj(self): # Add all percent metrics that are not already in the list if "percent_metrics" in fd: -d["metrics"] = d["metrics"] + list( -filter(lambda m: m not in d["metrics"], fd["percent_metrics"] or []) +d["metrics"].extend( +m for m in fd["percent_metrics"] or [] if m not in d["metrics"] Review comment: @mistercrunch [`list.extend(iter)`](https://docs.python.org/3/tutorial/datastructures.html#more-on-lists) takes any iterable. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ayushbilala commented on issue #8808: superset db upgrade returns foreign key constraint is incorrectly formed
ayushbilala commented on issue #8808: superset db upgrade returns foreign key constraint is incorrectly formed URL: https://github.com/apache/incubator-superset/issues/8808#issuecomment-585388902 I am facing the same issue. Looks like different charsets of the two tables is the cause. 'query' table was created with **CHARSET=utf8**. On adding **DEFAULT CHARSET=utf8** with **CREATE TABLE tab_state**, it works fine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9109: [migration] metadata for dashboard filters
codecov-io edited a comment on issue #9109: [migration] metadata for dashboard filters URL: https://github.com/apache/incubator-superset/pull/9109#issuecomment-584293503 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=h1) Report > Merging [#9109](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/291306392443a5a0d0e2ee0cc4a95d37c56d4589?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=tree) ```diff @@Coverage Diff@@ ## master #9109 +/- ## = - Coverage59.1% 59.1% -0.01% = Files 372 372 Lines 11920 11922 +2 Branches 29172919 +2 = + Hits 70457046 +1 - Misses 46934694 +1 Partials 182 182 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9109/diff?src=pr=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `43.33% <0%> (+0.09%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=footer). Last update [2913063...008ce3f](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] bharath0208 edited a comment on issue #9113: The environment variable POSTGRES_HOST was missing !!!
bharath0208 edited a comment on issue #9113: The environment variable POSTGRES_HOST was missing !!! URL: https://github.com/apache/incubator-superset/issues/9113#issuecomment-585364396 > @dpgaspar > > I tried downloading the latest code and when i run the docker-compose up command now i see the below error. For some reason its not able to load the loading.png image from the assets folder. > > superset_1 | 172.18.0.1 - - [12/Feb/2020 18:58:29] "GET /superset/welcome HTTP/1.1" 200 - > superset_1 | INFO:werkzeug:172.18.0.1 - - [12/Feb/2020 18:58:29] "GET /superset/welcome HTTP/1.1" 200 - > superset_1 | 172.18.0.1 - - [12/Feb/2020 18:58:29] "GET /static/assets/images/loading.gif HTTP/1.1" 404 - > superset_1 | INFO:werkzeug:172.18.0.1 - - [12/Feb/2020 18:58:29] "GET /static/assets/images/loading.gif HTTP/1.1" 404 - > superset_1 | 172.18.0.1 - - [12/Feb/2020 18:58:35] "GET /superset/welcome HTTP/1.1" 200 - > superset_1 | INFO:werkzeug:172.18.0.1 - - [12/Feb/2020 18:58:35] "GET /superset/welcome HTTP/1.1" 200 - > superset_1 | 172.18.0.1 - - [12/Feb/2020 18:58:35] "GET /static/assets/images/loading.gif HTTP/1.1" 404 - > superset_1 | INFO:werkzeug:172.18.0.1 - - [12/Feb/2020 18:58:35] "GET /static/assets/images/loading.gif HTTP/1.1" 404 - > superset_1 | 127.0.0.1 - - [12/Feb/2020 18:58:47] "GET /health HTTP/1.1" 200 - > > #bug This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] bharath0208 commented on issue #9113: The environment variable POSTGRES_HOST was missing !!!
bharath0208 commented on issue #9113: The environment variable POSTGRES_HOST was missing !!! URL: https://github.com/apache/incubator-superset/issues/9113#issuecomment-585364396 > @dpgaspar > > I tried downloading the latest code and now i see the below error. For some reason its not able to load the loading.png image from the assets folder. > > superset_1 | 172.18.0.1 - - [12/Feb/2020 18:58:29] "GET /superset/welcome HTTP/1.1" 200 - > superset_1 | INFO:werkzeug:172.18.0.1 - - [12/Feb/2020 18:58:29] "GET /superset/welcome HTTP/1.1" 200 - > superset_1 | 172.18.0.1 - - [12/Feb/2020 18:58:29] "GET /static/assets/images/loading.gif HTTP/1.1" 404 - > superset_1 | INFO:werkzeug:172.18.0.1 - - [12/Feb/2020 18:58:29] "GET /static/assets/images/loading.gif HTTP/1.1" 404 - > superset_1 | 172.18.0.1 - - [12/Feb/2020 18:58:35] "GET /superset/welcome HTTP/1.1" 200 - > superset_1 | INFO:werkzeug:172.18.0.1 - - [12/Feb/2020 18:58:35] "GET /superset/welcome HTTP/1.1" 200 - > superset_1 | 172.18.0.1 - - [12/Feb/2020 18:58:35] "GET /static/assets/images/loading.gif HTTP/1.1" 404 - > superset_1 | INFO:werkzeug:172.18.0.1 - - [12/Feb/2020 18:58:35] "GET /static/assets/images/loading.gif HTTP/1.1" 404 - > superset_1 | 127.0.0.1 - - [12/Feb/2020 18:58:47] "GET /health HTTP/1.1" 200 - > > #bug This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] bharath0208 commented on issue #9113: The environment variable POSTGRES_HOST was missing !!!
bharath0208 commented on issue #9113: The environment variable POSTGRES_HOST was missing !!! URL: https://github.com/apache/incubator-superset/issues/9113#issuecomment-585364302 @dpgaspar I tried downloading the latest code and now i see the below error. For some reason its not able to load the loading.png image from the assets folder. superset_1 | 172.18.0.1 - - [12/Feb/2020 18:58:29] "GET /superset/welcome HTTP/1.1" 200 - superset_1 | INFO:werkzeug:172.18.0.1 - - [12/Feb/2020 18:58:29] "GET /superset/welcome HTTP/1.1" 200 - superset_1 | 172.18.0.1 - - [12/Feb/2020 18:58:29] "GET /static/assets/images/loading.gif HTTP/1.1" 404 - superset_1 | INFO:werkzeug:172.18.0.1 - - [12/Feb/2020 18:58:29] "GET /static/assets/images/loading.gif HTTP/1.1" 404 - superset_1 | 172.18.0.1 - - [12/Feb/2020 18:58:35] "GET /superset/welcome HTTP/1.1" 200 - superset_1 | INFO:werkzeug:172.18.0.1 - - [12/Feb/2020 18:58:35] "GET /superset/welcome HTTP/1.1" 200 - superset_1 | 172.18.0.1 - - [12/Feb/2020 18:58:35] "GET /static/assets/images/loading.gif HTTP/1.1" 404 - superset_1 | INFO:werkzeug:172.18.0.1 - - [12/Feb/2020 18:58:35] "GET /static/assets/images/loading.gif HTTP/1.1" 404 - superset_1 | 127.0.0.1 - - [12/Feb/2020 18:58:47] "GET /health HTTP/1.1" 200 - #bug This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] Taki-Eddine commented on issue #9108: UI won't load
Taki-Eddine commented on issue #9108: UI won't load URL: https://github.com/apache/incubator-superset/issues/9108#issuecomment-585361793 Fixed by #9114. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dakotacody removed a comment on issue #8278: Time in filter box is showing as unix timestamp
dakotacody removed a comment on issue #8278: Time in filter box is showing as unix timestamp URL: https://github.com/apache/incubator-superset/issues/8278#issuecomment-585342399 I'd like for this to not be stale since I am experiencing this issue too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dakotacody commented on issue #8278: Time in filter box is showing as unix timestamp
dakotacody commented on issue #8278: Time in filter box is showing as unix timestamp URL: https://github.com/apache/incubator-superset/issues/8278#issuecomment-585342399 I'd like for this to not be stale since I am experiencing this issue too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #9109: [migration] metadata for dashboard filters
graceguo-supercat commented on a change in pull request #9109: [migration]
metadata for dashboard filters
URL:
https://github.com/apache/incubator-superset/pull/9109#discussion_r378418055
##
File path: superset/utils/dashboard_filter_scopes_converter.py
##
@@ -0,0 +1,73 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import json
+import logging
+from typing import Dict, List
+
+from superset.models.slice import Slice
+
+logger = logging.getLogger(__name__)
+
+
+def convert_filter_scopes(json_metadata: Dict, filters: List[Slice]):
+filter_scopes = {}
+immuned_by_id: List[int] = json_metadata.get("filter_immune_slices") or []
+immuned_by_column: Dict = {}
+for slice_id, columns in json_metadata.get(
+"filter_immune_slice_fields", {}
+).items():
+for column in columns:
+if immuned_by_column.get(column, None) is None:
Review comment:
fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #9109: [migration] metadata for dashboard filters
graceguo-supercat commented on a change in pull request #9109: [migration]
metadata for dashboard filters
URL:
https://github.com/apache/incubator-superset/pull/9109#discussion_r378417495
##
File path:
superset/migrations/versions/3325d4caccc8_dashboard_scoped_filters.py
##
@@ -0,0 +1,111 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""empty message
+
+Revision ID: 3325d4caccc8
+Revises: e96dbf2cfef0
+Create Date: 2020-02-07 14:13:51.714678
+
+"""
+
+# revision identifiers, used by Alembic.
+import json
+import logging
+
+from alembic import op
+from sqlalchemy import and_, Column, ForeignKey, Integer, String, Table, Text
+from sqlalchemy.ext.declarative import declarative_base
+from sqlalchemy.orm import relationship
+
+from superset import db
+from superset.utils.dashboard_filter_scopes_converter import
convert_filter_scopes
+
+revision = "3325d4caccc8"
+down_revision = "e96dbf2cfef0"
+
+Base = declarative_base()
+
+
+class Slice(Base):
+"""Declarative class to do query in upgrade"""
+
+__tablename__ = "slices"
+id = Column(Integer, primary_key=True)
+slice_name = Column(String(250))
+params = Column(Text)
+viz_type = Column(String(250))
+
+
+dashboard_slices = Table(
+"dashboard_slices",
+Base.metadata,
+Column("id", Integer, primary_key=True),
+Column("dashboard_id", Integer, ForeignKey("dashboards.id")),
+Column("slice_id", Integer, ForeignKey("slices.id")),
+)
+
+
+class Dashboard(Base):
+__tablename__ = "dashboards"
+id = Column(Integer, primary_key=True)
+json_metadata = Column(Text)
+slices = relationship("Slice", secondary=dashboard_slices,
backref="dashboards")
+
+
+def upgrade():
+bind = op.get_bind()
+session = db.Session(bind=bind)
+
+dashboards = session.query(Dashboard).all()
+for i, dashboard in enumerate(dashboards):
+print(f"scanning dashboard ({i + 1}/{len(dashboards)}) ")
+try:
+json_metadata = json.loads(dashboard.json_metadata or "{}")
+if "filter_scopes" in json_metadata:
+continue
+
+filter_scopes = {}
+filters = [
+slice for slice in dashboard.slices if slice.viz_type ==
"filter_box"
+]
+
+# if dashboard has filter_box
+if filters:
+filter_scopes = convert_filter_scopes(json_metadata, filters)
+
+json_metadata.pop("filter_immune_slices", None)
+json_metadata.pop("filter_immune_slice_fields", None)
+if filter_scopes:
+json_metadata["filter_scopes"] = filter_scopes
+logging.info(
+f"Adding filter_scopes for dashboard {dashboard.id}:
{json.dumps(filter_scopes)}"
+)
+if json_metadata:
Review comment:
correct! I fixed it.
some old dashboards have no json_metadata. so after this migration i want to
keep their json_metadata attribute be `None` instead of `{}`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #9109: [migration] metadata for dashboard filters
graceguo-supercat commented on a change in pull request #9109: [migration]
metadata for dashboard filters
URL:
https://github.com/apache/incubator-superset/pull/9109#discussion_r378417974
##
File path:
superset/migrations/versions/3325d4caccc8_dashboard_scoped_filters.py
##
@@ -0,0 +1,111 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""empty message
+
+Revision ID: 3325d4caccc8
+Revises: e96dbf2cfef0
+Create Date: 2020-02-07 14:13:51.714678
+
+"""
+
+# revision identifiers, used by Alembic.
+import json
+import logging
+
+from alembic import op
+from sqlalchemy import and_, Column, ForeignKey, Integer, String, Table, Text
+from sqlalchemy.ext.declarative import declarative_base
+from sqlalchemy.orm import relationship
+
+from superset import db
+from superset.utils.dashboard_filter_scopes_converter import
convert_filter_scopes
+
+revision = "3325d4caccc8"
+down_revision = "e96dbf2cfef0"
+
+Base = declarative_base()
+
+
+class Slice(Base):
+"""Declarative class to do query in upgrade"""
+
+__tablename__ = "slices"
+id = Column(Integer, primary_key=True)
+slice_name = Column(String(250))
+params = Column(Text)
+viz_type = Column(String(250))
+
+
+dashboard_slices = Table(
+"dashboard_slices",
+Base.metadata,
+Column("id", Integer, primary_key=True),
+Column("dashboard_id", Integer, ForeignKey("dashboards.id")),
+Column("slice_id", Integer, ForeignKey("slices.id")),
+)
+
+
+class Dashboard(Base):
+__tablename__ = "dashboards"
+id = Column(Integer, primary_key=True)
+json_metadata = Column(Text)
+slices = relationship("Slice", secondary=dashboard_slices,
backref="dashboards")
+
+
+def upgrade():
+bind = op.get_bind()
+session = db.Session(bind=bind)
+
+dashboards = session.query(Dashboard).all()
+for i, dashboard in enumerate(dashboards):
+print(f"scanning dashboard ({i + 1}/{len(dashboards)}) ")
+try:
+json_metadata = json.loads(dashboard.json_metadata or "{}")
+if "filter_scopes" in json_metadata:
+continue
+
+filter_scopes = {}
+filters = [
+slice for slice in dashboard.slices if slice.viz_type ==
"filter_box"
+]
+
+# if dashboard has filter_box
+if filters:
+filter_scopes = convert_filter_scopes(json_metadata, filters)
+
+json_metadata.pop("filter_immune_slices", None)
+json_metadata.pop("filter_immune_slice_fields", None)
+if filter_scopes:
Review comment:
fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on issue #9119: Update PyArrow to 0.16.0
robdiciuccio commented on issue #9119: Update PyArrow to 0.16.0 URL: https://github.com/apache/incubator-superset/pull/9119#issuecomment-585313350 @john-bodley this does not appear to handle the issue with lists containing mixed int and string values. We'll have to handle that explicitly with additional serialization. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #9122: [fix] Fix table viz column order
mistercrunch commented on a change in pull request #9122: [fix] Fix table viz column order URL: https://github.com/apache/incubator-superset/pull/9122#discussion_r378391583 ## File path: superset/viz.py ## @@ -554,46 +555,50 @@ def query_obj(self): # Add all percent metrics that are not already in the list if "percent_metrics" in fd: -d["metrics"] = d["metrics"] + list( -filter(lambda m: m not in d["metrics"], fd["percent_metrics"] or []) +d["metrics"].extend( +m for m in fd["percent_metrics"] or [] if m not in d["metrics"] Review comment: no action required: I'm surprised to not see brackets around the comprehension, guessing it just returns a generator at that point and `.extend` is ok with that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar closed issue #9112: Superset-node docker compose fails to create container
dpgaspar closed issue #9112: Superset-node docker compose fails to create container URL: https://github.com/apache/incubator-superset/issues/9112 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #9114: [docker] fix, Dockerfile for frontend builds
dpgaspar merged pull request #9114: [docker] fix, Dockerfile for frontend builds URL: https://github.com/apache/incubator-superset/pull/9114 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] PRamia opened a new issue #9128: default Docker-compose creates an "unhealthy" superset-worker container
PRamia opened a new issue #9128: default Docker-compose creates an "unhealthy" superset-worker container URL: https://github.com/apache/incubator-superset/issues/9128 Hi, when i just run the docker-compose for superset, just with the default configuration, the superset-worker container has an unhealthy status. This is relevant for me because i am trying to use the email reporting option, and the communication between superset with worker is failing. Related with this topic, docker-compose that doesn't includes the email components and i found any good documentation about how to implement it using docker. It would be nice if somebody could share a working setup to run docker superset with a standard email feature implemented. Thanks in advance! :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on issue #9110: Superset install pulls in werkzeug 1.0 which has changed paths for imports, breaking the intsall
dpgaspar commented on issue #9110: Superset install pulls in werkzeug 1.0 which has changed paths for imports, breaking the intsall URL: https://github.com/apache/incubator-superset/issues/9110#issuecomment-585228026 Fixed with #9117 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar closed issue #9110: Superset install pulls in werkzeug 1.0 which has changed paths for imports, breaking the intsall
dpgaspar closed issue #9110: Superset install pulls in werkzeug 1.0 which has changed paths for imports, breaking the intsall URL: https://github.com/apache/incubator-superset/issues/9110 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8536: Pass url parameters from dashboard to charts
villebro commented on issue #8536: Pass url parameters from dashboard to charts URL: https://github.com/apache/incubator-superset/pull/8536#issuecomment-585210241 @ForzaDesignStudio unfortunately this had to be dropped from `0.35.2` as it didn't apply cleanly to the `0.35` branch. As it stands this fix will be available in the `0.36.0` release, probably due out this month. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] klazaj removed a comment on issue #4840: ldap configuration
klazaj removed a comment on issue #4840: ldap configuration URL: https://github.com/apache/incubator-superset/issues/4840#issuecomment-514979151 Is this LDAP authentication only for one user? What if there's many users? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] klazaj opened a new issue #9127: "Exception: No ldap library for python" when running Superset with Docker
klazaj opened a new issue #9127: "Exception: No ldap library for python" when running Superset with Docker URL: https://github.com/apache/incubator-superset/issues/9127 I'm running Superset with Docker. I changed the Authentication type from `AUTH_DB` to `AUTH_LDAP` in `config.py` like so: ``` AUTH_TYPE = AUTH_LDAP AUTH_LDAP_SERVER = "ldap://ldap.forumsys.com; AUTH_LDAP_SEARCH = "dc=example ,dc=com" AUTH_LDAP_BIND_PASSWORD = "password" ``` But when I try to login, I get the exception `No ldap library for python`. Why is that? Doesn't Python ldap install at the beginning of the image creation? Do I need to add `pyldap` or something similar to the requirements.txt and rebuild the image? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] chongzixin commented on issue #8818: Superset dashboard or no data loading after login
chongzixin commented on issue #8818: Superset dashboard or no data loading after login URL: https://github.com/apache/incubator-superset/issues/8818#issuecomment-585175175 > > @nabinkhadka I looked into the issue you merged #8883 , as I had the same error message.. turns out I was missing webpack. `npm update` then retrying `docker-compose up` fixed the issue for me. > > That worked for me! > > Outside docker, on your local repo, you should enter `superset/assets/` folder and run `npm update`. > > And the, as @nabinkhadka said run `docker-compose up` `superset/assets/` doesnt exist anymore. has it been renamed to something else? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ForzaDesignStudio commented on issue #8536: Pass url parameters from dashboard to charts
ForzaDesignStudio commented on issue #8536: Pass url parameters from dashboard to charts URL: https://github.com/apache/incubator-superset/pull/8536#issuecomment-585164805 Hi, i am trying this and have followed the solution but it will not filter for me. i have done they query in sql lab, made the chart and changed the metadata that makes a table with name_1, name_2, but changing the URL does not seem to filter my dashboard. Any idea why this is not working? Did you test this on a server rather than locally just? thanks! Version 0.35.1  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar edited a comment on issue #9104: Connecting to Elsaticsearch
dpgaspar edited a comment on issue #9104: Connecting to Elsaticsearch
URL:
https://github.com/apache/incubator-superset/issues/9104#issuecomment-585162171
This is probably because all your non internal indexes are on a yellow state.
You can check what elasticsearch will recognize has "tables" by issuing the
following command:
```
POST /_sql?format=txt
{
"query": "SHOW TABLES'"
}
```
https://www.elastic.co/guide/en/elasticsearch/reference/current/sql-syntax-show-tables.html#sql-syntax-show-tables
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on issue #9104: Connecting to Elsaticsearch
dpgaspar commented on issue #9104: Connecting to Elsaticsearch
URL:
https://github.com/apache/incubator-superset/issues/9104#issuecomment-585162171
This is probably because all your non internal indexes are on a yellow state.
You can check what elasticsearch will recognize has "tables" by issuing the
following command:
POST /_sql?format=txt
{
"query": "SHOW TABLES'"
}
https://www.elastic.co/guide/en/elasticsearch/reference/current/sql-syntax-show-tables.html#sql-syntax-show-tables
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] visakhmurukes commented on issue #4040: Dark Theme?
visakhmurukes commented on issue #4040: Dark Theme? URL: https://github.com/apache/incubator-superset/issues/4040#issuecomment-585159643 Any updates on this? Would be a great addition to have this This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] aboganas commented on issue #8881: Support for Redis Cluster
aboganas commented on issue #8881: Support for Redis Cluster URL: https://github.com/apache/incubator-superset/issues/8881#issuecomment-585136669 any advice on how to use Redis cluster with Superset This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] GouthamanAsokan commented on issue #9104: Connecting to Elsaticsearch
GouthamanAsokan commented on issue #9104: Connecting to Elsaticsearch URL: https://github.com/apache/incubator-superset/issues/9104#issuecomment-585134001 green open .apm-agent-configuration PagMWp9kR4Sw0F2VPx4Zxw 1 0 0 0 283b283b yellow open monthlydate KRMZ77s1Q3aq9OxOSg8rYA 1 1 0 0 283b283b green open .reporting-2020.02.0227fHmtIITIS4pj1mz_hzBw 1 0 1 0 407.7kb 407.7kb green open .kibana_1si-Se2tKQ46authC3xy5XA 1 0 7 0 22.4kb 22.4kb yellow open movies ArWlVhksQ9e2ISyuMJhqzg 1 1 0 0 283b283b green open .kibana_task_manager_1 uIOLevlbTvK1JJjF5Boghg 1 0 2 0 12.5kb 12.5kb yellow open apache_superset YGQvuDmET4KxJt2xliIrxw 1 1 0 0 283b283b yellow open dailyiYCHZLO2TUSJhnGfjZtLOw 1 1 0 0 283b283b yellow open monthggd WDp-DfRQTxm7MVbKhNyrkg 1 1 0 0 283b283b yellow open monthly LocrDyBrTKyOvOZFxgga2g 1 1 10102 0 1.6mb 1.6mb yellow open monthly_table9XBpKMDhQrmKY4P_xzZwMA 1 1 0 0 283b283b yellow open monthlyddPkyd32tmQB-FKGeF2M7tHQ 1 1 0 0 283b283b yellow open monthly_date Fh5H1SzlTbOqmNH6R429Lw 1 1 0 0 283b283b yellow open tablesTBFZmIqQAGbQZIs3wBpEw 1 1 0 0 283b283b This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #9117: Bump FAB to 2.2.3
dpgaspar merged pull request #9117: Bump FAB to 2.2.3 URL: https://github.com/apache/incubator-superset/pull/9117 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9114: fix Dockerfile for frontend builds
dpgaspar commented on a change in pull request #9114: fix Dockerfile for frontend builds URL: https://github.com/apache/incubator-superset/pull/9114#discussion_r378113798 ## File path: Dockerfile ## @@ -81,6 +82,7 @@ RUN useradd --user-group --no-create-home --no-log-init --shell /bin/bash supers COPY --from=superset-py /usr/local/lib/python3.6/site-packages/ /usr/local/lib/python3.6/site-packages/ # Copying site-packages doesn't move the CLIs, so let's copy them one by one COPY --from=superset-py /usr/local/bin/gunicorn /usr/local/bin/celery /usr/local/bin/flask /usr/bin/ +COPY --from=superset-node /app/superset/static/assets /app/superset/static/assets Review comment: Have not tested it yet, but seems like this should be: `COPY --from=superset-node /app/superset/assets /app/superset/static/assets` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
