[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9803: fix: invalid JSON in FR translation

2020-05-13 Thread GitBox
codecov-io edited a comment on pull request #9803: URL: https://github.com/apache/incubator-superset/pull/9803#issuecomment-628387023 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9803?src=pr&el=h1) Report > Merging [#9803](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-io commented on pull request #9803: fix: invalid JSON in FR translation

2020-05-13 Thread GitBox
codecov-io commented on pull request #9803: URL: https://github.com/apache/incubator-superset/pull/9803#issuecomment-628387023 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9803?src=pr&el=h1) Report > Merging [#9803](https://codecov.io/gh/apache/incubator-superset/p

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9803: fix: invalid JSON in FR translation

2020-05-13 Thread GitBox
codecov-io edited a comment on pull request #9803: URL: https://github.com/apache/incubator-superset/pull/9803#issuecomment-628387023 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9803?src=pr&el=h1) Report > Merging [#9803](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9803: fix: invalid JSON in FR translation

2020-05-13 Thread GitBox
codecov-io edited a comment on pull request #9803: URL: https://github.com/apache/incubator-superset/pull/9803#issuecomment-628387023 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9803?src=pr&el=h1) Report > Merging [#9803](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9803: fix: invalid JSON in FR translation

2020-05-13 Thread GitBox
codecov-io edited a comment on pull request #9803: URL: https://github.com/apache/incubator-superset/pull/9803#issuecomment-628387023 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9803?src=pr&el=h1) Report > Merging [#9803](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9803: fix: invalid JSON in FR translation

2020-05-13 Thread GitBox
codecov-io edited a comment on pull request #9803: URL: https://github.com/apache/incubator-superset/pull/9803#issuecomment-628387023 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9803?src=pr&el=h1) Report > Merging [#9803](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9803: fix: invalid JSON in FR translation

2020-05-13 Thread GitBox
codecov-io edited a comment on pull request #9803: URL: https://github.com/apache/incubator-superset/pull/9803#issuecomment-628387023 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9803?src=pr&el=h1) Report > Merging [#9803](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9803: fix: invalid JSON in FR and DE translations

2020-05-13 Thread GitBox
codecov-io edited a comment on pull request #9803: URL: https://github.com/apache/incubator-superset/pull/9803#issuecomment-628387023 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9803?src=pr&el=h1) Report > Merging [#9803](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9803: fix: invalid JSON in FR translation

2020-05-13 Thread GitBox
codecov-io edited a comment on pull request #9803: URL: https://github.com/apache/incubator-superset/pull/9803#issuecomment-628387023 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9803: fix: invalid JSON in FR translation

2020-05-13 Thread GitBox
codecov-io edited a comment on pull request #9803: URL: https://github.com/apache/incubator-superset/pull/9803#issuecomment-628387023 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9803?src=pr&el=h1) Report > Merging [#9803](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] stefanmo commented on issue #9597: Cache warm-ups never succeed

2020-05-14 Thread GitBox
stefanmo commented on issue #9597: URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-628562775 Any news on this? This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [incubator-superset] thammaneni opened a new issue #9804: How to find redis tasks meta data information in superset schedule job tracking?

2020-05-14 Thread GitBox
thammaneni opened a new issue #9804: URL: https://github.com/apache/incubator-superset/issues/9804 Hi All, I am running email scheduling jobs in superset, using redis db as Broker url and Results backend storage url. I have scheduled 15 jobs in every one hour. there some times 1 job

[GitHub] [incubator-superset] villebro commented on a change in pull request #9752: fix(mssql): reverts #9644 and displays a better error msg

2020-05-14 Thread GitBox
villebro commented on a change in pull request #9752: URL: https://github.com/apache/incubator-superset/pull/9752#discussion_r425084363 ## File path: superset/db_engine_specs/mssql.py ## @@ -85,6 +84,10 @@ def get_sqla_column_type(cls, type_: str) -> Optional[TypeEngine]:

[GitHub] [incubator-superset] squalou commented on issue #7406: Pivot table null values in columns

2020-05-14 Thread GitBox
squalou commented on issue #7406: URL: https://github.com/apache/incubator-superset/issues/7406#issuecomment-628626344 Hi, personnally I overwrite the initial file in a docker image, so my file is taken into account whenever syperset starts. Maybe in your case you may have to rem

[GitHub] [incubator-superset] squalou opened a new issue #9805: Table display "null" instead of empty values (0.3.0 compared to 0.34.0)

2020-05-14 Thread GitBox
squalou opened a new issue #9805: URL: https://github.com/apache/incubator-superset/issues/9805 In a simple table chart, when nothing was to be diplayed, the cell was empty. Now 'null' is written ### Expected results Here's the display of null values in 0.34.0. As you can see,

[GitHub] [incubator-superset] Pinimo commented on issue #9597: Cache warm-ups never succeed

2020-05-14 Thread GitBox
Pinimo commented on issue #9597: URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-628656143 A colleague made a POC on this, but came to the conclusion it is already quite difficult to have the email reports working... He wanted to use part of that code (headless

[GitHub] [incubator-superset] Pinimo commented on issue #9597: Cache warm-ups never succeed

2020-05-14 Thread GitBox
Pinimo commented on issue #9597: URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-628659239 To my knowledge the feature is (and will stay...) broken :cry: This is an automated message from the Apac

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9752: fix(mssql): reverts #9644 and displays a better error msg

2020-05-14 Thread GitBox
dpgaspar commented on a change in pull request #9752: URL: https://github.com/apache/incubator-superset/pull/9752#discussion_r425176265 ## File path: superset/db_engine_specs/mssql.py ## @@ -85,6 +84,10 @@ def get_sqla_column_type(cls, type_: str) -> Optional[TypeEngine]:

[GitHub] [incubator-superset] codecov-io commented on pull request #9775: tests(celery): improve celery tests infra

2020-05-14 Thread GitBox
codecov-io commented on pull request #9775: URL: https://github.com/apache/incubator-superset/pull/9775#issuecomment-628683046 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9775?src=pr&el=h1) Report > Merging [#9775](https://codecov.io/gh/apache/incubator-superset/p

[GitHub] [incubator-superset] eugeniamz commented on issue #9783: postgresql error: function date_trunc(unknown, text) does not exist LINE 1

2020-05-14 Thread GitBox
eugeniamz commented on issue #9783: URL: https://github.com/apache/incubator-superset/issues/9783#issuecomment-628721520 I think the docker amancevice/superset has an old version of superset, I am wondering if it has the right drivers. I am using postgresql:// no postgresql+psycopg2://

[GitHub] [incubator-superset] dpgaspar merged pull request #9775: tests(celery): improve celery tests infra

2020-05-14 Thread GitBox
dpgaspar merged pull request #9775: URL: https://github.com/apache/incubator-superset/pull/9775 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-superset] dpgaspar merged pull request #9752: fix(mssql): reverts #9644 and displays a better error msg

2020-05-14 Thread GitBox
dpgaspar merged pull request #9752: URL: https://github.com/apache/incubator-superset/pull/9752 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9800: style: enforcing mypy typing for translations

2020-05-14 Thread GitBox
etr2460 commented on a change in pull request #9800: URL: https://github.com/apache/incubator-superset/pull/9800#discussion_r425251345 ## File path: superset/translations/utils.py ## @@ -38,7 +38,7 @@ def get_language_pack(locale): try: with open(filename

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-14 Thread GitBox
etr2460 commented on a change in pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#discussion_r425259829 ## File path: superset/config.py ## @@ -586,11 +586,24 @@ class CeleryConfig: # pylint: disable=too-few-public-methods # The directory with

[GitHub] [incubator-superset] DanielGnzlzVll commented on issue #9780: Service 'superset' failed to build

2020-05-14 Thread GitBox
DanielGnzlzVll commented on issue #9780: URL: https://github.com/apache/incubator-superset/issues/9780#issuecomment-628756372 I have same issue on a windows machine. How reproduce it? ```bash docker-compose build --no-cache ``` ![image](https://user-images.github

[GitHub] [incubator-superset] DanielGnzlzVll edited a comment on issue #9780: Service 'superset' failed to build

2020-05-14 Thread GitBox
DanielGnzlzVll edited a comment on issue #9780: URL: https://github.com/apache/incubator-superset/issues/9780#issuecomment-628756372 I have same issue on a windows machine. How reproduce it? ```bash docker-compose build --no-cache ``` ![image](https://user-images

[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-14 Thread GitBox
bkyryliuk commented on a change in pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#discussion_r425312581 ## File path: superset/config.py ## @@ -586,11 +586,24 @@ class CeleryConfig: # pylint: disable=too-few-public-methods # The directory wi

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9800: style: enforcing mypy typing for translations

2020-05-14 Thread GitBox
john-bodley commented on a change in pull request #9800: URL: https://github.com/apache/incubator-superset/pull/9800#discussion_r425323726 ## File path: superset/translations/utils.py ## @@ -38,7 +38,7 @@ def get_language_pack(locale): try: with open(file

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-14 Thread GitBox
codecov-io edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-623887876 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr&el=h1) Report > Merging [#9734](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-14 Thread GitBox
codecov-io edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-623887876 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-14 Thread GitBox
codecov-io edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-623887876 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr&el=h1) Report > Merging [#9734](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] pkdotson opened a new pull request #9806: WIP: markupchart plugin controls migration

2020-05-14 Thread GitBox
pkdotson opened a new pull request #9806: URL: https://github.com/apache/incubator-superset/pull/9806 ### SUMMARY remove controls from incubator, remove shims and update version number. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TEST PLAN ### ADDITIONAL

[GitHub] [incubator-superset] JMGGarcia opened a new issue #9807: Problems with Public role after updating

2020-05-14 Thread GitBox
JMGGarcia opened a new issue #9807: URL: https://github.com/apache/incubator-superset/issues/9807 Hello! I've been running an older version of Superset without a problem, where I embed some dashboards on my website and through the Public user role permissions it is possible to see and use

[GitHub] [incubator-superset] codecov-io commented on pull request #9806: WIP: markupchart plugin controls migration

2020-05-14 Thread GitBox
codecov-io commented on pull request #9806: URL: https://github.com/apache/incubator-superset/pull/9806#issuecomment-628821150 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9806?src=pr&el=h1) Report > Merging [#9806](https://codecov.io/gh/apache/incubator-superset/p

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9806: WIP: markupchart plugin controls migration

2020-05-14 Thread GitBox
codecov-io edited a comment on pull request #9806: URL: https://github.com/apache/incubator-superset/pull/9806#issuecomment-628821150 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9806?src=pr&el=h1) Report > Merging [#9806](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9806: WIP: markupchart plugin controls migration

2020-05-14 Thread GitBox
codecov-io edited a comment on pull request #9806: URL: https://github.com/apache/incubator-superset/pull/9806#issuecomment-628821150 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9806?src=pr&el=h1) Report > Merging [#9806](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] ktmud opened a new pull request #9808: feat: bump superset-ui/time-format and big-number

2020-05-14 Thread GitBox
ktmud opened a new pull request #9808: URL: https://github.com/apache/incubator-superset/pull/9808 # SUMMARY Bump `superset-ui/time-format ` and the big number chart to add full dates to big number datetime formatted in weekly interval. See https://github.com/apache-superset/s

[GitHub] [incubator-superset] Custos opened a new issue #9809: GeoJSON file in 0.36.0 too large for Google App Engine

2020-05-14 Thread GitBox
Custos opened a new issue #9809: URL: https://github.com/apache/incubator-superset/issues/9809 I'm having an issue deploying to Google App Engine due to the `341142ac8466aaa1ffca6462f1f4e3f9.geojson` file breaking because the file is too large. To the extent possible, it would be good to

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9655: build: set up GitHub app PRLint

2020-05-14 Thread GitBox
ktmud commented on a change in pull request #9655: URL: https://github.com/apache/incubator-superset/pull/9655#discussion_r425405975 ## File path: .github/PULL_REQUEST_TEMPLATE.md ## @@ -27,5 +16,3 @@ Choose one - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ]

[GitHub] [incubator-superset] bkyryliuk opened a new pull request #9810: feat: [WIP] Superset report slack integration

2020-05-14 Thread GitBox
bkyryliuk opened a new pull request #9810: URL: https://github.com/apache/incubator-superset/pull/9810 ### SUMMARY Implements slack support for the superset scheduled reports. This is a simple extension of the existing email functionality. It also includes a some refactor that dec

[GitHub] [incubator-superset] willbarrett opened a new pull request #9811: Emit a warning message rather than an exception on query failure

2020-05-14 Thread GitBox
willbarrett opened a new pull request #9811: URL: https://github.com/apache/incubator-superset/pull/9811 ### SUMMARY Exception messages are frequently bubbled up to error aggregators like Sentry, Airbrake, and the like from web applications. As queries can fail for a wide variety of rea

[GitHub] [incubator-superset] john-bodley commented on pull request #9811: fix: Emit a warning message rather than an exception on query failure

2020-05-14 Thread GitBox
john-bodley commented on pull request #9811: URL: https://github.com/apache/incubator-superset/pull/9811#issuecomment-628912091 cc @etr2460 for context. This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-superset] rusackas merged pull request #9803: fix: invalid JSON in FR and DE translations

2020-05-14 Thread GitBox
rusackas merged pull request #9803: URL: https://github.com/apache/incubator-superset/pull/9803 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-superset] nytai commented on pull request #9793: feat: Add the ability to set the user profile page as the welcome page

2020-05-14 Thread GitBox
nytai commented on pull request #9793: URL: https://github.com/apache/incubator-superset/pull/9793#issuecomment-628923710 @altef Just toggle the flag, request the route, endure the correct page is returned. You can probably add the test here: https://github.com/preset-io/incubator-superse

[GitHub] [incubator-superset] nytai edited a comment on pull request #9793: feat: Add the ability to set the user profile page as the welcome page

2020-05-14 Thread GitBox
nytai edited a comment on pull request #9793: URL: https://github.com/apache/incubator-superset/pull/9793#issuecomment-628923710 @altef Just toggle the flag, request the route, endure the correct page is returned. You can probably add the test here: https://github.com/preset-io/incubator-

[GitHub] [incubator-superset] craig-rueda commented on pull request #9811: fix: Emit a warning message rather than an exception on query failure

2020-05-14 Thread GitBox
craig-rueda commented on pull request #9811: URL: https://github.com/apache/incubator-superset/pull/9811#issuecomment-628929312 An issue I see with this is the potential swallowing of useful information. Does it make sense to set `exc_info=True` here? In this way we would still get stack

[GitHub] [incubator-superset] nytai opened a new pull request #9812: fix: sync package-lock.json

2020-05-14 Thread GitBox
nytai opened a new pull request #9812: URL: https://github.com/apache/incubator-superset/pull/9812 ### SUMMARY It seems our package-lock.json has fallen out of sync with package.json. Most likely someone didn't commit the changes to this file. -

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

2020-05-14 Thread GitBox
etr2460 commented on a change in pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r424716562 ## File path: superset-frontend/src/components/ColumnOption.jsx ## @@ -42,28 +42,28 @@ export default function ColumnOption({ column, showType

[GitHub] [incubator-superset] codecov-io commented on pull request #9812: fix: sync package-lock.json

2020-05-14 Thread GitBox
codecov-io commented on pull request #9812: URL: https://github.com/apache/incubator-superset/pull/9812#issuecomment-628932352 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9812?src=pr&el=h1) Report > Merging [#9812](https://codecov.io/gh/apache/incubator-superset/p

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9812: fix: sync package-lock.json

2020-05-14 Thread GitBox
codecov-io edited a comment on pull request #9812: URL: https://github.com/apache/incubator-superset/pull/9812#issuecomment-628932352 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9812?src=pr&el=h1) Report > Merging [#9812](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9812: fix: sync package-lock.json

2020-05-14 Thread GitBox
codecov-io edited a comment on pull request #9812: URL: https://github.com/apache/incubator-superset/pull/9812#issuecomment-628932352 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9812?src=pr&el=h1) Report > Merging [#9812](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9812: fix: sync package-lock.json

2020-05-14 Thread GitBox
codecov-io edited a comment on pull request #9812: URL: https://github.com/apache/incubator-superset/pull/9812#issuecomment-628932352 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9812?src=pr&el=h1) Report > Merging [#9812](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9812: fix: sync package-lock.json

2020-05-14 Thread GitBox
codecov-io edited a comment on pull request #9812: URL: https://github.com/apache/incubator-superset/pull/9812#issuecomment-628932352 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9812?src=pr&el=h1) Report > Merging [#9812](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

2020-05-14 Thread GitBox
ktmud commented on a change in pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425485429 ## File path: superset-frontend/cypress-base/cypress/integration/dashboard/filter.js ## @@ -53,12 +53,11 @@ export default () => });

[GitHub] [incubator-superset] nytai commented on pull request #9812: fix: sync package-lock.json

2020-05-14 Thread GitBox
nytai commented on pull request #9812: URL: https://github.com/apache/incubator-superset/pull/9812#issuecomment-628941277 codecov makes no sense This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-superset] altef commented on pull request #9793: feat: Add the ability to set the user profile page as the welcome page

2020-05-14 Thread GitBox
altef commented on pull request #9793: URL: https://github.com/apache/incubator-superset/pull/9793#issuecomment-628941699 Awesome - thanks for that, @nytai! _Test added._ This is an automated message from the Apache Git Se

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

2020-05-14 Thread GitBox
ktmud commented on a change in pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425488309 ## File path: superset-frontend/src/components/AsyncSelect.jsx ## @@ -18,7 +18,8 @@ */ import React from 'react'; import PropTypes from 'pro

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

2020-05-14 Thread GitBox
ktmud commented on a change in pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425488309 ## File path: superset-frontend/src/components/AsyncSelect.jsx ## @@ -18,7 +18,8 @@ */ import React from 'react'; import PropTypes from 'pro

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9793: feat: Add the ability to set the user profile page as the welcome page

2020-05-14 Thread GitBox
codecov-io edited a comment on pull request #9793: URL: https://github.com/apache/incubator-superset/pull/9793#issuecomment-627675808 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9793: feat: Add the ability to set the user profile page as the welcome page

2020-05-14 Thread GitBox
codecov-io edited a comment on pull request #9793: URL: https://github.com/apache/incubator-superset/pull/9793#issuecomment-627675808 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9793?src=pr&el=h1) Report > Merging [#9793](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

2020-05-14 Thread GitBox
ktmud commented on a change in pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425493528 ## File path: superset-frontend/src/components/ColumnOption.jsx ## @@ -42,28 +42,28 @@ export default function ColumnOption({ column, showType }

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

2020-05-14 Thread GitBox
ktmud commented on a change in pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425494501 ## File path: superset-frontend/src/components/ListView/Filters.tsx ## @@ -37,13 +44,21 @@ interface SelectFilterProps extends BaseFilter { c

[GitHub] [incubator-superset] rusackas merged pull request #9774: upgrade migrated plugins, remove controlPanel configs

2020-05-14 Thread GitBox
rusackas merged pull request #9774: URL: https://github.com/apache/incubator-superset/pull/9774 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

2020-05-14 Thread GitBox
ktmud commented on a change in pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425502573 ## File path: superset-frontend/src/components/Select/SupersetStyledSelect.tsx ## @@ -0,0 +1,301 @@ +/** + * Licensed to the Apache Software Fou

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

2020-05-14 Thread GitBox
ktmud commented on a change in pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425504781 ## File path: superset-frontend/src/components/Select/WindowedSelect/WindowedMenuList.tsx ## @@ -0,0 +1,155 @@ +/** + * Licensed to the Apache

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

2020-05-14 Thread GitBox
ktmud commented on a change in pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425506360 ## File path: superset-frontend/src/components/Select/styles.tsx ## @@ -0,0 +1,299 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

2020-05-14 Thread GitBox
ktmud commented on a change in pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425507511 ## File path: superset-frontend/src/components/Select/styles.tsx ## @@ -0,0 +1,299 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

2020-05-14 Thread GitBox
ktmud commented on a change in pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425509615 ## File path: superset-frontend/src/explore/AdhocFilter.js ## @@ -94,7 +91,7 @@ export default class AdhocFilter { this.comparator = null

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

2020-05-14 Thread GitBox
ktmud commented on a change in pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425510784 ## File path: superset-frontend/src/explore/constants.js ## @@ -53,10 +55,10 @@ export const HAVING_OPERATORS = [ OPERATORS['>='], OPERATO

[GitHub] [incubator-superset] Jacobbishopxy opened a new pull request #9813: Jacob

2020-05-14 Thread GitBox
Jacobbishopxy opened a new pull request #9813: URL: https://github.com/apache/incubator-superset/pull/9813 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-superset] request-info[bot] commented on pull request #9813: Jacob

2020-05-14 Thread GitBox
request-info[bot] commented on pull request #9813: URL: https://github.com/apache/incubator-superset/pull/9813#issuecomment-628977720 We would appreciate it if you could provide us with more info about this issue/pr! Please do not leave the `title` or `description` empty. ---

[GitHub] [incubator-superset] Jacobbishopxy closed pull request #9813: Jacob

2020-05-14 Thread GitBox
Jacobbishopxy closed pull request #9813: URL: https://github.com/apache/incubator-superset/pull/9813 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [incubator-superset] rajeshkorandla commented on issue #9558: Running setup.py install for python-geohash ... error

2020-05-14 Thread GitBox
rajeshkorandla commented on issue #9558: URL: https://github.com/apache/incubator-superset/issues/9558#issuecomment-628991950 @dpgaspar, I have the same issue and I have installed the OS dependencies. Any help with this? Th

[GitHub] [incubator-superset] mistercrunch commented on pull request #9811: fix: Emit a warning message rather than an exception on query failure

2020-05-14 Thread GitBox
mistercrunch commented on pull request #9811: URL: https://github.com/apache/incubator-superset/pull/9811#issuecomment-629010867 I think with `exception` you get the stack trace in the logs which can be very useful. We use this ~79 times in the codebase ``` 20:51 $ git grep "\.except

[GitHub] [incubator-superset] mistercrunch commented on issue #9558: Running setup.py install for python-geohash ... error

2020-05-14 Thread GitBox
mistercrunch commented on issue #9558: URL: https://github.com/apache/incubator-superset/issues/9558#issuecomment-629012860 Well you'll need gcc, you can test whether you have gcc installed with`$ gcc -v`. This is an automa

[GitHub] [incubator-superset] mistercrunch edited a comment on issue #9558: Running setup.py install for python-geohash ... error

2020-05-14 Thread GitBox
mistercrunch edited a comment on issue #9558: URL: https://github.com/apache/incubator-superset/issues/9558#issuecomment-629012860 Well you'll need gcc, you can test whether you have gcc installed with`gcc -v`. This is an a

[GitHub] [incubator-superset] mistercrunch commented on pull request #9810: feat: [WIP] Superset report slack integration

2020-05-14 Thread GitBox
mistercrunch commented on pull request #9810: URL: https://github.com/apache/incubator-superset/pull/9810#issuecomment-629013652 ![omg](https://user-images.githubusercontent.com/487433/82010317-9cb12480-9626-11ea-96aa-201b9fe853bc.gif)

[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #9655: build: set up GitHub app PRLint

2020-05-14 Thread GitBox
mistercrunch commented on a change in pull request #9655: URL: https://github.com/apache/incubator-superset/pull/9655#discussion_r42879 ## File path: .github/PULL_REQUEST_TEMPLATE.md ## @@ -27,5 +16,3 @@ Choose one - [ ] Confirm DB Migration upgrade and downgrade tested.

[GitHub] [incubator-superset] mistercrunch commented on pull request #9812: fix: sync package-lock.json

2020-05-14 Thread GitBox
mistercrunch commented on pull request #9812: URL: https://github.com/apache/incubator-superset/pull/9812#issuecomment-629015849 merge conflict :( This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-superset] mistercrunch edited a comment on pull request #9812: fix: sync package-lock.json

2020-05-14 Thread GitBox
mistercrunch edited a comment on pull request #9812: URL: https://github.com/apache/incubator-superset/pull/9812#issuecomment-629015849 merge conflict :(, last commit's build on master still broken... This is an automated me

[GitHub] [incubator-superset] mistercrunch commented on issue #9807: Problems with Public role after updating

2020-05-14 Thread GitBox
mistercrunch commented on issue #9807: URL: https://github.com/apache/incubator-superset/issues/9807#issuecomment-629018180 Just reproduced this, it appears running `superset init` resets `Public` to be exactly like `Alpha` (removes what was added manually) --

[GitHub] [incubator-superset] stale[bot] closed issue #9233: % interpreted as a python format character in SQLlab during CSV export

2020-05-14 Thread GitBox
stale[bot] closed issue #9233: URL: https://github.com/apache/incubator-superset/issues/9233 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

2020-05-14 Thread GitBox
codecov-io edited a comment on pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report > Merging [#9628](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] mistercrunch commented on issue #9807: Problems with Public role after updating

2020-05-14 Thread GitBox
mistercrunch commented on issue #9807: URL: https://github.com/apache/incubator-superset/issues/9807#issuecomment-629031934 As a workaround, you may be able to set `PUBLIC_ROLE_LIKE_GAMMA = True`, run `superset init`, set `PUBLIC_ROLE_LIKE_GAMMA = False` and then alter Public role.

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

2020-05-14 Thread GitBox
codecov-io edited a comment on pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report > Merging [#9628](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

2020-05-14 Thread GitBox
codecov-io edited a comment on pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report > Merging [#9628](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

2020-05-14 Thread GitBox
codecov-io edited a comment on pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-superset] codecov-io commented on pull request #9808: feat: bump superset-ui/time-format and big-number

2020-05-14 Thread GitBox
codecov-io commented on pull request #9808: URL: https://github.com/apache/incubator-superset/pull/9808#issuecomment-629033128 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9808?src=pr&el=h1) Report > Merging [#9808](https://codecov.io/gh/apache/incubator-superset/p

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9808: feat: bump superset-ui/time-format and big-number

2020-05-14 Thread GitBox
codecov-io edited a comment on pull request #9808: URL: https://github.com/apache/incubator-superset/pull/9808#issuecomment-629033128 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9808?src=pr&el=h1) Report > Merging [#9808](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9808: feat: bump superset-ui/time-format and big-number

2020-05-14 Thread GitBox
codecov-io edited a comment on pull request #9808: URL: https://github.com/apache/incubator-superset/pull/9808#issuecomment-629033128 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9808?src=pr&el=h1) Report > Merging [#9808](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9808: feat: bump superset-ui/time-format and big-number

2020-05-14 Thread GitBox
codecov-io edited a comment on pull request #9808: URL: https://github.com/apache/incubator-superset/pull/9808#issuecomment-629033128 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9808?src=pr&el=h1) Report > Merging [#9808](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

2020-05-14 Thread GitBox
codecov-io edited a comment on pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report > Merging [#9628](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9800: style: enforcing mypy typing for translations

2020-05-14 Thread GitBox
etr2460 commented on a change in pull request #9800: URL: https://github.com/apache/incubator-superset/pull/9800#discussion_r425598471 ## File path: superset/translations/utils.py ## @@ -38,7 +38,7 @@ def get_language_pack(locale): try: with open(filename

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9800: style: enforcing mypy typing for translations

2020-05-14 Thread GitBox
etr2460 commented on a change in pull request #9800: URL: https://github.com/apache/incubator-superset/pull/9800#discussion_r425599063 ## File path: superset/translations/utils.py ## @@ -38,7 +38,7 @@ def get_language_pack(locale): try: with open(filename

[GitHub] [incubator-superset] stale[bot] commented on issue #8879: Limit Role Access for specific Tables

2020-05-14 Thread GitBox
stale[bot] commented on issue #8879: URL: https://github.com/apache/incubator-superset/issues/8879#issuecomment-629062116 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribut

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9800: style: enforcing mypy typing for translations

2020-05-15 Thread GitBox
john-bodley commented on a change in pull request #9800: URL: https://github.com/apache/incubator-superset/pull/9800#discussion_r425613370 ## File path: superset/translations/utils.py ## @@ -38,7 +38,7 @@ def get_language_pack(locale): try: with open(file

[GitHub] [incubator-superset] chengkaisheng commented on issue #8749: AddSliceContainer.jsx can't be translated by messages.json

2020-05-15 Thread GitBox
chengkaisheng commented on issue #8749: URL: https://github.com/apache/incubator-superset/issues/8749#issuecomment-629131662 It helps. Thanks! This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-superset] rubenSastre commented on issue #9719: Clickhouse connection issue

2020-05-15 Thread GitBox
rubenSastre commented on issue #9719: URL: https://github.com/apache/incubator-superset/issues/9719#issuecomment-629182135 I have used, clickhouse-sqlalchemy instead of sqlalchemy-clickhouse, seems to have a recent version, but i am finding some diferent problems for it(missing first 2 ro

[GitHub] [incubator-superset] khuranabalvinder commented on issue #7172: Add "metric" to show actual value of column, i.e. no aggregate

2020-05-15 Thread GitBox
khuranabalvinder commented on issue #7172: URL: https://github.com/apache/incubator-superset/issues/7172#issuecomment-629184861 Bump This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-superset] rajeshkorandla commented on issue #9558: Running setup.py install for python-geohash ... error

2020-05-15 Thread GitBox
rajeshkorandla commented on issue #9558: URL: https://github.com/apache/incubator-superset/issues/9558#issuecomment-629199364 @mistercrunch this is what I have - gcc version 4.8.5 20150623 (Red Hat 4.8.5-39.0.3) (GCC) Thi

  1   2   3   4   5   6   7   8   9   10   >