[GitHub] zancos commented on issue #4132: In Pivot Sort order - 1M is considered less than 100K

2018-06-13 Thread GitBox
zancos commented on issue #4132: In Pivot Sort order - 1M is considered less than 100K URL: https://github.com/apache/incubator-superset/issues/4132#issuecomment-397001828 Same here. When sorting, 1.02k is smaller that 2.00 if using .3s number format. We are using version | "0.25.6"

[GitHub] john-bodley commented on issue #5183: fetch datasources from broker endpoint when refresh new datasources

2018-06-13 Thread GitBox
john-bodley commented on issue #5183: fetch datasources from broker endpoint when refresh new datasources URL: https://github.com/apache/incubator-superset/pull/5183#issuecomment-396960598 Do we still need the coordinator for anything? If not we should probably remove it from the model.

[GitHub] mistercrunch opened a new pull request #5189: [druid] remove reliance on coordinator

2018-06-13 Thread GitBox
mistercrunch opened a new pull request #5189: [druid] remove reliance on coordinator URL: https://github.com/apache/incubator-superset/pull/5189 It turns out all of the endpoints we use against the coordinator are also available on the broker.

[GitHub] john-bodley commented on a change in pull request #5184: Pin botocore version

2018-06-13 Thread GitBox
john-bodley commented on a change in pull request #5184: Pin botocore version URL: https://github.com/apache/incubator-superset/pull/5184#discussion_r195105699 ## File path: requirements.txt ## @@ -1,5 +1,6 @@ bleach==2.1.2 boto3==1.4.7 +botocore<1.8.0,>=1.7.0 Review

[GitHub] ledor473 commented on issue #5184: Pin botocore version

2018-06-13 Thread GitBox
ledor473 commented on issue #5184: Pin botocore version URL: https://github.com/apache/incubator-superset/pull/5184#issuecomment-396960983 Running `pip3 freeze` gave me the version `1.7.48`. I've updated the PR with that version

[GitHub] codecov-io commented on issue #5184: Pin botocore version

2018-06-13 Thread GitBox
codecov-io commented on issue #5184: Pin botocore version URL: https://github.com/apache/incubator-superset/pull/5184#issuecomment-396614071 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5184?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5184: Pin botocore version

2018-06-13 Thread GitBox
codecov-io commented on issue #5184: Pin botocore version URL: https://github.com/apache/incubator-superset/pull/5184#issuecomment-396614071 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5184?src=pr=h1) Report > Merging

[GitHub] mistercrunch commented on issue #5183: fetch datasources from broker endpoint when refresh new datasources

2018-06-13 Thread GitBox
mistercrunch commented on issue #5183: fetch datasources from broker endpoint when refresh new datasources URL: https://github.com/apache/incubator-superset/pull/5183#issuecomment-396973530 Ooops, I merged and then say your comment @john-bodley. I was planning on following up with a PR

[GitHub] gbates101 closed issue #5124: Loading appbuilder views instead of flask blueprints

2018-06-13 Thread GitBox
gbates101 closed issue #5124: Loading appbuilder views instead of flask blueprints URL: https://github.com/apache/incubator-superset/issues/5124 This is an automated message from the Apache Git Service. To respond to the

[GitHub] codecov-io commented on issue #5178: [sql] Correct SQL parameter formatting

2018-06-13 Thread GitBox
codecov-io commented on issue #5178: [sql] Correct SQL parameter formatting URL: https://github.com/apache/incubator-superset/pull/5178#issuecomment-396741949 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5178?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5178: [sql] Correct SQL parameter formatting

2018-06-13 Thread GitBox
codecov-io commented on issue #5178: [sql] Correct SQL parameter formatting URL: https://github.com/apache/incubator-superset/pull/5178#issuecomment-396741949 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5178?src=pr=h1) Report > Merging

[GitHub] rumbin commented on issue #5182: Changed of Date to epoch time in Table view - Superset - 0.25.6

2018-06-13 Thread GitBox
rumbin commented on issue #5182: Changed of Date to epoch time in Table view - Superset - 0.25.6 URL: https://github.com/apache/incubator-superset/issues/5182#issuecomment-397018841 @rohanagg I remember that this issue had been reported multiple times by now. However, I haven't looked

[GitHub] jake-barry commented on issue #4666: Sessions still active on Datasource

2018-06-13 Thread GitBox
jake-barry commented on issue #4666: Sessions still active on Datasource URL: https://github.com/apache/incubator-superset/issues/4666#issuecomment-397045876 To get 0.26.rc1 I select that tag from the repo, correct? If so, that's what I did. If not please let me know. Same

[GitHub] ledor473 commented on issue #5184: Pin botocore version

2018-06-13 Thread GitBox
ledor473 commented on issue #5184: Pin botocore version URL: https://github.com/apache/incubator-superset/pull/5184#issuecomment-397015029 @mistercrunch should I put the same boto3 version in `setup.py`? Just so there's no discrepancy between the two?

[GitHub] john-bodley commented on a change in pull request #5178: [sql] Correct SQL parameter formatting

2018-06-13 Thread GitBox
john-bodley commented on a change in pull request #5178: [sql] Correct SQL parameter formatting URL: https://github.com/apache/incubator-superset/pull/5178#discussion_r195155582 ## File path: superset/models/core.py ## @@ -706,15 +703,36 @@ def

[GitHub] ledor473 opened a new pull request #5184: Pin botocore version

2018-06-12 Thread GitBox
ledor473 opened a new pull request #5184: Pin botocore version URL: https://github.com/apache/incubator-superset/pull/5184 Fixes for #5175 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] timifasubaa opened a new pull request #5194: [WIP] pass_error_message_separately

2018-06-13 Thread GitBox
timifasubaa opened a new pull request #5194: [WIP] pass_error_message_separately URL: https://github.com/apache/incubator-superset/pull/5194 This is an automated message from the Apache Git Service. To respond to the

[GitHub] Lynnlan commented on issue #2394: Metric should offer a new "Legend Name" attribute

2018-06-12 Thread GitBox
Lynnlan commented on issue #2394: Metric should offer a new "Legend Name" attribute URL: https://github.com/apache/incubator-superset/issues/2394#issuecomment-396678721 +1 This is an automated message from the Apache Git

[GitHub] codecov-io commented on issue #4727: [webpack] setup lazy loading for all visualizations

2018-06-13 Thread GitBox
codecov-io commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-395879447 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4727?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4727: [webpack] setup lazy loading for all visualizations

2018-06-13 Thread GitBox
codecov-io commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-395879447 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4727?src=pr=h1) Report > Merging

[GitHub] timifasubaa opened a new pull request #5190: [bugfix] form_data - fix empty metrics

2018-06-13 Thread GitBox
timifasubaa opened a new pull request #5190: [bugfix] form_data - fix empty metrics URL: https://github.com/apache/incubator-superset/pull/5190 It is sometimes the case that in form_data, metrics is set to null and that breaks the logic here as it expects a list or None. This PR fixes

[GitHub] codecov-io commented on issue #5190: [bugfix] form_data - fix empty metrics

2018-06-13 Thread GitBox
codecov-io commented on issue #5190: [bugfix] form_data - fix empty metrics URL: https://github.com/apache/incubator-superset/pull/5190#issuecomment-397095122 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5190?src=pr=h1) Report > Merging

[GitHub] michellethomas commented on issue #5176: Introduce class attr BaseViz.enforce_numerical_metrics

2018-06-13 Thread GitBox
michellethomas commented on issue #5176: Introduce class attr BaseViz.enforce_numerical_metrics URL: https://github.com/apache/incubator-superset/pull/5176#issuecomment-397053903 @mistercrunch this lgtm, merge? This is an

[GitHub] williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations

2018-06-13 Thread GitBox
williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-397085944 all right tests look good, should we merge @mistercrunch @graceguo-supercat @john-bodley ?

[GitHub] michellethomas commented on issue #5181: [Fix] Formula type annotation no showing up

2018-06-13 Thread GitBox
michellethomas commented on issue #5181: [Fix] Formula type annotation no showing up URL: https://github.com/apache/incubator-superset/pull/5181#issuecomment-397096089 lgtm! This is an automated message from the Apache Git

[GitHub] MTShannon commented on issue #3013: New chart type : Chord Diagrams

2018-06-12 Thread GitBox
MTShannon commented on issue #3013: New chart type : Chord Diagrams URL: https://github.com/apache/incubator-superset/pull/3013#issuecomment-396598585 Have the file locations changed? I can't find "controls.jsx" in the stores folder.

[GitHub] codecov-io commented on issue #5184: Pin botocore version

2018-06-12 Thread GitBox
codecov-io commented on issue #5184: Pin botocore version URL: https://github.com/apache/incubator-superset/pull/5184#issuecomment-396614071 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5184?src=pr=h1) Report > Merging

[GitHub] jasnovak commented on issue #4909: [Explore] Adding Adhoc Filters

2018-06-13 Thread GitBox
jasnovak commented on issue #4909: [Explore] Adding Adhoc Filters URL: https://github.com/apache/incubator-superset/pull/4909#issuecomment-397120452 @GabeLoins @john-bodley This is causing a bug with filters not being saved when visualizations are changed. specifically when switching to

[GitHub] jasnovak commented on issue #4909: [Explore] Adding Adhoc Filters

2018-06-13 Thread GitBox
jasnovak commented on issue #4909: [Explore] Adding Adhoc Filters URL: https://github.com/apache/incubator-superset/pull/4909#issuecomment-397120452 This is causing a bug with filters not being saved when visualizations are changed. specifically when switching to Table View:

[GitHub] michellethomas opened a new issue #5191: [Cleanup] Make all metrics into custom metric objects

2018-06-13 Thread GitBox
michellethomas opened a new issue #5191: [Cleanup] Make all metrics into custom metric objects URL: https://github.com/apache/incubator-superset/issues/5191 Wanted to keep track of Max's suggestion in [this](https://github.com/apache/incubator-superset/pull/5118) PR. Make all metrics fit

[GitHub] codecov-io commented on issue #5118: Adding the MetricsControl to the timeseries_limit_metric field

2018-06-13 Thread GitBox
codecov-io commented on issue #5118: Adding the MetricsControl to the timeseries_limit_metric field URL: https://github.com/apache/incubator-superset/pull/5118#issuecomment-393663808 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5118?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5118: Adding the MetricsControl to the timeseries_limit_metric field

2018-06-13 Thread GitBox
codecov-io commented on issue #5118: Adding the MetricsControl to the timeseries_limit_metric field URL: https://github.com/apache/incubator-superset/pull/5118#issuecomment-393663808 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5118?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5118: Adding the MetricsControl to the timeseries_limit_metric field

2018-06-13 Thread GitBox
codecov-io commented on issue #5118: Adding the MetricsControl to the timeseries_limit_metric field URL: https://github.com/apache/incubator-superset/pull/5118#issuecomment-393663808 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5118?src=pr=h1) Report > Merging

[GitHub] williaster commented on a change in pull request #5165: [dash builder fix] combine markdown and slice name, slice picker height

2018-06-14 Thread GitBox
williaster commented on a change in pull request #5165: [dash builder fix] combine markdown and slice name, slice picker height URL: https://github.com/apache/incubator-superset/pull/5165#discussion_r195526558 ## File path:

[GitHub] williaster commented on issue #5203: [pie-chart] Restricting query to single metric

2018-06-14 Thread GitBox
williaster commented on issue #5203: [pie-chart] Restricting query to single metric URL: https://github.com/apache/incubator-superset/pull/5203#issuecomment-397397974 LGTM  This is an automated message from the Apache Git

[GitHub] john-bodley opened a new pull request #5203: [pie-chart] Restricting query to single metric

2018-06-14 Thread GitBox
john-bodley opened a new pull request #5203: [pie-chart] Restricting query to single metric URL: https://github.com/apache/incubator-superset/pull/5203 The pie chart should only support a single metric. to: @williaster @GabeLoins @mistercrunch

[GitHub] codecov-io commented on issue #5203: [pie-chart] Restricting query to single metric

2018-06-14 Thread GitBox
codecov-io commented on issue #5203: [pie-chart] Restricting query to single metric URL: https://github.com/apache/incubator-superset/pull/5203#issuecomment-397380390 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5203?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5189: [druid] remove reliance on coordinator

2018-06-14 Thread GitBox
codecov-io commented on issue #5189: [druid] remove reliance on coordinator URL: https://github.com/apache/incubator-superset/pull/5189#issuecomment-397365458 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5189?src=pr=h1) Report > Merging

[GitHub] graceguo-supercat closed pull request #5181: [Fix] Formula type annotation no showing up

2018-06-14 Thread GitBox
graceguo-supercat closed pull request #5181: [Fix] Formula type annotation no showing up URL: https://github.com/apache/incubator-superset/pull/5181 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] mistercrunch closed pull request #5189: [druid] remove reliance on coordinator

2018-06-14 Thread GitBox
mistercrunch closed pull request #5189: [druid] remove reliance on coordinator URL: https://github.com/apache/incubator-superset/pull/5189 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] mistercrunch opened a new pull request #5189: [druid] remove reliance on coordinator

2018-06-14 Thread GitBox
mistercrunch opened a new pull request #5189: [druid] remove reliance on coordinator URL: https://github.com/apache/incubator-superset/pull/5189 It turns out all of the endpoints we use against the coordinator are also available on the broker.

[GitHub] llozanoc opened a new issue #5202: Get an error unhashable type: 'dict' in a TableView with a NUMERIC type using PostgreSQL

2018-06-14 Thread GitBox
llozanoc opened a new issue #5202: Get an error unhashable type: 'dict' in a TableView with a NUMERIC type using PostgreSQL URL: https://github.com/apache/incubator-superset/issues/5202 Make sure these boxes are checked before submitting your issue - thank you! - [x] I have checked

[GitHub] llozanoc commented on issue #5182: Changed of Date to epoch time in Table view - Superset - 0.25.6

2018-06-14 Thread GitBox
llozanoc commented on issue #5182: Changed of Date to epoch time in Table view - Superset - 0.25.6 URL: https://github.com/apache/incubator-superset/issues/5182#issuecomment-397357493 I'm having the same problem with the timestamp types and Table views This problem is reported in

[GitHub] rzlmma commented on issue #4133: BugFix(#3658)

2018-06-15 Thread GitBox
rzlmma commented on issue #4133: BugFix(#3658) URL: https://github.com/apache/incubator-superset/pull/4133#issuecomment-397572276 tanks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] rzlmma commented on issue #5190: [bugfix] form_data - fix empty metrics

2018-06-15 Thread GitBox
rzlmma commented on issue #5190: [bugfix] form_data - fix empty metrics URL: https://github.com/apache/incubator-superset/pull/5190#issuecomment-397577068 I'm more inclined to the last version, because the following code determines that it's value is an iterator.

[GitHub] codecov-io commented on issue #5184: Pin botocore version

2018-06-14 Thread GitBox
codecov-io commented on issue #5184: Pin botocore version URL: https://github.com/apache/incubator-superset/pull/5184#issuecomment-396614071 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5184?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5200: Convert dttm to utc to avoid errors with different timezones

2018-06-14 Thread GitBox
codecov-io commented on issue #5200: Convert dttm to utc to avoid errors with different timezones URL: https://github.com/apache/incubator-superset/pull/5200#issuecomment-397297146 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5200?src=pr=h1) Report > Merging

[GitHub] ledor473 commented on issue #5184: Pin botocore version

2018-06-14 Thread GitBox
ledor473 commented on issue #5184: Pin botocore version URL: https://github.com/apache/incubator-superset/pull/5184#issuecomment-397312357 Sounds good! I've updated the PR This is an automated message from the Apache Git

[GitHub] john-bodley commented on a change in pull request #5206: [adhoc-filters] Adding adhoc-filters to all viz types

2018-06-15 Thread GitBox
john-bodley commented on a change in pull request #5206: [adhoc-filters] Adding adhoc-filters to all viz types URL: https://github.com/apache/incubator-superset/pull/5206#discussion_r195625181 ## File path: superset/utils.py ## @@ -881,4 +881,3 @@ def

[GitHub] EvelynTurner opened a new pull request #5211: Evelynturner/prestofix

2018-06-15 Thread GitBox
EvelynTurner opened a new pull request #5211: Evelynturner/prestofix URL: https://github.com/apache/incubator-superset/pull/5211 Context: ``` presto> SELECT CAST(from_unixtime((1528761599980/1000.0)) AS TIMESTAMP); - 2018-06-12 00:00:00.000

[GitHub] MTShannon opened a new issue #5209: Joining druid datasources?

2018-06-15 Thread GitBox
MTShannon opened a new issue #5209: Joining druid datasources? URL: https://github.com/apache/incubator-superset/issues/5209 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and included it here

[GitHub] sbarlock opened a new issue #5210: Limit not working with Pie Chart

2018-06-15 Thread GitBox
sbarlock opened a new issue #5210: Limit not working with Pie Chart URL: https://github.com/apache/incubator-superset/issues/5210 Make sure these boxes are checked before submitting your issue - thank you! - [x ] I have checked the superset logs for python stacktraces and included

[GitHub] mistercrunch commented on issue #4327: Getting error, "Error while compiling statement: FAILED: ParseException line 3:10 mismatched input 'NOT' expecting ) near 'INT' in create table statemen

2018-06-14 Thread GitBox
mistercrunch commented on issue #4327: Getting error, "Error while compiling statement: FAILED: ParseException line 3:10 mismatched input 'NOT' expecting ) near 'INT' in create table statement URL: https://github.com/apache/incubator-superset/issues/4327#issuecomment-397434314

[GitHub] john-bodley commented on issue #5203: [pie-chart] Restricting query to single metric

2018-06-14 Thread GitBox
john-bodley commented on issue #5203: [pie-chart] Restricting query to single metric URL: https://github.com/apache/incubator-superset/pull/5203#issuecomment-397442639 @mistercrunch the [pie-chart](https://github.com/apache/incubator-superset/blob/master/superset/viz.py#L1430) simply

[GitHub] GabeLoins commented on issue #5204: [explore] fix autocomplete on verbose names

2018-06-14 Thread GitBox
GabeLoins commented on issue #5204: [explore] fix autocomplete on verbose names URL: https://github.com/apache/incubator-superset/pull/5204#issuecomment-397442676 @mistercrunch as of this PR: https://github.com/apache/incubator-superset/pull/5105 we only filter simple metrics

[GitHub] mistercrunch commented on issue #5195: [sql lab] quote schema and table name

2018-06-14 Thread GitBox
mistercrunch commented on issue #5195: [sql lab] quote schema and table name URL: https://github.com/apache/incubator-superset/pull/5195#issuecomment-397447491 Ended spending time trying to use `sqlalchemy.table` (not schema aware) and `sqlalchemy.Table` which requires `Metadata` context,

[GitHub] nedkoh commented on issue #4327: Getting error, "Error while compiling statement: FAILED: ParseException line 3:10 mismatched input 'NOT' expecting ) near 'INT' in create table statement

2018-06-14 Thread GitBox
nedkoh commented on issue #4327: Getting error, "Error while compiling statement: FAILED: ParseException line 3:10 mismatched input 'NOT' expecting ) near 'INT' in create table statement URL: https://github.com/apache/incubator-superset/issues/4327#issuecomment-397418893 That makes a lot

[GitHub] john-bodley commented on issue #5203: [pie-chart] Restricting query to single metric

2018-06-14 Thread GitBox
john-bodley commented on issue #5203: [pie-chart] Restricting query to single metric URL: https://github.com/apache/incubator-superset/pull/5203#issuecomment-397423742 @mistercruch it auto-translated correctly when I tested it. If you’re ok with oniy supporting one metric, I’ll add the

[GitHub] john-bodley commented on issue #5203: [pie-chart] Restricting query to single metric

2018-06-14 Thread GitBox
john-bodley commented on issue #5203: [pie-chart] Restricting query to single metric URL: https://github.com/apache/incubator-superset/pull/5203#issuecomment-397442639 @mistercrunch the [pie-chart](https://github.com/apache/incubator-superset/blob/master/superset/viz.py#L1430) simply

[GitHub] mistercrunch commented on issue #5203: [pie-chart] Restricting query to single metric

2018-06-14 Thread GitBox
mistercrunch commented on issue #5203: [pie-chart] Restricting query to single metric URL: https://github.com/apache/incubator-superset/pull/5203#issuecomment-397416882 I think it used to allow multiple metrics or one metric along with a groupby. People may have metrics like `boys`

[GitHub] betodealmeida commented on issue #5177: Time shift difference

2018-06-14 Thread GitBox
betodealmeida commented on issue #5177: Time shift difference URL: https://github.com/apache/incubator-superset/pull/5177#issuecomment-397443052 https://user-images.githubusercontent.com/1534870/41439178-a2bb3d54-6fde-11e8-81e6-4b1e4cbb230c.png;>

[GitHub] mistercrunch opened a new pull request #5204: [explore] fix autocomplete on verbose names

2018-06-14 Thread GitBox
mistercrunch opened a new pull request #5204: [explore] fix autocomplete on verbose names URL: https://github.com/apache/incubator-superset/pull/5204 Currently when searching for metrics or groupbys, the autocomplete search functionality only matches based on the metric_name, though in

[GitHub] mistercrunch commented on issue #4327: Getting error, "Error while compiling statement: FAILED: ParseException line 3:10 mismatched input 'NOT' expecting ) near 'INT' in create table statemen

2018-06-14 Thread GitBox
mistercrunch commented on issue #4327: Getting error, "Error while compiling statement: FAILED: ParseException line 3:10 mismatched input 'NOT' expecting ) near 'INT' in create table statement URL: https://github.com/apache/incubator-superset/issues/4327#issuecomment-397434470 We may

[GitHub] john-bodley commented on issue #5203: [pie-chart] Restricting query to single metric

2018-06-14 Thread GitBox
john-bodley commented on issue #5203: [pie-chart] Restricting query to single metric URL: https://github.com/apache/incubator-superset/pull/5203#issuecomment-397442639 @mistercrunch the [pie-chart](https://github.com/apache/incubator-superset/blob/master/superset/viz.py#L1430) simply

[GitHub] codecov-io commented on issue #5194: pass error message separately

2018-06-14 Thread GitBox
codecov-io commented on issue #5194: pass error message separately URL: https://github.com/apache/incubator-superset/pull/5194#issuecomment-397404127 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5194?src=pr=h1) Report > Merging

[GitHub] timifasubaa closed pull request #5194: pass error message separately

2018-06-14 Thread GitBox
timifasubaa closed pull request #5194: pass error message separately URL: https://github.com/apache/incubator-superset/pull/5194 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] nedkoh commented on issue #4327: Getting error, "Error while compiling statement: FAILED: ParseException line 3:10 mismatched input 'NOT' expecting ) near 'INT' in create table statement

2018-06-14 Thread GitBox
nedkoh commented on issue #4327: Getting error, "Error while compiling statement: FAILED: ParseException line 3:10 mismatched input 'NOT' expecting ) near 'INT' in create table statement URL: https://github.com/apache/incubator-superset/issues/4327#issuecomment-397406998 running into the

[GitHub] mistercrunch closed issue #4327: Getting error, "Error while compiling statement: FAILED: ParseException line 3:10 mismatched input 'NOT' expecting ) near 'INT' in create table statement

2018-06-14 Thread GitBox
mistercrunch closed issue #4327: Getting error, "Error while compiling statement: FAILED: ParseException line 3:10 mismatched input 'NOT' expecting ) near 'INT' in create table statement URL: https://github.com/apache/incubator-superset/issues/4327

[GitHub] mistercrunch commented on issue #4327: Getting error, "Error while compiling statement: FAILED: ParseException line 3:10 mismatched input 'NOT' expecting ) near 'INT' in create table statemen

2018-06-14 Thread GitBox
mistercrunch commented on issue #4327: Getting error, "Error while compiling statement: FAILED: ParseException line 3:10 mismatched input 'NOT' expecting ) near 'INT' in create table statement URL: https://github.com/apache/incubator-superset/issues/4327#issuecomment-397416010 Looks like

[GitHub] nedkoh commented on issue #4327: Getting error, "Error while compiling statement: FAILED: ParseException line 3:10 mismatched input 'NOT' expecting ) near 'INT' in create table statement

2018-06-14 Thread GitBox
nedkoh commented on issue #4327: Getting error, "Error while compiling statement: FAILED: ParseException line 3:10 mismatched input 'NOT' expecting ) near 'INT' in create table statement URL: https://github.com/apache/incubator-superset/issues/4327#issuecomment-397418893 That makes a lot

[GitHub] john-bodley commented on issue #5203: [pie-chart] Restricting query to single metric

2018-06-14 Thread GitBox
john-bodley commented on issue #5203: [pie-chart] Restricting query to single metric URL: https://github.com/apache/incubator-superset/pull/5203#issuecomment-397423742 @mistercruch it auto-translated correctly when I tested it. If you’re ok with oniy supporting one metric, I’ll add the

[GitHub] AmineTay opened a new issue #4666: Sessions still active on Datasource

2018-06-14 Thread GitBox
AmineTay opened a new issue #4666: Sessions still active on Datasource URL: https://github.com/apache/incubator-superset/issues/4666 Hello, I am contacting you concerning a problem found when using superset. We have several session still running on our datasource (Postgres

[GitHub] mistercrunch closed issue #4666: Sessions still active on Datasource

2018-06-14 Thread GitBox
mistercrunch closed issue #4666: Sessions still active on Datasource URL: https://github.com/apache/incubator-superset/issues/4666 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] AmineTay opened a new issue #4666: Sessions still active on Datasource

2018-06-14 Thread GitBox
AmineTay opened a new issue #4666: Sessions still active on Datasource URL: https://github.com/apache/incubator-superset/issues/4666 Hello, I am contacting you concerning a problem found when using superset. We have several session still running on our datasource (Postgres

[GitHub] mistercrunch commented on issue #4327: Getting error, "Error while compiling statement: FAILED: ParseException line 3:10 mismatched input 'NOT' expecting ) near 'INT' in create table statemen

2018-06-14 Thread GitBox
mistercrunch commented on issue #4327: Getting error, "Error while compiling statement: FAILED: ParseException line 3:10 mismatched input 'NOT' expecting ) near 'INT' in create table statement URL: https://github.com/apache/incubator-superset/issues/4327#issuecomment-397416406 For the

[GitHub] GabeLoins commented on a change in pull request #5204: [explore] fix autocomplete on verbose names

2018-06-14 Thread GitBox
GabeLoins commented on a change in pull request #5204: [explore] fix autocomplete on verbose names URL: https://github.com/apache/incubator-superset/pull/5204#discussion_r195575617 ## File path: superset/assets/src/explore/components/controls/MetricsControl.jsx ## @@

[GitHub] john-bodley commented on issue #5203: [pie-chart] Restricting query to single metric

2018-06-14 Thread GitBox
john-bodley commented on issue #5203: [pie-chart] Restricting query to single metric URL: https://github.com/apache/incubator-superset/pull/5203#issuecomment-397442639 @mistercrunch the [pie-chart](https://github.com/apache/incubator-superset/blob/master/superset/viz.py#L1430) simply

[GitHub] codecov-io commented on issue #5203: [pie-chart] Restricting query to single metric

2018-06-14 Thread GitBox
codecov-io commented on issue #5203: [pie-chart] Restricting query to single metric URL: https://github.com/apache/incubator-superset/pull/5203#issuecomment-397380390 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5203?src=pr=h1) Report > Merging

[GitHub] Basit-qc closed issue #5199: template_params is not being migrated in the DB

2018-06-14 Thread GitBox
Basit-qc closed issue #5199: template_params is not being migrated in the DB URL: https://github.com/apache/incubator-superset/issues/5199 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] Basit-qc commented on issue #5199: template_params is not being migrated in the DB

2018-06-14 Thread GitBox
Basit-qc commented on issue #5199: template_params is not being migrated in the DB URL: https://github.com/apache/incubator-superset/issues/5199#issuecomment-397469154 After deleting the DB and setting it up again, I got rid of the error.

[GitHub] john-bodley opened a new pull request #5206: [adhoc-filters] Adding adhoc-filters to all viz types

2018-06-14 Thread GitBox
john-bodley opened a new pull request #5206: [adhoc-filters] Adding adhoc-filters to all viz types URL: https://github.com/apache/incubator-superset/pull/5206 So this PR came about because I was working on another feature which required a database migration to update SQL filters when I

[GitHub] mistercrunch commented on issue #5204: [explore] fix autocomplete on verbose names

2018-06-14 Thread GitBox
mistercrunch commented on issue #5204: [explore] fix autocomplete on verbose names URL: https://github.com/apache/incubator-superset/pull/5204#issuecomment-397481892 Got it, let's get the ones with a `verbose_name` to show up with this PR here.

[GitHub] mistercrunch commented on issue #5204: [explore] fix autocomplete on verbose names

2018-06-14 Thread GitBox
mistercrunch commented on issue #5204: [explore] fix autocomplete on verbose names URL: https://github.com/apache/incubator-superset/pull/5204#issuecomment-397484800 @GabeLoins please review when you find a moment This is

[GitHub] mistercrunch commented on a change in pull request #5204: [explore] fix autocomplete on verbose names

2018-06-14 Thread GitBox
mistercrunch commented on a change in pull request #5204: [explore] fix autocomplete on verbose names URL: https://github.com/apache/incubator-superset/pull/5204#discussion_r195613398 ## File path: superset/assets/spec/javascripts/explore/components/MetricsControl_spec.jsx

[GitHub] michellethomas opened a new pull request #5205: Fixing issue with table viz for table with no metrics

2018-06-14 Thread GitBox
michellethomas opened a new pull request #5205: Fixing issue with table viz for table with no metrics URL: https://github.com/apache/incubator-superset/pull/5205 Fixes an issue with a table viz with no metrics. Metrics can be null. @graceguo-supercat @john-bodley @timifasubaa

[GitHub] mistercrunch commented on issue #5203: [pie-chart] Restricting query to single metric

2018-06-14 Thread GitBox
mistercrunch commented on issue #5203: [pie-chart] Restricting query to single metric URL: https://github.com/apache/incubator-superset/pull/5203#issuecomment-397484598 LGTM, sorry about the confusion. About how to deal with empty form_data or form_data key that match their

[GitHub] williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations

2018-06-14 Thread GitBox
williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-397486568 all righty 爛爛爛 This is an automated message from

[GitHub] graceguo-supercat closed pull request #5205: Fixing issue with table viz for table with no metrics

2018-06-14 Thread GitBox
graceguo-supercat closed pull request #5205: Fixing issue with table viz for table with no metrics URL: https://github.com/apache/incubator-superset/pull/5205 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] codecov-io commented on issue #5204: [explore] fix autocomplete on verbose names

2018-06-14 Thread GitBox
codecov-io commented on issue #5204: [explore] fix autocomplete on verbose names URL: https://github.com/apache/incubator-superset/pull/5204#issuecomment-397484415 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5204?src=pr=h1) Report > Merging

[GitHub] GabeLoins commented on a change in pull request #5204: [explore] fix autocomplete on verbose names

2018-06-14 Thread GitBox
GabeLoins commented on a change in pull request #5204: [explore] fix autocomplete on verbose names URL: https://github.com/apache/incubator-superset/pull/5204#discussion_r195613669 ## File path: superset/assets/src/explore/controls.jsx ## @@ -103,6 +103,10 @@ const

[GitHub] GabeLoins commented on a change in pull request #5204: [explore] fix autocomplete on verbose names

2018-06-14 Thread GitBox
GabeLoins commented on a change in pull request #5204: [explore] fix autocomplete on verbose names URL: https://github.com/apache/incubator-superset/pull/5204#discussion_r195613548 ## File path: superset/assets/spec/javascripts/explore/components/MetricsControl_spec.jsx

[GitHub] elibrumbaugh commented on issue #5208: [dashboard v2] ui + ux fixes

2018-06-15 Thread GitBox
elibrumbaugh commented on issue #5208: [dashboard v2] ui + ux fixes URL: https://github.com/apache/incubator-superset/pull/5208#issuecomment-397693881 Amazing work Chris! > adds empty drop targets at the top + bottom of + components which increase the size of the drop mouse

[GitHub] mistercrunch commented on issue #5195: [sql lab] quote schema and table name

2018-06-15 Thread GitBox
mistercrunch commented on issue #5195: [sql lab] quote schema and table name URL: https://github.com/apache/incubator-superset/pull/5195#issuecomment-397702663 @betodealmeida @john-bodley This is an automated message from

[GitHub] mistercrunch commented on a change in pull request #5204: [explore] fix autocomplete on verbose names

2018-06-15 Thread GitBox
mistercrunch commented on a change in pull request #5204: [explore] fix autocomplete on verbose names URL: https://github.com/apache/incubator-superset/pull/5204#discussion_r195821045 ## File path: superset/assets/src/explore/controls.jsx ## @@ -103,6 +103,10 @@ const

[GitHub] williaster commented on issue #5165: [dash builder fix] combine markdown and slice name, slice picker height

2018-06-15 Thread GitBox
williaster commented on issue #5165: [dash builder fix] combine markdown and slice name, slice picker height URL: https://github.com/apache/incubator-superset/pull/5165#issuecomment-397699338 @graceguo-supercat also forgot to add the wrapping of chart titles if they are added so it

[GitHub] graceguo-supercat commented on a change in pull request #5165: [dash builder fix] combine markdown and slice name, slice picker height

2018-06-15 Thread GitBox
graceguo-supercat commented on a change in pull request #5165: [dash builder fix] combine markdown and slice name, slice picker height URL: https://github.com/apache/incubator-superset/pull/5165#discussion_r195822460 ## File path:

[GitHub] graceguo-supercat closed pull request #5165: [dash builder fix] combine markdown and slice name, slice picker height

2018-06-15 Thread GitBox
graceguo-supercat closed pull request #5165: [dash builder fix] combine markdown and slice name, slice picker height URL: https://github.com/apache/incubator-superset/pull/5165 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] williaster commented on a change in pull request #5165: [dash builder fix] combine markdown and slice name, slice picker height

2018-06-15 Thread GitBox
williaster commented on a change in pull request #5165: [dash builder fix] combine markdown and slice name, slice picker height URL: https://github.com/apache/incubator-superset/pull/5165#discussion_r195841204 ## File path:

[GitHub] john-bodley commented on issue #5211: [Bug fix] Divide by 1000.000 in epoch_ms_to_dttm() to not lose precision in Presto

2018-06-15 Thread GitBox
john-bodley commented on issue #5211: [Bug fix] Divide by 1000.000 in epoch_ms_to_dttm() to not lose precision in Presto URL: https://github.com/apache/incubator-superset/pull/5211#issuecomment-397728228 @EvelynTurner I'm not sure this is necessary given that dividing an integer by a

[GitHub] graceguo-supercat opened a new pull request #5217: [CRUD] disable user change slices from dashboardmodelview

2018-06-15 Thread GitBox
graceguo-supercat opened a new pull request #5217: [CRUD] disable user change slices from dashboardmodelview URL: https://github.com/apache/incubator-superset/pull/5217 similar to #5136, disable charts dropdown list from dashboardmodelview, to improve the page load time for dashboard

<    6   7   8   9   10   11   12   13   14   15   >