[GitHub] [incubator-superset] etr2460 commented on issue #8262: [SQL Lab] Add commit to resolve query table lock

2019-09-20 Thread GitBox
etr2460 commented on issue #8262: [SQL Lab] Add commit to resolve query table lock URL: https://github.com/apache/incubator-superset/pull/8262#issuecomment-533664418 As for the autoflush, I'm not sure why we didn't disable it before, perhaps @mistercrunch can provide some insight

[GitHub] [incubator-superset] etr2460 commented on issue #8262: [SQL Lab] Add commit to resolve query table lock

2019-09-20 Thread GitBox
etr2460 commented on issue #8262: [SQL Lab] Add commit to resolve query table lock URL: https://github.com/apache/incubator-superset/pull/8262#issuecomment-533663542 I think we'd still want the previous commit in case an exception is raised in the execute function (like not allowing dml

[GitHub] [incubator-superset] etr2460 commented on issue #8262: [SQL Lab] Add commit to resolve query table lock

2019-09-20 Thread GitBox
etr2460 commented on issue #8262: [SQL Lab] Add commit to resolve query table lock URL: https://github.com/apache/incubator-superset/pull/8262#issuecomment-533651389 @villebro There is a commit prior to calling `execute_sql_statement`, but then the query object is potentially modified