graceguo-supercat opened a new pull request #8166: [feature][dashboard] Show 
filter indicator on the applicable charts when filter is open
URL: https://github.com/apache/incubator-superset/pull/8166
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   This is part of dashboard filter indicator design:
   - when user clicks on indicator, dashboard will navigate to the actual 
filter_box (done in #7908)
   - when user open options on a filter_box, the indicators in applicable 
charts should show up. (thanks for upgrade in #8115 ). See demo below:
   
   
![ZpYVaAYnhH](https://user-images.githubusercontent.com/27990562/64216097-4a4f1f80-ce6c-11e9-87ac-27063807138f.gif)
   
   This PR also fixed a couple of issue after #7908 is release:
   
   1. show ellipsis for long filter name in tooltip
   2. show color bar when filter is applied.
   3. when user clicks filter indicator, we used to outline the filter_box. 
This outline will draw user attention, but after user worked on other area in 
the dashboard, I feel it is a little annoying with outline still on the old 
filter_box. So in this PR i make the outline only on about 2 seconds, and will 
turn off by itself.
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @kristw @etr2460 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to