[GitHub] GabeLoins commented on a change in pull request #4914: [WiP] make MetricsControl the standard across visualizations

2018-05-11 Thread GitBox
GabeLoins commented on a change in pull request #4914: [WiP] make MetricsControl the standard across visualizations URL: https://github.com/apache/incubator-superset/pull/4914#discussion_r187758550 ## File path: superset/viz.py ## @@ -202,7 +222,7 @@ def query_obj(self):

[GitHub] GabeLoins commented on a change in pull request #4914: [WiP] make MetricsControl the standard across visualizations

2018-05-04 Thread GitBox
GabeLoins commented on a change in pull request #4914: [WiP] make MetricsControl the standard across visualizations URL: https://github.com/apache/incubator-superset/pull/4914#discussion_r186150357 ## File path: superset/viz.py ## @@ -90,6 +88,28 @@ def __init__(self,