mistercrunch closed pull request #4992: [Fab] cleaning up the table fab view
since Metrics Control hides autogenerated metrics
URL: https://github.com/apache/incubator-superset/pull/4992
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/connectors/sqla/views.py
b/superset/connectors/sqla/views.py
index f0f5afb79f..b73a29cbbb 100644
--- a/superset/connectors/sqla/views.py
+++ b/superset/connectors/sqla/views.py
@@ -37,12 +37,12 @@ class TableColumnInlineView(CompactCRUDMixin,
SupersetModelView): # noqa
edit_columns = [
'column_name', 'verbose_name', 'description',
'type', 'groupby', 'filterable',
- 'table', 'count_distinct', 'sum', 'min', 'max', 'expression',
+ 'table', 'expression',
'is_dttm', 'python_date_format', 'database_expression']
add_columns = edit_columns
list_columns = [
- 'column_name', 'verbose_name', 'type', 'groupby', 'filterable',
'count_distinct',
- 'sum', 'min', 'max', 'is_dttm']
+ 'column_name', 'verbose_name', 'type', 'groupby', 'filterable',
+ 'is_dttm']
page_size = 500
description_columns = {
'is_dttm': _(
@@ -86,10 +86,6 @@ class TableColumnInlineView(CompactCRUDMixin,
SupersetModelView): # noqa
'groupby': _('Groupable'),
'filterable': _('Filterable'),
'table': _('Table'),
- 'count_distinct': _('Count Distinct'),
- 'sum': _('Sum'),
- 'min': _('Min'),
- 'max': _('Max'),
'expression': _('Expression'),
'is_dttm': _('Is temporal'),
'python_date_format': _('Datetime Format'),
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
