[GitHub] [zookeeper] maoling commented on issue #940: ZOOKEEPER-3386: Add admin command to display voting view

maoling commented on issue #940: ZOOKEEPER-3386: Add admin command to display voting view URL: https://github.com/apache/zookeeper/pull/940#issuecomment-515274824 @eolivelli That's OK This is an automated message from

[GitHub] [zookeeper] TisonKun commented on issue #1023: ZOOKEEPER-3468: Enable BookKeeper checkstyle configuration on zookeeper-jute

TisonKun commented on issue #1023: ZOOKEEPER-3468: Enable BookKeeper checkstyle configuration on zookeeper-jute URL: https://github.com/apache/zookeeper/pull/1023#issuecomment-515263127 @eolivelli thanks for your review and advice. I have filed ZOOKEEPER-3469 to track such second pass.

[GitHub] [zookeeper] tdunning commented on issue #730: Zookeeper-3188: Improve resilience to network

tdunning commented on issue #730: Zookeeper-3188: Improve resilience to network URL: https://github.com/apache/zookeeper/pull/730#issuecomment-515230167 I am swamped right now and won't be able to rebase this and Dmitriy has moved on to other projects. IS there somebody else who can

[GitHub] [zookeeper] eolivelli commented on issue #632: [ZOOKEEPER-3150] Add tree digest check and verify data integrity when loading from disk

eolivelli commented on issue #632: [ZOOKEEPER-3150] Add tree digest check and verify data integrity when loading from disk URL: https://github.com/apache/zookeeper/pull/632#issuecomment-515229705 @lvfangmin would you have time to rebase, so that we can ship this great patch in 3.6.0 ?

[GitHub] [zookeeper] eolivelli commented on issue #730: Zookeeper-3188: Improve resilience to network

eolivelli commented on issue #730: Zookeeper-3188: Improve resilience to network URL: https://github.com/apache/zookeeper/pull/730#issuecomment-515229101 This is a great change, let's try to ship it with 3.6.0. The patch needs a rebase

[GitHub] [zookeeper] eolivelli commented on issue #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time

eolivelli commented on issue #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time URL: https://github.com/apache/zookeeper/pull/863#issuecomment-515228272 Let's ship this change as soon as CI is green

[GitHub] [zookeeper] eolivelli closed pull request #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time

eolivelli closed pull request #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time URL: https://github.com/apache/zookeeper/pull/863 This is an automated message from the Apache

[GitHub] [zookeeper] eolivelli commented on issue #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time

eolivelli commented on issue #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time URL: https://github.com/apache/zookeeper/pull/863#issuecomment-515227826 closing and reopeing to trigger Travis

[GitHub] [zookeeper] Lagrang opened a new pull request #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time

Lagrang opened a new pull request #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time URL: https://github.com/apache/zookeeper/pull/863 This is an automated message from the

[GitHub] [zookeeper] eolivelli commented on issue #974: ZOOKEEPER-3344:write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter and doc the usage

eolivelli commented on issue #974: ZOOKEEPER-3344:write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter and doc the usage URL: https://github.com/apache/zookeeper/pull/974#issuecomment-515227530 @nkalmar do you have cycles to review ?

[GitHub] [zookeeper] eolivelli commented on issue #922: ZOOKEEPER-3361: Add multi version of getChildren request

eolivelli commented on issue #922: ZOOKEEPER-3361: Add multi version of getChildren request URL: https://github.com/apache/zookeeper/pull/922#issuecomment-515227395 what's the status of this patch ? This is an automated

[GitHub] [zookeeper] eolivelli commented on issue #940: ZOOKEEPER-3386: Add admin command to display voting view

eolivelli commented on issue #940: ZOOKEEPER-3386: Add admin command to display voting view URL: https://github.com/apache/zookeeper/pull/940#issuecomment-515226565 @maoling what is your full name ? "Justin Mao Ling" ? I have tagged you as reviewer as "maoling " that comes from github.

[GitHub] [zookeeper] asfgit closed pull request #940: ZOOKEEPER-3386: Add admin command to display voting view

asfgit closed pull request #940: ZOOKEEPER-3386: Add admin command to display voting view URL: https://github.com/apache/zookeeper/pull/940 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] eolivelli commented on issue #973: ZOOKEEPER-3420 - Fix compatibility issue in C client recv_buffer()

eolivelli commented on issue #973: ZOOKEEPER-3420 - Fix compatibility issue in C client recv_buffer() URL: https://github.com/apache/zookeeper/pull/973#issuecomment-515225431 @phunt @anmolnar please take a look, this fix seems important

[GitHub] [zookeeper] asfgit closed pull request #995: ZOOKEEPER-3437: Improve sync throttling on a learner master

asfgit closed pull request #995: ZOOKEEPER-3437: Improve sync throttling on a learner master URL: https://github.com/apache/zookeeper/pull/995 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1023: ZOOKEEPER-3468: Enable BookKeeper checkstyle configuration on zookeeper-jute

eolivelli commented on a change in pull request #1023: ZOOKEEPER-3468: Enable BookKeeper checkstyle configuration on zookeeper-jute URL: https://github.com/apache/zookeeper/pull/1023#discussion_r307461929 ## File path:

[GitHub] [zookeeper] eolivelli commented on issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot

eolivelli commented on issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot URL: https://github.com/apache/zookeeper/pull/622#issuecomment-515164922 Try to restart the build. Click on travis page and find

[GitHub] [zookeeper] lvfangmin commented on issue #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor

lvfangmin commented on issue #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor URL: https://github.com/apache/zookeeper/pull/905#issuecomment-515149718 retest this please This is an automated message from the

[GitHub] [zookeeper] lvfangmin commented on issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot

lvfangmin commented on issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot URL: https://github.com/apache/zookeeper/pull/622#issuecomment-515135518 The Travis CI failed to build on JDK 11, looks like an

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1023: ZOOKEEPER-3468: Enable BookKeeper checkstyle configuration on zookeeper-jute

eolivelli commented on a change in pull request #1023: ZOOKEEPER-3468: Enable BookKeeper checkstyle configuration on zookeeper-jute URL: https://github.com/apache/zookeeper/pull/1023#discussion_r307259037 ## File path: zookeeper-jute/src/main/java/org/apache/jute/RecordReader.java

[GitHub] [zookeeper] TisonKun commented on a change in pull request #1023: ZOOKEEPER-3468: Enable BookKeeper checkstyle configuration on zookeeper-jute

TisonKun commented on a change in pull request #1023: ZOOKEEPER-3468: Enable BookKeeper checkstyle configuration on zookeeper-jute URL: https://github.com/apache/zookeeper/pull/1023#discussion_r307127785 ## File path:

[GitHub] [zookeeper] TisonKun commented on a change in pull request #1023: ZOOKEEPER-3468: Enable BookKeeper checkstyle configuration on zookeeper-jute

TisonKun commented on a change in pull request #1023: ZOOKEEPER-3468: Enable BookKeeper checkstyle configuration on zookeeper-jute URL: https://github.com/apache/zookeeper/pull/1023#discussion_r307128552 ## File path: zookeeper-jute/src/main/java/org/apache/jute/RecordReader.java

[GitHub] [zookeeper] TisonKun commented on a change in pull request #1023: ZOOKEEPER-3468: Enable BookKeeper checkstyle configuration on zookeeper-jute

TisonKun commented on a change in pull request #1023: ZOOKEEPER-3468: Enable BookKeeper checkstyle configuration on zookeeper-jute URL: https://github.com/apache/zookeeper/pull/1023#discussion_r307127785 ## File path:

[GitHub] [zookeeper] TisonKun commented on a change in pull request #1023: ZOOKEEPER-3468: Enable BookKeeper checkstyle configuration on zookeeper-jute

TisonKun commented on a change in pull request #1023: ZOOKEEPER-3468: Enable BookKeeper checkstyle configuration on zookeeper-jute URL: https://github.com/apache/zookeeper/pull/1023#discussion_r307127511 ## File path: