[GitHub] [zookeeper] ajingxian200 commented on a change in pull request #1084: ZOOKEEPER-3541: Wrong placeholder '{}' in logs.

ajingxian200 commented on a change in pull request #1084: ZOOKEEPER-3541: Wrong placeholder '{}' in logs. URL: https://github.com/apache/zookeeper/pull/1084#discussion_r322559780 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/client/ZooKeeperSaslClient.java

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1084: ZOOKEEPER-3541: Wrong placeholder '{}' in logs.

eolivelli commented on a change in pull request #1084: ZOOKEEPER-3541: Wrong placeholder '{}' in logs. URL: https://github.com/apache/zookeeper/pull/1084#discussion_r322558927 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/client/ZooKeeperSaslClient.java

[GitHub] [zookeeper] eolivelli commented on issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot

eolivelli commented on issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot URL: https://github.com/apache/zookeeper/pull/622#issuecomment-529777486 Sure

[GitHub] [zookeeper] lvfangmin commented on issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot

lvfangmin commented on issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot URL: https://github.com/apache/zookeeper/pull/622#issuecomment-529776872 Thanks @eolivelli @anmolnar, the build and test passed.

[GitHub] [zookeeper] ajingxian200 opened a new pull request #1084: ZOOKEEPER-3541: Wrong placeholder '{}' in logs.

ajingxian200 opened a new pull request #1084: ZOOKEEPER-3541: Wrong placeholder '{}' in logs. URL: https://github.com/apache/zookeeper/pull/1084 The placeholder '{}' in the method 'org.apache.zookeeper.client.ZooKeeperSaslClient#respondToServer' is wrong. It doesn't work.

[GitHub] [zookeeper] lvfangmin commented on issue #1083: [ZOOKEEPER-3540] Avoid client port unavailable by skip binding the same client port during reconfig

lvfangmin commented on issue #1083: [ZOOKEEPER-3540] Avoid client port unavailable by skip binding the same client port during reconfig URL: https://github.com/apache/zookeeper/pull/1083#issuecomment-529772466 Thanks @eolivelli for review, I've updated based on the check style, we could

[GitHub] [zookeeper] mcfatealan commented on issue #1077: ZOOKEEPER-3531: Synchronization on ACLCache cause cluster to hang whe…

mcfatealan commented on issue #1077: ZOOKEEPER-3531: Synchronization on ACLCache cause cluster to hang whe… URL: https://github.com/apache/zookeeper/pull/1077#issuecomment-529772062 @lvfangmin sure, I'll submit a patch for deserialize shortly after

[GitHub] [zookeeper] lvfangmin commented on issue #1077: ZOOKEEPER-3531: Synchronization on ACLCache cause cluster to hang whe…

lvfangmin commented on issue #1077: ZOOKEEPER-3531: Synchronization on ACLCache cause cluster to hang whe… URL: https://github.com/apache/zookeeper/pull/1077#issuecomment-529770379 Thanks @mcfatealan for double checking on the correctness issue, it seems correct to me, but let's have more

[GitHub] [zookeeper] asfgit closed pull request #1042: ZOOKEEPER-3484: Improve the throughput by optimizing the synchronizat…

asfgit closed pull request #1042: ZOOKEEPER-3484: Improve the throughput by optimizing the synchronizat… URL: https://github.com/apache/zookeeper/pull/1042 This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] asfgit closed pull request #1075: ZOOKEEPER-3532 Provide a docker-based environment to work on a known OS

asfgit closed pull request #1075: ZOOKEEPER-3532 Provide a docker-based environment to work on a known OS URL: https://github.com/apache/zookeeper/pull/1075 This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] asfgit closed pull request #1034: ZOOKEEPER-3491 Specify commitLogCount value using a system property

asfgit closed pull request #1034: ZOOKEEPER-3491 Specify commitLogCount value using a system property URL: https://github.com/apache/zookeeper/pull/1034 This is an automated message from the Apache Git Service. To respond

[GitHub] [zookeeper] enixon commented on issue #1045: ZOOKEEPER-3400: Add documentation on local sessions

enixon commented on issue #1045: ZOOKEEPER-3400: Add documentation on local sessions URL: https://github.com/apache/zookeeper/pull/1045#issuecomment-529659943 looks good to me thanks for improving the documentation!

[GitHub] [zookeeper] eolivelli commented on issue #1083: [ZOOKEEPER-3540] Avoid client port unavailable by skip binding the same client port during reconfig

eolivelli commented on issue #1083: [ZOOKEEPER-3540] Avoid client port unavailable by skip binding the same client port during reconfig URL: https://github.com/apache/zookeeper/pull/1083#issuecomment-529570983 @lvfangmin the change looks good to me please fix Checkstyle issues, then

[GitHub] [zookeeper] lvfangmin opened a new pull request #1083: [ZOOKEEPER-3540] Avoid client port unavailable by skip binding the same client port during reconfig

lvfangmin opened a new pull request #1083: [ZOOKEEPER-3540] Avoid client port unavailable by skip binding the same client port during reconfig URL: https://github.com/apache/zookeeper/pull/1083 This is an automated message

[GitHub] [zookeeper] nkalmar closed pull request #1082: ZOOKEEPER-3539 Fix CI for branch-3.5:

nkalmar closed pull request #1082: ZOOKEEPER-3539 Fix CI for branch-3.5: URL: https://github.com/apache/zookeeper/pull/1082 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [zookeeper] nkalmar commented on issue #1082: ZOOKEEPER-3539 Fix CI for branch-3.5:

nkalmar commented on issue #1082: ZOOKEEPER-3539 Fix CI for branch-3.5: URL: https://github.com/apache/zookeeper/pull/1082#issuecomment-529434532 Pushed to 3.5. Thanks @eolivelli This is an automated message from the Apache

[GitHub] [zookeeper] eolivelli commented on issue #1082: ZOOKEEPER-3539 Fix CI for branch-3.5:

eolivelli commented on issue #1082: ZOOKEEPER-3539 Fix CI for branch-3.5: URL: https://github.com/apache/zookeeper/pull/1082#issuecomment-529429722 @nkalmar can you please merge this patch? This is an automated message from

[GitHub] [zookeeper] nkalmar commented on issue #1078: ZOOKEEPER-3436 Enhance Mavenized Make C client

nkalmar commented on issue #1078: ZOOKEEPER-3436 Enhance Mavenized Make C client URL: https://github.com/apache/zookeeper/pull/1078#issuecomment-529359533 retest maven build This is an automated message from the Apache Git

[GitHub] [zookeeper] eolivelli commented on issue #1078: ZOOKEEPER-3436 Enhance Mavenized Make C client

eolivelli commented on issue #1078: ZOOKEEPER-3436 Enhance Mavenized Make C client URL: https://github.com/apache/zookeeper/pull/1078#issuecomment-529330202 okay. The former is obsolete. The later was not migrated during maven migration, we should file a JIRA for it good catch,