[GitHub] [zookeeper] hanm opened a new pull request #1092: ZOOKEEPER-3548: Redundant zxid check in SnapStream.isValidSnapshot.

hanm opened a new pull request #1092: ZOOKEEPER-3548: Redundant zxid check in SnapStream.isValidSnapshot. URL: https://github.com/apache/zookeeper/pull/1092 `Util.getZxidFromName` is called twice in `SnapStream.isValidSnapshot`, and the second call is redundant: there is no way the check

[GitHub] [zookeeper] asfgit closed pull request #1051: ZOOKEEPER-3503: Add server side large request throttling

asfgit closed pull request #1051: ZOOKEEPER-3503: Add server side large request throttling URL: https://github.com/apache/zookeeper/pull/1051 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] jhuan31 commented on issue #1037: ZOOKEEPER-3492: Add weights to server side connection throttling

jhuan31 commented on issue #1037: ZOOKEEPER-3492: Add weights to server side connection throttling URL: https://github.com/apache/zookeeper/pull/1037#issuecomment-531852625 For tracking purpose so I won't forget: ZOOKEEPER-3547 Add detailed documentation on throttling

[GitHub] [zookeeper] eolivelli commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton

eolivelli commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton URL: https://github.com/apache/zookeeper/pull/1064#issuecomment-531845433 Let's wait for another +1. Please @enixom @lvfangmin or @hanm take a look. We are touching lots of tests

[GitHub] [zookeeper] swallez opened a new pull request #1091: ZOOKEEPER-3546: Delete empty containers with cversion == 0 after a grace period

swallez opened a new pull request #1091: ZOOKEEPER-3546: Delete empty containers with cversion == 0 after a grace period URL: https://github.com/apache/zookeeper/pull/1091 Ensures empty containers that never had children added are deleted after a grace period. The grace period

[GitHub] [zookeeper] TisonKun commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton

TisonKun commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton URL: https://github.com/apache/zookeeper/pull/1064#issuecomment-531828454 Resolved conflicts. @anmolnar @nkalmar could you please take a look? I think this pull request is in mergeable

[GitHub] [zookeeper] nkalmar commented on issue #1090: ZOOKEEPER-3545 Fix LICENSE files for netty dependency

nkalmar commented on issue #1090: ZOOKEEPER-3545 Fix LICENSE files for netty dependency URL: https://github.com/apache/zookeeper/pull/1090#issuecomment-531719501 Merged to master and 3.5. I can't login to jira for some reason, so couldn't update the jira ticket. Thanks @eolivelli !

[GitHub] [zookeeper] asfgit closed pull request #1090: ZOOKEEPER-3545 Fix LICENSE files for netty dependency

asfgit closed pull request #1090: ZOOKEEPER-3545 Fix LICENSE files for netty dependency URL: https://github.com/apache/zookeeper/pull/1090 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] maoling commented on issue #1073: ZOOKEEPER-3529: add a new doc: zookeeperUseCases.md

maoling commented on issue #1073: ZOOKEEPER-3529: add a new doc: zookeeperUseCases.md URL: https://github.com/apache/zookeeper/pull/1073#issuecomment-531717549 @sauravhaloi Thanks for your reply. > So, I would suggest that you take a written consent from the publishers before

[GitHub] [zookeeper] sauravhaloi edited a comment on issue #1073: ZOOKEEPER-3529: add a new doc: zookeeperUseCases.md

sauravhaloi edited a comment on issue #1073: ZOOKEEPER-3529: add a new doc: zookeeperUseCases.md URL: https://github.com/apache/zookeeper/pull/1073#issuecomment-531714529 > For the book:**Apache ZooKeeper Essentials**,I have got the permission.Thanks for the Saurav Haloi's generous help

[GitHub] [zookeeper] nkalmar commented on issue #1090: ZOOKEEPER-3545 Fix LICENSE files for netty dependency

nkalmar commented on issue #1090: ZOOKEEPER-3545 Fix LICENSE files for netty dependency URL: https://github.com/apache/zookeeper/pull/1090#issuecomment-531703968 I made a clean install with the patch, all license files under the different netty jars in the final tarball. Okay to commit?