[GitHub] [zookeeper] TisonKun commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton

2019-09-17 Thread GitBox
TisonKun commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton URL: https://github.com/apache/zookeeper/pull/1064#issuecomment-532515005 Thanks for your review @hanm ! This is an automated

[GitHub] [zookeeper] maoling edited a comment on issue #1077: ZOOKEEPER-3531: Synchronization on ACLCache cause cluster to hang whe…

2019-09-17 Thread GitBox
maoling edited a comment on issue #1077: ZOOKEEPER-3531: Synchronization on ACLCache cause cluster to hang whe… URL: https://github.com/apache/zookeeper/pull/1077#issuecomment-527844340 Loking!, this weekend(at the latest:D).

[GitHub] [zookeeper] TisonKun commented on issue #1091: ZOOKEEPER-3546: Delete empty containers with cversion == 0 after a grace period

2019-09-17 Thread GitBox
TisonKun commented on issue #1091: ZOOKEEPER-3546: Delete empty containers with cversion == 0 after a grace period URL: https://github.com/apache/zookeeper/pull/1091#issuecomment-532491203 I second @maoling here that "If I create a container node which has not any children yet, it will

[GitHub] [zookeeper] swallez commented on a change in pull request #1091: ZOOKEEPER-3546: Delete empty containers with cversion == 0 after a grace period

2019-09-17 Thread GitBox
swallez commented on a change in pull request #1091: ZOOKEEPER-3546: Delete empty containers with cversion == 0 after a grace period URL: https://github.com/apache/zookeeper/pull/1091#discussion_r325136948 ## File path:

[GitHub] [zookeeper] swallez commented on a change in pull request #1091: ZOOKEEPER-3546: Delete empty containers with cversion == 0 after a grace period

2019-09-17 Thread GitBox
swallez commented on a change in pull request #1091: ZOOKEEPER-3546: Delete empty containers with cversion == 0 after a grace period URL: https://github.com/apache/zookeeper/pull/1091#discussion_r325126124 ## File path:

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1091: ZOOKEEPER-3546: Delete empty containers with cversion == 0 after a grace period

2019-09-17 Thread GitBox
eolivelli commented on a change in pull request #1091: ZOOKEEPER-3546: Delete empty containers with cversion == 0 after a grace period URL: https://github.com/apache/zookeeper/pull/1091#discussion_r325115877 ## File path:

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1091: ZOOKEEPER-3546: Delete empty containers with cversion == 0 after a grace period

2019-09-17 Thread GitBox
eolivelli commented on a change in pull request #1091: ZOOKEEPER-3546: Delete empty containers with cversion == 0 after a grace period URL: https://github.com/apache/zookeeper/pull/1091#discussion_r325116122 ## File path:

[GitHub] [zookeeper] maoling commented on issue #1091: ZOOKEEPER-3546: Delete empty containers with cversion == 0 after a grace period

2019-09-17 Thread GitBox
maoling commented on issue #1091: ZOOKEEPER-3546: Delete empty containers with cversion == 0 after a grace period URL: https://github.com/apache/zookeeper/pull/1091#issuecomment-532091523 - If I create a container node which has not any children yet, it will never be deleted by the