[GitHub] [zookeeper] TisonKun closed pull request #839: ZOOKEEPER-3290: Throw detailed KeeperException when multi-op failed

2019-09-18 Thread GitBox
TisonKun closed pull request #839: ZOOKEEPER-3290: Throw detailed KeeperException when multi-op failed URL: https://github.com/apache/zookeeper/pull/839 This is an automated message from the Apache Git Service. To respond

[GitHub] [zookeeper] TisonKun commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when multi-op failed

2019-09-18 Thread GitBox
TisonKun commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when multi-op failed URL: https://github.com/apache/zookeeper/pull/839#issuecomment-532937049 @anmolnar Thanks for your example. You're right. After some debug I notice that as you said above jute

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1045: ZOOKEEPER-3400: Add documentation on local sessions

2019-09-18 Thread GitBox
anmolnar commented on a change in pull request #1045: ZOOKEEPER-3400: Add documentation on local sessions URL: https://github.com/apache/zookeeper/pull/1045#discussion_r325746881 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperProgrammers.md ## @@ -503,6

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1045: ZOOKEEPER-3400: Add documentation on local sessions

2019-09-18 Thread GitBox
anmolnar commented on a change in pull request #1045: ZOOKEEPER-3400: Add documentation on local sessions URL: https://github.com/apache/zookeeper/pull/1045#discussion_r325745723 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperProgrammers.md ## @@ -503,6

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1045: ZOOKEEPER-3400: Add documentation on local sessions

2019-09-18 Thread GitBox
anmolnar commented on a change in pull request #1045: ZOOKEEPER-3400: Add documentation on local sessions URL: https://github.com/apache/zookeeper/pull/1045#discussion_r325742931 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md ## @@ -1151,6

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1045: ZOOKEEPER-3400: Add documentation on local sessions

2019-09-18 Thread GitBox
anmolnar commented on a change in pull request #1045: ZOOKEEPER-3400: Add documentation on local sessions URL: https://github.com/apache/zookeeper/pull/1045#discussion_r325745906 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperProgrammers.md ## @@ -503,6

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1045: ZOOKEEPER-3400: Add documentation on local sessions

2019-09-18 Thread GitBox
anmolnar commented on a change in pull request #1045: ZOOKEEPER-3400: Add documentation on local sessions URL: https://github.com/apache/zookeeper/pull/1045#discussion_r325745406 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperProgrammers.md ## @@ -503,6

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1045: ZOOKEEPER-3400: Add documentation on local sessions

2019-09-18 Thread GitBox
anmolnar commented on a change in pull request #1045: ZOOKEEPER-3400: Add documentation on local sessions URL: https://github.com/apache/zookeeper/pull/1045#discussion_r325743244 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md ## @@ -1151,6

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1045: ZOOKEEPER-3400: Add documentation on local sessions

2019-09-18 Thread GitBox
anmolnar commented on a change in pull request #1045: ZOOKEEPER-3400: Add documentation on local sessions URL: https://github.com/apache/zookeeper/pull/1045#discussion_r325743050 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md ## @@ -1151,6

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1045: ZOOKEEPER-3400: Add documentation on local sessions

2019-09-18 Thread GitBox
anmolnar commented on a change in pull request #1045: ZOOKEEPER-3400: Add documentation on local sessions URL: https://github.com/apache/zookeeper/pull/1045#discussion_r325746683 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperProgrammers.md ## @@ -503,6

[GitHub] [zookeeper] anmolnar commented on issue #1037: ZOOKEEPER-3492: Add weights to server side connection throttling

2019-09-18 Thread GitBox
anmolnar commented on issue #1037: ZOOKEEPER-3492: Add weights to server side connection throttling URL: https://github.com/apache/zookeeper/pull/1037#issuecomment-532719612 thanks @jhuan31 This is an automated message from

[GitHub] [zookeeper] nkalmar commented on issue #1088: ZOOKEEPER-3542 X509UtilTest#testClientRenegotiationFails is flaky on JDK8 + linux on machines with 2 cores

2019-09-18 Thread GitBox
nkalmar commented on issue #1088: ZOOKEEPER-3542 X509UtilTest#testClientRenegotiationFails is flaky on JDK8 + linux on machines with 2 cores URL: https://github.com/apache/zookeeper/pull/1088#issuecomment-532700824 Merged to master and almost 3.5, but it's already in 3.5. Thanks

[GitHub] [zookeeper] asfgit closed pull request #1088: ZOOKEEPER-3542 X509UtilTest#testClientRenegotiationFails is flaky on JDK8 + linux on machines with 2 cores

2019-09-18 Thread GitBox
asfgit closed pull request #1088: ZOOKEEPER-3542 X509UtilTest#testClientRenegotiationFails is flaky on JDK8 + linux on machines with 2 cores URL: https://github.com/apache/zookeeper/pull/1088 This is an automated message

[GitHub] [zookeeper] eolivelli commented on issue #1088: ZOOKEEPER-3542 X509UtilTest#testClientRenegotiationFails is flaky on JDK8 + linux on machines with 2 cores

2019-09-18 Thread GitBox
eolivelli commented on issue #1088: ZOOKEEPER-3542 X509UtilTest#testClientRenegotiationFails is flaky on JDK8 + linux on machines with 2 cores URL: https://github.com/apache/zookeeper/pull/1088#issuecomment-532694011 @nkalmar please merge Thank you

[GitHub] [zookeeper] nkalmar closed pull request #1084: ZOOKEEPER-3541: Wrong placeholder '{}' in logs.

2019-09-18 Thread GitBox
nkalmar closed pull request #1084: ZOOKEEPER-3541: Wrong placeholder '{}' in logs. URL: https://github.com/apache/zookeeper/pull/1084 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] nkalmar commented on issue #1084: ZOOKEEPER-3541: Wrong placeholder '{}' in logs.

2019-09-18 Thread GitBox
nkalmar commented on issue #1084: ZOOKEEPER-3541: Wrong placeholder '{}' in logs. URL: https://github.com/apache/zookeeper/pull/1084#issuecomment-532684810 I'm closing this in reference to the conversation above. This is an

[GitHub] [zookeeper] nkalmar commented on issue #1088: ZOOKEEPER-3542 X509UtilTest#testClientRenegotiationFails is flaky on JDK8 + linux on machines with 2 cores

2019-09-18 Thread GitBox
nkalmar commented on issue #1088: ZOOKEEPER-3542 X509UtilTest#testClientRenegotiationFails is flaky on JDK8 + linux on machines with 2 cores URL: https://github.com/apache/zookeeper/pull/1088#issuecomment-532683704 Since not much reply came, I'm fine if you commit this @eolivelli , your

[GitHub] [zookeeper] TisonKun commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton

2019-09-18 Thread GitBox
TisonKun commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton URL: https://github.com/apache/zookeeper/pull/1064#issuecomment-532605133 Thanks for your help @nkalmar ! This is an automated

[GitHub] [zookeeper] nkalmar edited a comment on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton

2019-09-18 Thread GitBox
nkalmar edited a comment on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton URL: https://github.com/apache/zookeeper/pull/1064#issuecomment-532600129 Merged to master, thanks @TisonKun ! This

[GitHub] [zookeeper] nkalmar commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton

2019-09-18 Thread GitBox
nkalmar commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton URL: https://github.com/apache/zookeeper/pull/1064#issuecomment-532600129 Merged to master, thanks @TisonKun ! Someone please update jira, looks like I locked myself out somehow

[GitHub] [zookeeper] asfgit closed pull request #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton

2019-09-18 Thread GitBox
asfgit closed pull request #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton URL: https://github.com/apache/zookeeper/pull/1064 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] ztzg commented on issue #1066: ZOOKEEPER-2282: C Client: chroot not stripped in asynchronous callbacks

2019-09-18 Thread GitBox
ztzg commented on issue #1066: ZOOKEEPER-2282: C Client: chroot not stripped in asynchronous callbacks URL: https://github.com/apache/zookeeper/pull/1066#issuecomment-532548782 Hi @phunt, @breed, @fpj, As the main authors of `zookeeper.c` I could associate a GitHub handle with,