[GitHub] [zookeeper] TisonKun commented on issue #1112: ZOOKEEPER-3571: Ensure test base directory before tests

2019-11-14 Thread GitBox
TisonKun commented on issue #1112: ZOOKEEPER-3571: Ensure test base directory before tests URL: https://github.com/apache/zookeeper/pull/1112#issuecomment-554141679 Thanks for your review and help @anmolnar @eolivelli ! This

[GitHub] [zookeeper] TisonKun commented on issue #1112: ZOOKEEPER-3571: Ensure test base directory before tests

2019-10-24 Thread GitBox
TisonKun commented on issue #1112: ZOOKEEPER-3571: Ensure test base directory before tests URL: https://github.com/apache/zookeeper/pull/1112#issuecomment-545786922 @anmolnar thanks for your review and pointing out. Will update later.

[GitHub] [zookeeper] TisonKun commented on issue #1112: ZOOKEEPER-3571: Ensure test base directory before tests

2019-10-10 Thread GitBox
TisonKun commented on issue #1112: ZOOKEEPER-3571: Ensure test base directory before tests URL: https://github.com/apache/zookeeper/pull/1112#issuecomment-540589943 @eolivelli generally speaking I checkout source code from git and build via `mvn clean install -DskipTests`. Later when I

[GitHub] [zookeeper] TisonKun commented on issue #1112: ZOOKEEPER-3571: Ensure test base directory before tests

2019-10-10 Thread GitBox
TisonKun commented on issue #1112: ZOOKEEPER-3571: Ensure test base directory before tests URL: https://github.com/apache/zookeeper/pull/1112#issuecomment-540588344 Actually I'm curious why previously CI doesn't suffer from this issue. Maybe it is my fault that I don't setup some