[GitHub] [zookeeper] anmolnar commented on pull request #2009: ZOOKEEPER-4622 Add Netty-TcNative OpenSSL Support

2023-07-03 Thread via GitHub
anmolnar commented on PR #2009: URL: https://github.com/apache/zookeeper/pull/2009#issuecomment-1619080283 ping @eolivelli @symat -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zookeeper] anmolnar commented on pull request #2009: ZOOKEEPER-4622 Add Netty-TcNative OpenSSL Support

2023-07-03 Thread via GitHub
anmolnar commented on PR #2009: URL: https://github.com/apache/zookeeper/pull/2009#issuecomment-1617563873 @eolivelli I added a netty-bom license file by simply making a copy of one of the existing netty-* licences. Hope that's okay. -- This is an automated message from the Apache Git

[GitHub] [zookeeper] anmolnar commented on pull request #2009: ZOOKEEPER-4622 Add Netty-TcNative OpenSSL Support

2023-07-02 Thread via GitHub
anmolnar commented on PR #2009: URL: https://github.com/apache/zookeeper/pull/2009#issuecomment-1616672467 Thanks. I still need to add new license file as @eolivelli requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [zookeeper] anmolnar commented on pull request #2009: ZOOKEEPER-4622 Add Netty-TcNative OpenSSL Support

2023-07-01 Thread via GitHub
anmolnar commented on PR #2009: URL: https://github.com/apache/zookeeper/pull/2009#issuecomment-1615917655 @hyperxpro Would you please review and approve the pull request if you're happy with that? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] anmolnar commented on pull request #2009: ZOOKEEPER-4622 Add Netty-TcNative OpenSSL Support

2023-06-19 Thread via GitHub
anmolnar commented on PR #2009: URL: https://github.com/apache/zookeeper/pull/2009#issuecomment-1597139618 @eolivelli @hyperxpro Ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zookeeper] anmolnar commented on pull request #2009: ZOOKEEPER-4622 Add Netty-TcNative OpenSSL Support

2023-06-15 Thread via GitHub
anmolnar commented on PR #2009: URL: https://github.com/apache/zookeeper/pull/2009#issuecomment-1593721161 Converted to draft, because a few things need to be addressed first: - New config option to force SSL provider: JDK or OpenSSL. - Cipher suites that we set in X509Util are not

[GitHub] [zookeeper] anmolnar commented on pull request #2009: ZOOKEEPER-4622 Add Netty-TcNative OpenSSL Support

2023-06-15 Thread via GitHub
anmolnar commented on PR #2009: URL: https://github.com/apache/zookeeper/pull/2009#issuecomment-1593454000 > I have sent on the mailing list some suggestions about how to declare the netty dependency (using the Netty BOM) Seen that. Thanks, great stuff. I'll try to incorporate it.