[GitHub] [zookeeper] belugabehr commented on pull request #1359: ZOOKEEPER-3837: Deprecate StringUtils Join

2020-05-21 Thread GitBox
belugabehr commented on pull request #1359: URL: https://github.com/apache/zookeeper/pull/1359#issuecomment-632095051 > I would also deprecate the split to be honest. I'm not fan of implementing something so general ourselves, especially that java already is pretty good ad string

[GitHub] [zookeeper] belugabehr commented on pull request #1359: ZOOKEEPER-3837: Deprecate StringUtils Join

2020-05-19 Thread GitBox
belugabehr commented on pull request #1359: URL: https://github.com/apache/zookeeper/pull/1359#issuecomment-630883360 > [WARNING] /home/travis/build/apache/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/admin/ZooKeeperAdmin.java:[319,24]