[GitHub] [zookeeper] kezhuw commented on pull request #1821: ZOOKEEPER-4327: Fix flaky RequestThrottlerTest.testLargeRequestThrottling

2022-06-28 Thread GitBox
kezhuw commented on PR #1821: URL: https://github.com/apache/zookeeper/pull/1821#issuecomment-1168347001 Commit message correction: `RequestThrottlerTest.testRequestThrottler:206 expected: <5> but was: <4>` should be `RequestThrottlerTest.testLargeRequestThrottling:299 expected: <5> but

[GitHub] [zookeeper] kezhuw commented on pull request #1821: ZOOKEEPER-4327: Fix flaky RequestThrottlerTest.testLargeRequestThrottling

2022-05-24 Thread GitBox
kezhuw commented on PR #1821: URL: https://github.com/apache/zookeeper/pull/1821#issuecomment-1135994300 @maoling Thank you for merging. I observed ci failure https://github.com/apache/zookeeper/runs/6568872986?check_suite_focus=true. I opened #1887 to fix it. Would it be better to open bac

[GitHub] [zookeeper] kezhuw commented on pull request #1821: ZOOKEEPER-4327: Fix flaky RequestThrottlerTest.testLargeRequestThrottling

2022-04-22 Thread GitBox
kezhuw commented on PR #1821: URL: https://github.com/apache/zookeeper/pull/1821#issuecomment-1106517947 @eolivelli @symat Shall we merge this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [zookeeper] kezhuw commented on pull request #1821: ZOOKEEPER-4327: Fix flaky RequestThrottlerTest.testLargeRequestThrottling

2022-04-02 Thread GitBox
kezhuw commented on pull request #1821: URL: https://github.com/apache/zookeeper/pull/1821#issuecomment-1086770493 I have pushed one more commit to fix `RequestThrottlerTest.testDropStaleRequests` which fails in https://github.com/apache/zookeeper/runs/5799432447?check_suite_focus=true.

[GitHub] [zookeeper] kezhuw commented on pull request #1821: ZOOKEEPER-4327: Fix flaky RequestThrottlerTest.testLargeRequestThrottling

2022-03-08 Thread GitBox
kezhuw commented on pull request #1821: URL: https://github.com/apache/zookeeper/pull/1821#issuecomment-1062510276 Ping @eolivelli @symat @maoling for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [zookeeper] kezhuw commented on pull request #1821: ZOOKEEPER-4327: Fix flaky RequestThrottlerTest.testLargeRequestThrottling

2022-02-25 Thread GitBox
kezhuw commented on pull request #1821: URL: https://github.com/apache/zookeeper/pull/1821#issuecomment-1050911640 Ping @hanm @nkalmar @ztzg @eolivelli for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U