[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1040657179 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/auth/IPAuthenticationProvider.java: ## @@ -128,4 +131,18 @@ public boolean isValid(String id) {

[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1040607436 ## zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md: ## @@ -1208,7 +1208,32 @@ property, when available, is noted below. The default value is

[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1040568525 ## zookeeper-server/src/test/java/org/apache/zookeeper/server/util/RateLimiterTest.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038390377 ## zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md: ## @@ -1208,7 +1208,32 @@ property, when available, is noted below. The default value is

[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038390377 ## zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md: ## @@ -1208,7 +1208,32 @@ property, when available, is noted below. The default value is

[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038390377 ## zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md: ## @@ -1208,7 +1208,32 @@ property, when available, is noted below. The default value is

[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038469137 ## zookeeper-server/src/test/java/org/apache/zookeeper/server/util/RateLimiterTest.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038424755 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/util/RateLimiter.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038419979 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java: ## @@ -496,6 +506,87 @@ public CommandResponse run(ZooKeeperServer zkServer, Map

[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038417361 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/StreamOutputter.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038401440 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/auth/IPAuthenticationProvider.java: ## @@ -128,4 +131,18 @@ public boolean isValid(String id) {

[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038390377 ## zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md: ## @@ -1208,7 +1208,32 @@ property, when available, is noted below. The default value is

[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1020630119 ## zookeeper-server/src/test/java/org/apache/zookeeper/server/admin/SnapshotCommandTest.java: ## @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1020629923 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/StreamOutputter.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation