[GitHub] [zookeeper] nkalmar commented on a change in pull request #1353: ZOOKEEPER-3832 ZKHostnameVerifier rejects valid certificates with subjectAltNames

2020-05-20 Thread GitBox
nkalmar commented on a change in pull request #1353: URL: https://github.com/apache/zookeeper/pull/1353#discussion_r428029871 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/ZKHostnameVerifier.java ## @@ -324,8 +324,14 @@ private static HostNameType

[GitHub] [zookeeper] nkalmar commented on a change in pull request #1353: ZOOKEEPER-3832 ZKHostnameVerifier rejects valid certificates with subjectAltNames

2020-05-19 Thread GitBox
nkalmar commented on a change in pull request #1353: URL: https://github.com/apache/zookeeper/pull/1353#discussion_r427161374 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/ZKHostnameVerifier.java ## @@ -324,8 +324,14 @@ private static HostNameType

[GitHub] [zookeeper] nkalmar commented on a change in pull request #1353: ZOOKEEPER-3832 ZKHostnameVerifier rejects valid certificates with subjectAltNames

2020-05-19 Thread GitBox
nkalmar commented on a change in pull request #1353: URL: https://github.com/apache/zookeeper/pull/1353#discussion_r427158878 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/CertificatesToPlayWith.java ## @@ -0,0 +1,569 @@ +/** + * Licensed to the

[GitHub] [zookeeper] nkalmar commented on a change in pull request #1353: ZOOKEEPER-3832 ZKHostnameVerifier rejects valid certificates with subjectAltNames

2020-05-19 Thread GitBox
nkalmar commented on a change in pull request #1353: URL: https://github.com/apache/zookeeper/pull/1353#discussion_r427156834 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/CertificatesToPlayWith.java ## @@ -0,0 +1,569 @@ +/** + * Licensed to the