[GitHub] [zookeeper] symat commented on pull request #1356: ZOOKEEPER-3829: backward compatibility fix for rolling restart without dynamic reconfig

2020-05-29 Thread GitBox
symat commented on pull request #1356: URL: https://github.com/apache/zookeeper/pull/1356#issuecomment-635796433 > What I don't understand is what does backward compatibility have to do here? By backward compatibility I meant that some rolling-restart sequences that was working

[GitHub] [zookeeper] symat commented on pull request #1356: ZOOKEEPER-3829: backward compatibility fix for rolling restart without dynamic reconfig

2020-05-26 Thread GitBox
symat commented on pull request #1356: URL: https://github.com/apache/zookeeper/pull/1356#issuecomment-633604783 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [zookeeper] symat commented on pull request #1356: ZOOKEEPER-3829: backward compatibility fix for rolling restart without dynamic reconfig

2020-05-22 Thread GitBox
symat commented on pull request #1356: URL: https://github.com/apache/zookeeper/pull/1356#issuecomment-632506926 We had some chat on slack with @shralex and I will debug where the old server's configs are propagated (last seen config or last committed config) in the case of

[GitHub] [zookeeper] symat commented on pull request #1356: ZOOKEEPER-3829: backward compatibility fix for rolling restart without dynamic reconfig

2020-05-21 Thread GitBox
symat commented on pull request #1356: URL: https://github.com/apache/zookeeper/pull/1356#issuecomment-632163372 well, this is a very good question. Ideally I would say it should be enabled with a rolling restart. I think this is how people do all static config changes in production if

[GitHub] [zookeeper] symat commented on pull request #1356: ZOOKEEPER-3829: backward compatibility fix for rolling restart without dynamic reconfig

2020-05-21 Thread GitBox
symat commented on pull request #1356: URL: https://github.com/apache/zookeeper/pull/1356#issuecomment-632032896 @lvfangmin, @fpj - I think you also might have more background knowledge around the dynamic-reconfig. Can you please take a look on this PR?

[GitHub] [zookeeper] symat commented on pull request #1356: ZOOKEEPER-3829: backward compatibility fix for rolling restart without dynamic reconfig

2020-05-19 Thread GitBox
symat commented on pull request #1356: URL: https://github.com/apache/zookeeper/pull/1356#issuecomment-630747049 @shralex , @hanm please take a look if you can! This is an automated message from the Apache Git Service. To