[GitHub] [zookeeper] symat commented on pull request #1828: ZOOKEEPER-4477: Single Kerberos ticket renewal failure can prevent all future renewals since Java 9

2022-03-01 Thread GitBox
symat commented on pull request #1828: URL: https://github.com/apache/zookeeper/pull/1828#issuecomment-1055443605 thanks! I think we should merge this to all active branches (this is not a new feature, but a bugfix which can potentially affect any ZooKeeper version running on Java9+). I al

[GitHub] [zookeeper] symat commented on pull request #1828: ZOOKEEPER-4477: Single Kerberos ticket renewal failure can prevent all future renewals since Java 9

2022-03-01 Thread GitBox
symat commented on pull request #1828: URL: https://github.com/apache/zookeeper/pull/1828#issuecomment-1055439439 @eolivelli , can I merge this change? I don't think the flaky CI failures were related this case (after commit da8aebc which was actually fixing the flakiness in the new tests

[GitHub] [zookeeper] symat commented on pull request #1828: ZOOKEEPER-4477: Single Kerberos ticket renewal failure can prevent all future renewals since Java 9

2022-03-01 Thread GitBox
symat commented on pull request #1828: URL: https://github.com/apache/zookeeper/pull/1828#issuecomment-1055290047 yeee! (I restarted again a few hours before and now we just had a fully green run) -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [zookeeper] symat commented on pull request #1828: ZOOKEEPER-4477: Single Kerberos ticket renewal failure can prevent all future renewals since Java 9

2022-02-28 Thread GitBox
symat commented on pull request #1828: URL: https://github.com/apache/zookeeper/pull/1828#issuecomment-1054316417 now c++ tests passing, but some Java tests failes (none of them SASL related): ``` [ERROR] Failures: [ERROR] RequestThrottlerTest.testGlobalOutstandingRequestTh

[GitHub] [zookeeper] symat commented on pull request #1828: ZOOKEEPER-4477: Single Kerberos ticket renewal failure can prevent all future renewals since Java 9

2022-02-28 Thread GitBox
symat commented on pull request #1828: URL: https://github.com/apache/zookeeper/pull/1828#issuecomment-1054182166 only unrelated C client test fail -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [zookeeper] symat commented on pull request #1828: ZOOKEEPER-4477: Single Kerberos ticket renewal failure can prevent all future renewals since Java 9

2022-02-26 Thread GitBox
symat commented on pull request #1828: URL: https://github.com/apache/zookeeper/pull/1828#issuecomment-1052744746 I increased a timeout, now the 5 sec ticket lifetime should hopefully give plenty of time to restart the KDC. Also I made my renewal assertion more clever, I think this was the

[GitHub] [zookeeper] symat commented on pull request #1828: ZOOKEEPER-4477: Single Kerberos ticket renewal failure can prevent all future renewals since Java 9

2022-02-26 Thread GitBox
symat commented on pull request #1828: URL: https://github.com/apache/zookeeper/pull/1828#issuecomment-1052722864 interesting... it constantly passed for me with some older java 11 versions, but it is flaky on the java 11.0.14 we use in CI. The fix itself should be harmless, I think we hav

[GitHub] [zookeeper] symat commented on pull request #1828: ZOOKEEPER-4477: Single Kerberos ticket renewal failure can prevent all future renewals since Java 9

2022-02-26 Thread GitBox
symat commented on pull request #1828: URL: https://github.com/apache/zookeeper/pull/1828#issuecomment-1052698713 hmm... one of my KerberosTicketRenewalTest failed on java11. (I tested locally on java8 and java13) I'll have to dig into the problem. -- This is an automated message from th

[GitHub] [zookeeper] symat commented on pull request #1828: ZOOKEEPER-4477: Single Kerberos ticket renewal failure can prevent all future renewals since Java 9

2022-02-25 Thread GitBox
symat commented on pull request #1828: URL: https://github.com/apache/zookeeper/pull/1828#issuecomment-1051042297 I plan to cherry-pick this to all active branches. (expecting that we will need some minor change on branch-3.5, due to the different JUnit version) -- This is an automated m