[GitHub] [zookeeper] tisonkun commented on a diff in pull request #2024: ZOOKEEPER-4714: Improve syncRequestProcessor performance

2023-07-17 Thread via GitHub
tisonkun commented on code in PR #2024: URL: https://github.com/apache/zookeeper/pull/2024#discussion_r1264964409 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java: ## @@ -181,8 +182,7 @@ public byte[] getSerializeData() { try {

[GitHub] [zookeeper] tisonkun commented on a diff in pull request #2024: ZOOKEEPER-4714: Improve syncRequestProcessor performance

2023-07-07 Thread via GitHub
tisonkun commented on code in PR #2024: URL: https://github.com/apache/zookeeper/pull/2024#discussion_r1256922951 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnLog.java: ## @@ -289,22 +297,25 @@ public synchronized boolean append(TxnHeader

[GitHub] [zookeeper] tisonkun commented on a diff in pull request #2024: ZOOKEEPER-4714: Improve syncRequestProcessor performance

2023-07-07 Thread via GitHub
tisonkun commented on code in PR #2024: URL: https://github.com/apache/zookeeper/pull/2024#discussion_r1256905019 ## zookeeper-jute/src/main/java/org/apache/jute/BinaryOutputArchive.java: ## @@ -108,18 +116,22 @@ public void writeString(String s, String tag) throws IOException

[GitHub] [zookeeper] tisonkun commented on a diff in pull request #2024: ZOOKEEPER-4714: Improve syncRequestProcessor performance

2023-07-07 Thread via GitHub
tisonkun commented on code in PR #2024: URL: https://github.com/apache/zookeeper/pull/2024#discussion_r1256894529 ## zookeeper-jute/src/main/java/org/apache/jute/BinaryOutputArchive.java: ## @@ -108,18 +116,22 @@ public void writeString(String s, String tag) throws IOException