sonymoon commented on a change in pull request #769: ZOOKEEPER-3242: Add server
side connecting throttling
URL: https://github.com/apache/zookeeper/pull/769#discussion_r314345629
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/BlueThrottle.java
##
ztzg opened a new pull request #1055: ZOOKEEPER-3510: Make 'zkServer.sh stop'
more reliable
URL: https://github.com/apache/zookeeper/pull/1055
As mentioned in
https://github.com/apache/zookeeper/pull/1054#discussion_r314208678 :
There is a `sleep 3` statement in `zkServer.sh
nkalmar commented on issue #1046: 2019/08/08
URL: https://github.com/apache/zookeeper/pull/1046#issuecomment-521569551
I'm closing this - no jira number, no description, cfg files, comments not
in english and no clear intent.
Please create a jira if you would like to commit something,
ztzg commented on a change in pull request #1054: ZOOKEEPER-1112: Add support
for C client for SASL authentication
URL: https://github.com/apache/zookeeper/pull/1054#discussion_r314209362
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/util/SecurityUtils.java
ztzg commented on a change in pull request #1054: ZOOKEEPER-1112: Add support
for C client for SASL authentication
URL: https://github.com/apache/zookeeper/pull/1054#discussion_r314208678
##
File path: bin/zkServer.sh
##
@@ -212,6 +212,7 @@ stop)
else
$KILL
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314411673
##
File path:
eolivelli commented on issue #993: Enhance Mavenized Make C client
URL: https://github.com/apache/zookeeper/pull/993#issuecomment-521726503
@phunt PTAL
This is an automated message from the Apache Git Service.
To respond to
TisonKun commented on issue #1049: ZOOKEEPER-3475 Enable Checkstyle
configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#issuecomment-521729375
Line breaks, i.e., confusing line formats request changed above, suffer from
lack usage of local variables, which
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314364487
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314404109
##
File path:
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314404402
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/ZookeeperBanner.java
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314412010
##
File path:
mayawang commented on a change in pull request #984: ZOOKEEPER-3427: Introduce
SnapshotComparer that assists debugging with snapshots.
URL: https://github.com/apache/zookeeper/pull/984#discussion_r314432989
##
File path:
mayawang commented on issue #984: ZOOKEEPER-3427: Introduce SnapshotComparer
that assists debugging with snapshots.
URL: https://github.com/apache/zookeeper/pull/984#issuecomment-521741636
> @hanm Pull requests ownership cannot be changed. You can grant write
access for your fork and
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314188638
##
File path:
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314188240
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314292174
##
File path:
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314190876
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/ZookeeperBanner.java
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314189868
##
File path:
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314287338
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314188139
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314189651
##
File path:
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314365190
##
File path:
anmolnar commented on a change in pull request #1048: ZOOKEEPER-3188: Improve
resilience to network
URL: https://github.com/apache/zookeeper/pull/1048#discussion_r314410325
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java
##
@@
TisonKun commented on issue #1049: ZOOKEEPER-3475 Enable Checkstyle
configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#issuecomment-521730229
Also there is a pain multiple log format which also make formatting harder.
I would propose a best effort on the
TisonKun edited a comment on issue #1049: ZOOKEEPER-3475 Enable Checkstyle
configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#issuecomment-521730229
Also it is a pain to handle multiple log formats which also make formatting
harder. I would propose a best
TisonKun edited a comment on issue #1049: ZOOKEEPER-3475 Enable Checkstyle
configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#issuecomment-521730229
Also it is a pain to handle multiple log formats which also make formatting
harder. I would propose a best
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314394741
##
File path:
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314396217
##
File path:
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314395631
##
File path:
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314392692
##
File path:
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314390603
##
File path:
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314395393
##
File path:
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314395460
##
File path:
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314392789
##
File path:
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314395895
##
File path:
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314394619
##
File path:
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314395112
##
File path:
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314392431
##
File path:
symat opened a new pull request #1056: ZOOKEEPER-3495: fix SnapshotDigestTest
to work with JDK12+
URL: https://github.com/apache/zookeeper/pull/1056
The problem with the test `SnapshotDigestTest.testDifferentDigestVersion`
was that it used reflection to change a final static value in
eolivelli commented on a change in pull request #1056: ZOOKEEPER-3495: fix
SnapshotDigestTest to work with JDK12+
URL: https://github.com/apache/zookeeper/pull/1056#discussion_r314412180
##
File path:
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314397411
##
File path:
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314401708
##
File path:
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314405124
##
File path:
anmolnar commented on issue #984: ZOOKEEPER-3427: Introduce SnapshotComparer
that assists debugging with snapshots.
URL: https://github.com/apache/zookeeper/pull/984#issuecomment-521724747
@hanm Pull requests ownership cannot be changed. You can grant write access
for your fork and he'll
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314416189
##
File path:
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314416189
##
File path:
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314458370
##
File path:
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314479796
##
File path:
TisonKun removed a comment on issue #1049: ZOOKEEPER-3475 Enable Checkstyle
configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#issuecomment-521730229
Also it is a pain to handle multiple log formats which also make formatting
harder. I would propose a
eolivelli commented on issue #1049: ZOOKEEPER-3475 Enable Checkstyle
configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#issuecomment-521763584
I think we are on our way.
Ping me when you are done
If the other guys (@hanm @enixon) that started a
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314479796
##
File path:
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314479796
##
File path:
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314479796
##
File path:
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314479796
##
File path:
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314479796
##
File path:
hanm commented on issue #1049: ZOOKEEPER-3475 Enable Checkstyle configuration
on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#issuecomment-521849325
reviewing, feedback on the way.
This is an automated
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314580742
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314580611
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
hanm commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314553232
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
hanm commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314555258
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314581508
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314554375
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
hanm commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314574017
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java
##
hanm commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314574170
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooDefs.java
##
hanm commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314573903
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/Watcher.java
##
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314580886
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooDefs.java
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314580611
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314581323
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/Watcher.java
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314588183
##
File path:
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314591200
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314588811
##
File path:
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314588811
##
File path:
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314588414
##
File path:
74 matches
Mail list logo