[GitHub] [zookeeper] symat commented on a change in pull request #1251: ZOOKEEPER-3720: Fix rolling upgrade failure (invalid protocol version)

2020-02-13 Thread GitBox
symat commented on a change in pull request #1251: ZOOKEEPER-3720: Fix rolling upgrade failure (invalid protocol version) URL: https://github.com/apache/zookeeper/pull/1251#discussion_r378790887 ## File path:

[GitHub] [zookeeper] symat commented on a change in pull request #1251: ZOOKEEPER-3720: Fix rolling upgrade failure (invalid protocol version)

2020-02-13 Thread GitBox
symat commented on a change in pull request #1251: ZOOKEEPER-3720: Fix rolling upgrade failure (invalid protocol version) URL: https://github.com/apache/zookeeper/pull/1251#discussion_r378790887 ## File path:

[GitHub] [zookeeper] symat commented on issue #1251: ZOOKEEPER-3720: Fix rolling upgrade failure (invalid protocol version)

2020-02-13 Thread GitBox
symat commented on issue #1251: ZOOKEEPER-3720: Fix rolling upgrade failure (invalid protocol version) URL: https://github.com/apache/zookeeper/pull/1251#issuecomment-585704893 @ztzg thanks for checking! This is an automated

[GitHub] [zookeeper] symat commented on a change in pull request #1251: ZOOKEEPER-3720: Fix rolling upgrade failure (invalid protocol version)

2020-02-13 Thread GitBox
symat commented on a change in pull request #1251: ZOOKEEPER-3720: Fix rolling upgrade failure (invalid protocol version) URL: https://github.com/apache/zookeeper/pull/1251#discussion_r378790887 ## File path:

[GitHub] [zookeeper] vtyulb opened a new pull request #1252: ZOOKEEPER-3726: invalid ipv6 address comparison

2020-02-13 Thread GitBox
vtyulb opened a new pull request #1252: ZOOKEEPER-3726: invalid ipv6 address comparison URL: https://github.com/apache/zookeeper/pull/1252 Fix for https://issues.apache.org/jira/browse/ZOOKEEPER-3726 sockaddr_storage can contain ipv4 or ipv6 address. If address is ipv6, then we

[GitHub] [zookeeper] maoling commented on issue #1187: ZOOKEEPER-3414 sync api throws NoNodeException when path is non-existent

2020-02-13 Thread GitBox
maoling commented on issue #1187: ZOOKEEPER-3414 sync api throws NoNodeException when path is non-existent URL: https://github.com/apache/zookeeper/pull/1187#issuecomment-586071706 > I had the assumption of this should be implemented on server side. There's no guarantee of somebody not

[GitHub] [zookeeper] maoling commented on issue #1194: ZOOKEEPER-3659 Make WatchManagerFactory log more readable

2020-02-13 Thread GitBox
maoling commented on issue #1194: ZOOKEEPER-3659 Make WatchManagerFactory log more readable URL: https://github.com/apache/zookeeper/pull/1194#issuecomment-586077668 @anmolnar > Is it possible to use different WatchManagers for child and data watches? Could you please give