[GitHub] [zookeeper] tisonkun commented on pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests

tisonkun commented on pull request #1826: URL: https://github.com/apache/zookeeper/pull/1826#issuecomment-1054376142 @symat I think master is enough. This change is enhancement and normally we pick bugfix only. Also I don't need it for any previous releases but for polishing the codebase.

[GitHub] [zookeeper] asfgit closed pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests

asfgit closed pull request #1826: URL: https://github.com/apache/zookeeper/pull/1826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zookeeper] symat commented on pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests

symat commented on pull request #1826: URL: https://github.com/apache/zookeeper/pull/1826#issuecomment-1054372551 sure, I'm merging it now. Master branch is enough? Or should I cherry-pick? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zookeeper] eolivelli commented on pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests

eolivelli commented on pull request #1826: URL: https://github.com/apache/zookeeper/pull/1826#issuecomment-1054375299 Master is enough. We aren't going to commit possible breaking changes to release branches -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [zookeeper] symat commented on pull request #1828: ZOOKEEPER-4477: Single Kerberos ticket renewal failure can prevent all future renewals since Java 9

symat commented on pull request #1828: URL: https://github.com/apache/zookeeper/pull/1828#issuecomment-1054316417 now c++ tests passing, but some Java tests failes (none of them SASL related): ``` [ERROR] Failures: [ERROR]

[GitHub] [zookeeper] eolivelli commented on pull request #1828: ZOOKEEPER-4477: Single Kerberos ticket renewal failure can prevent all future renewals since Java 9

eolivelli commented on pull request #1828: URL: https://github.com/apache/zookeeper/pull/1828#issuecomment-1054231577 I have restarted the job -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zookeeper] tisonkun commented on pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests

tisonkun commented on pull request #1826: URL: https://github.com/apache/zookeeper/pull/1826#issuecomment-1054369998 @symat Thanks for your review! May you or @eolivelli help on merging this PR? I'm going to prepare a patch achieving the original proposal on connect request codec. --

[GitHub] [zookeeper] deko2369 opened a new pull request #1831: Updated programmer docs for generating jute files

deko2369 opened a new pull request #1831: URL: https://github.com/apache/zookeeper/pull/1831 Changes: * Updated programmer docs to build Zookeeper C client -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [zookeeper] symat commented on pull request #1828: ZOOKEEPER-4477: Single Kerberos ticket renewal failure can prevent all future renewals since Java 9

symat commented on pull request #1828: URL: https://github.com/apache/zookeeper/pull/1828#issuecomment-1054182166 only unrelated C client test fail -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [zookeeper] symat opened a new pull request #1830: ZOOKEEPER-4477: Single Kerberos ticket renewal failure can prevent all future renewals since Java 9

symat opened a new pull request #1830: URL: https://github.com/apache/zookeeper/pull/1830 This is the ZOOKEEPER-4477 patch for branch-3.5. Similar to the same fix on newer branches but using junit 4 in the tests (the junit upgrade happened in ZooKeeper 3.6). This bug is similar

[GitHub] [zookeeper] tisonkun commented on a change in pull request #1832: ZOOKEEPER-XXXX: Merge readOnly field into Connect{Request|Response}

tisonkun commented on a change in pull request #1832: URL: https://github.com/apache/zookeeper/pull/1832#discussion_r816437386 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxn.java ## @@ -62,13 +62,6 @@ private Set authInfo =

[GitHub] [zookeeper] tisonkun opened a new pull request #1832: ZOOKEEPER-XXXX: Merge readOnly field into Connect{Request|Response}

tisonkun opened a new pull request #1832: URL: https://github.com/apache/zookeeper/pull/1832 Signed-off-by: tison -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [zookeeper] tisonkun commented on a change in pull request #1832: ZOOKEEPER-XXXX: Merge readOnly field into Connect{Request|Response}

tisonkun commented on a change in pull request #1832: URL: https://github.com/apache/zookeeper/pull/1832#discussion_r816424802 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxn.java ## @@ -62,13 +62,6 @@ private Set authInfo =

[GitHub] [zookeeper] tisonkun commented on a change in pull request #1832: ZOOKEEPER-XXXX: Merge readOnly field into Connect{Request|Response}

tisonkun commented on a change in pull request #1832: URL: https://github.com/apache/zookeeper/pull/1832#discussion_r816424802 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxn.java ## @@ -62,13 +62,6 @@ private Set authInfo =

[GitHub] [zookeeper] tisonkun commented on a change in pull request #1832: ZOOKEEPER-XXXX: Merge readOnly field into Connect{Request|Response}

tisonkun commented on a change in pull request #1832: URL: https://github.com/apache/zookeeper/pull/1832#discussion_r816424802 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxn.java ## @@ -62,13 +62,6 @@ private Set authInfo =

[GitHub] [zookeeper] iamgd67 commented on pull request #1818: ZOOKEEPER-4473: zooInspector root child creates fail with path validate fix

iamgd67 commented on pull request #1818: URL: https://github.com/apache/zookeeper/pull/1818#issuecomment-1054929299 ping @symat for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the