[GitHub] [zookeeper] edwin092 commented on pull request #1866: ZOOKEEPER-4532: Bump jetty to 9.4.46.v20220331(avoids CVE-2022-22965)

2022-09-23 Thread GitBox
edwin092 commented on PR #1866: URL: https://github.com/apache/zookeeper/pull/1866#issuecomment-1256007309 Will this get merged? I see [ZOOKEEPER-4599](https://issues.apache.org/jira/browse/ZOOKEEPER-4599) reported also for CVE-2022-2048 on the current Jetty version. -- This is an

[GitHub] [zookeeper] jonmv commented on pull request #1925: ZOOKEEPER-4541 Ephemeral znode owned by closed session visible in 1 of 3 servers

2022-09-23 Thread GitBox
jonmv commented on PR #1925: URL: https://github.com/apache/zookeeper/pull/1925#issuecomment-1256258545 @hanm I believe you review a [related PR](https://github.com/apache/zookeeper/pull/1224) earlier, so perhaps you're the right reviewer here as well? -- This is an automated message

[GitHub] [zookeeper] eolivelli commented on pull request #1925: ZOOKEEPER-4541 Ephemeral znode owned by closed session visible in 1 of 3 servers

2022-09-23 Thread GitBox
eolivelli commented on PR #1925: URL: https://github.com/apache/zookeeper/pull/1925#issuecomment-1256261407 I don't know why I cannot add @hanm as "reviewer", btw I hope he will receive the notification -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] mpolden commented on a diff in pull request #1925: ZOOKEEPER-4541 Ephemeral znode owned by closed session visible in 1 of 3 servers

2022-09-23 Thread GitBox
mpolden commented on code in PR #1925: URL: https://github.com/apache/zookeeper/pull/1925#discussion_r978717753 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/SendAckRequestProcessor.java: ## @@ -64,7 +66,8 @@ public void flush() throws IOException {

[GitHub] [zookeeper] jonmv opened a new pull request, #1925: Jonmv/zookeeper 4541

2022-09-23 Thread GitBox
jonmv opened a new pull request, #1925: URL: https://github.com/apache/zookeeper/pull/1925 This fixes two bugs in shutdown logic, in the zookeeper server. 1. The `SendAckRequestProcessor` may die when attempting to close its `Learner` owner's socket, to signal that something went

[GitHub] [zookeeper] jonmv commented on a diff in pull request #1925: ZOOKEEPER-4541 Ephemeral znode owned by closed session visible in 1 of 3 servers

2022-09-23 Thread GitBox
jonmv commented on code in PR #1925: URL: https://github.com/apache/zookeeper/pull/1925#discussion_r978805671 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/SendAckRequestProcessor.java: ## @@ -64,7 +65,8 @@ public void flush() throws IOException {

[GitHub] [zookeeper] jonmv commented on a diff in pull request #1925: ZOOKEEPER-4541 Ephemeral znode owned by closed session visible in 1 of 3 servers

2022-09-23 Thread GitBox
jonmv commented on code in PR #1925: URL: https://github.com/apache/zookeeper/pull/1925#discussion_r978806218 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/SendAckRequestProcessor.java: ## @@ -64,7 +66,8 @@ public void flush() throws IOException {

[GitHub] [zookeeper] jonmv commented on pull request #1925: ZOOKEEPER-4541 Ephemeral znode owned by closed session visible in 1 of 3 servers

2022-09-23 Thread GitBox
jonmv commented on PR #1925: URL: https://github.com/apache/zookeeper/pull/1925#issuecomment-1256364188 > LGTM > > Great work. Did you experiment this fix in some test environment ? Not yet, but we may do that before we merge, if you wish. We will find a way to run a patched

[GitHub] [zookeeper] jonmv commented on pull request #1925: ZOOKEEPER-4541 Ephemeral znode owned by closed session visible in 1 of 3 servers

2022-09-23 Thread GitBox
jonmv commented on PR #1925: URL: https://github.com/apache/zookeeper/pull/1925#issuecomment-1256365917 Thanks for the quick reply! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific