sonatype-lift[bot] commented on code in PR #1943:
URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1040662947
##
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java:
##
@@ -1744,6 +1744,42 @@ public boolean deserializeZxidDigest(InputArchive
eolivelli commented on PR #1943:
URL: https://github.com/apache/zookeeper/pull/1943#issuecomment-1339127494
@li4wang I have restarted CI
We will commit to master branch as soon as CI passes
thanks!
looking forward for the next patch
--
This is an automated message from
li4wang commented on PR #1943:
URL: https://github.com/apache/zookeeper/pull/1943#issuecomment-1338977186
@anmolnar thanks for the additional comments. They have been addressed.
Would you mind taking a look at them? Thanks
--
This is an automated message from the Apache Git Service.
To
eolivelli commented on PR #1943:
URL: https://github.com/apache/zookeeper/pull/1943#issuecomment-1340007866
It looks like we have a problem with the C client unrelated to this patch.
Maybe on the CI machines GH upgraded some tools.
I will take a look tomorrow.
If you want
cnauroth commented on PR #1941:
URL: https://github.com/apache/zookeeper/pull/1941#issuecomment-1339760270
@Ghatage , also, I'd like to assign Apache JIRA Issue
[ZOOKEEPER-4627](https://issues.apache.org/jira/browse/ZOOKEEPER-4627) to you.
Do you have an Apache JIRA account? If not, I can
li4wang commented on PR #1943:
URL: https://github.com/apache/zookeeper/pull/1943#issuecomment-1339929737
> +1 Thanks for taking the time.
@anmolnar thanks a lot for your inputs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
li4wang commented on PR #1943:
URL: https://github.com/apache/zookeeper/pull/1943#issuecomment-1339932034
> @li4wang I have restarted CI We will commit to master branch as soon as CI
passes
>
> thanks!
>
> looking forward for the next patch
Thanks a lot @eolivelli! I
li4wang commented on code in PR #1943:
URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1040657179
##
zookeeper-server/src/main/java/org/apache/zookeeper/server/auth/IPAuthenticationProvider.java:
##
@@ -128,4 +131,18 @@ public boolean isValid(String id) {
