[GitHub] [zookeeper] jonmv commented on pull request #1925: ZOOKEEPER-4541 Ephemeral znode owned by closed session visible in 1 of 3 servers

2023-02-03 Thread via GitHub
jonmv commented on PR #1925: URL: https://github.com/apache/zookeeper/pull/1925#issuecomment-1415721176 > As a meta note, I wonder if it's worth splitting this PR into multiple PRs because it fixes distinct bugs (ZOOKEEPER-4409, ZOOKEEPER-4502, ZOOKEEPER-4394, ZOOKEEPER-4541). Likely not

[GitHub] [zookeeper] jonmv commented on a diff in pull request #1925: ZOOKEEPER-4541 Ephemeral znode owned by closed session visible in 1 of 3 servers

2023-02-03 Thread via GitHub
jonmv commented on code in PR #1925: URL: https://github.com/apache/zookeeper/pull/1925#discussion_r1095682994 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java: ## @@ -543,35 +543,150 @@ protected long registerWithLeader(int pktType) throws

[GitHub] [zookeeper] hboutemy commented on a diff in pull request #1969: ZOOKEEPER-4657: Publish SBOM artifacts

2023-02-03 Thread via GitHub
hboutemy commented on code in PR #1969: URL: https://github.com/apache/zookeeper/pull/1969#discussion_r1096497728 ## pom.xml: ## @@ -918,6 +918,11 @@ maven-bundle-plugin 5.1.1 + + org.cyclonedx + cyclonedx-maven-plugin +