[GitHub] [zookeeper] kezhuw closed pull request #1998: ZOOKEEPER-4471: Match removing WatcherType to standard, persistent modes

kezhuw closed pull request #1998: ZOOKEEPER-4471: Match removing WatcherType to standard, persistent modes URL: https://github.com/apache/zookeeper/pull/1998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [zookeeper] kezhuw commented on pull request #1998: ZOOKEEPER-4471: Match removing WatcherType to standard, persistent modes

kezhuw commented on PR #1998: URL: https://github.com/apache/zookeeper/pull/1998#issuecomment-1589071434 This is the link to previous ci run, the cpp tests hang for almost 5 hours. https://github.com/apache/zookeeper/actions/runs/5251856628/jobs/9487231863 -- This is an automated

[GitHub] [zookeeper] kezhuw closed pull request #2006: ZOOKEEPER-4472: Remove persistent watches individually

kezhuw closed pull request #2006: ZOOKEEPER-4472: Remove persistent watches individually URL: https://github.com/apache/zookeeper/pull/2006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zookeeper] kezhuw commented on pull request #2006: ZOOKEEPER-4472: Remove persistent watches individually

kezhuw commented on PR #2006: URL: https://github.com/apache/zookeeper/pull/2006#issuecomment-1589252656 [ReadOnlyModeTest.testConnectionEvents](https://github.com/apache/zookeeper/actions/runs/5254833209/jobs/9493940619?pr=2006#step:7:1009) failed. There are candidates to fix this #1667

[GitHub] [zookeeper] tisonkun commented on pull request #1998: ZOOKEEPER-4471: Match removing WatcherType to standard, persistent modes

tisonkun commented on PR #1998: URL: https://github.com/apache/zookeeper/pull/1998#issuecomment-1589289550 I think it's good to go. Merging... Thanks for your contribution @kezhuw! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [zookeeper] tisonkun merged pull request #1998: ZOOKEEPER-4471: Match removing WatcherType to standard, persistent modes

tisonkun merged PR #1998: URL: https://github.com/apache/zookeeper/pull/1998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zookeeper] kezhuw commented on pull request #1998: ZOOKEEPER-4471: Match removing WatcherType to standard, persistent modes

kezhuw commented on PR #1998: URL: https://github.com/apache/zookeeper/pull/1998#issuecomment-1589280448 All checks are green. Can we merge this and move forward to #2006 ? @eolivelli @tisonkun -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] kezhuw commented on pull request #1998: ZOOKEEPER-4471: Match removing WatcherType to standard, persistent modes

kezhuw commented on PR #1998: URL: https://github.com/apache/zookeeper/pull/1998#issuecomment-1589069167 Great! Thank you for reviewing! @tisonkun @eolivelli The cpp tests hang, I will reopen this pr for another ci run. -- This is an automated message from the Apache Git Service.

[GitHub] [zookeeper] kezhuw closed pull request #1998: ZOOKEEPER-4471: Match removing WatcherType to standard, persistent modes

kezhuw closed pull request #1998: ZOOKEEPER-4471: Match removing WatcherType to standard, persistent modes URL: https://github.com/apache/zookeeper/pull/1998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [zookeeper] tisonkun commented on a diff in pull request #2006: ZOOKEEPER-4472: Remove persistent watches individually

tisonkun commented on code in PR #2006: URL: https://github.com/apache/zookeeper/pull/2006#discussion_r1228402918 ## zookeeper-server/src/main/java/org/apache/zookeeper/ZKWatchManager.java: ## @@ -225,18 +237,6 @@ void containsWatcher(String path, Watcher watcher,

[GitHub] [zookeeper] kezhuw commented on a diff in pull request #2006: ZOOKEEPER-4472: Remove persistent watches individually

kezhuw commented on code in PR #2006: URL: https://github.com/apache/zookeeper/pull/2006#discussion_r1228921954 ## zookeeper-server/src/main/java/org/apache/zookeeper/ZKWatchManager.java: ## @@ -225,18 +237,6 @@ void containsWatcher(String path, Watcher watcher,

[GitHub] [zookeeper] kezhuw commented on a diff in pull request #2006: ZOOKEEPER-4472: Remove persistent watches individually

kezhuw commented on code in PR #2006: URL: https://github.com/apache/zookeeper/pull/2006#discussion_r1228953716 ## zookeeper-server/src/main/java/org/apache/zookeeper/ZKWatchManager.java: ## @@ -225,18 +237,6 @@ void containsWatcher(String path, Watcher watcher,