[GitHub] [zookeeper] anmolnar opened a new pull request, #2011: ZOOKEEPER-4705 Restrict GitHub merge button to allow squash commit only

anmolnar opened a new pull request, #2011: URL: https://github.com/apache/zookeeper/pull/2011 Target branches: branch-3.7, branch-3.8, master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zookeeper] eolivelli commented on pull request #2011: ZOOKEEPER-4705 Restrict GitHub merge button to allow squash commit only

eolivelli commented on PR #2011: URL: https://github.com/apache/zookeeper/pull/2011#issuecomment-1594725377 closed/opened in order to trigger CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [zookeeper] anmolnar merged pull request #1950: ZOOKEEPER-4655: Communicate the Zxid that triggered a WatchEvent to fire

anmolnar merged PR #1950: URL: https://github.com/apache/zookeeper/pull/1950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zookeeper] eolivelli commented on pull request #2011: ZOOKEEPER-4705 Restrict GitHub merge button to allow squash commit only

eolivelli commented on PR #2011: URL: https://github.com/apache/zookeeper/pull/2011#issuecomment-1594482857 I think that we have to commit this only on the default branch ("master" in our case) @ctubbsii -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [zookeeper] kezhuw commented on pull request #2012: hotfix: Fix testSamePathWithDifferentWatchModes compilation failure

kezhuw commented on PR #2012: URL: https://github.com/apache/zookeeper/pull/2012#issuecomment-1594557823 @tisonkun I guess @anmolnar might prefer to revert the last commit. You can checkout slack channel. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] kezhuw opened a new pull request, #2012: hotfix: Fix testSamePathWithDifferentWatchModes compilation failure

kezhuw opened a new pull request, #2012: URL: https://github.com/apache/zookeeper/pull/2012 PR #1950(ZOOKEEPER-4655) was created before #1859(ZOOKEEPER-4466) merged. It changes `assertEvent`'s signature which is depended by #1859. This fixes master compilation failure. cc

[GitHub] [zookeeper] anmolnar merged pull request #2012: ZOOKEEPER-4655: [ADDENDUM] fix build error

anmolnar merged PR #2012: URL: https://github.com/apache/zookeeper/pull/2012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zookeeper] eolivelli closed pull request #2011: ZOOKEEPER-4705 Restrict GitHub merge button to allow squash commit only

eolivelli closed pull request #2011: ZOOKEEPER-4705 Restrict GitHub merge button to allow squash commit only URL: https://github.com/apache/zookeeper/pull/2011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [zookeeper] tisonkun commented on pull request #2012: hotfix: Fix testSamePathWithDifferentWatchModes compilation failure

tisonkun commented on PR #2012: URL: https://github.com/apache/zookeeper/pull/2012#issuecomment-1594554349 Jenkins fails seems on a unrelated test: ``` QuorumSSLTest.testRollingUpgrade:598->stopAppendConfigRestartAll:618 expected: but was: ``` I don't know how to rerun

[GitHub] [zookeeper] anmolnar commented on a diff in pull request #1690: ZOOKEEPER-3615: Provide formal specification and verification using TLA+ for Zab

anmolnar commented on code in PR #1690: URL: https://github.com/apache/zookeeper/pull/1690#discussion_r1232321074 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java: ## @@ -1030,7 +1030,7 @@ protected long queueCommittedProposals(Iterator

[GitHub] [zookeeper] BinyuHuang-nju commented on a diff in pull request #1690: ZOOKEEPER-3615: Provide formal specification and verification using TLA+ for Zab

BinyuHuang-nju commented on code in PR #1690: URL: https://github.com/apache/zookeeper/pull/1690#discussion_r1232422734 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java: ## @@ -1030,7 +1030,7 @@ protected long

[GitHub] [zookeeper] anmolnar commented on pull request #2010: fix(sec): upgrade org.eclipse.jetty:jetty-server to 12.0.0.beta0

anmolnar commented on PR #2010: URL: https://github.com/apache/zookeeper/pull/2010#issuecomment-1595200522 @admxj Please a create a Jira for the issue first and let the community discuss the best solution. We won't upgrade to a beta version of Jetty and according to @ctubbsii comment,

[GitHub] [zookeeper] anmolnar closed pull request #2010: fix(sec): upgrade org.eclipse.jetty:jetty-server to 12.0.0.beta0

anmolnar closed pull request #2010: fix(sec): upgrade org.eclipse.jetty:jetty-server to 12.0.0.beta0 URL: https://github.com/apache/zookeeper/pull/2010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [zookeeper] anmolnar commented on pull request #1690: ZOOKEEPER-3615: Provide formal specification and verification using TLA+ for Zab

anmolnar commented on PR #1690: URL: https://github.com/apache/zookeeper/pull/1690#issuecomment-1595222074 Awesome stuff. Thanks @BinyuHuang-nju ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zookeeper] anmolnar merged pull request #1690: ZOOKEEPER-3615: Provide formal specification and verification using TLA+ for Zab

anmolnar merged PR #1690: URL: https://github.com/apache/zookeeper/pull/1690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zookeeper] ctubbsii commented on pull request #2010: fix(sec): upgrade org.eclipse.jetty:jetty-server to 12.0.0.beta0

ctubbsii commented on PR #2010: URL: https://github.com/apache/zookeeper/pull/2010#issuecomment-1595141379 Version 9.4.51 already fixes this according to https://nvd.nist.gov/vuln/detail/CVE-2023-26049 and that's being done in #2007 . This is redundant, and I have no idea what OSCS is, or

[GitHub] [zookeeper] anmolnar merged pull request #2011: ZOOKEEPER-4705 Restrict GitHub merge button to allow squash commit only

anmolnar merged PR #2011: URL: https://github.com/apache/zookeeper/pull/2011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zookeeper] asfgit closed pull request #2007: ZOOKEEPER-4700 Update Jetty for fixing CVE-2023-26048 and CVE-2023-26049

asfgit closed pull request #2007: ZOOKEEPER-4700 Update Jetty for fixing CVE-2023-26048 and CVE-2023-26049 URL: https://github.com/apache/zookeeper/pull/2007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [zookeeper] anmolnar commented on pull request #1935: Backport to 3.8 of ff7db1a: OpenSSL 3 - implicit declaration of FIPS_mode()

anmolnar commented on PR #1935: URL: https://github.com/apache/zookeeper/pull/1935#issuecomment-1595212987 @YouDirk Thanks for the contribution. Would you please open a Jira ticket for the issue and create pull request for the master branch? -- This is an automated message from the

[GitHub] [zookeeper] anmolnar closed pull request #1935: Backport to 3.8 of ff7db1a: OpenSSL 3 - implicit declaration of FIPS_mode()

anmolnar closed pull request #1935: Backport to 3.8 of ff7db1a: OpenSSL 3 - implicit declaration of FIPS_mode() URL: https://github.com/apache/zookeeper/pull/1935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [zookeeper] ctubbsii commented on pull request #2011: ZOOKEEPER-4705 Restrict GitHub merge button to allow squash commit only

ctubbsii commented on PR #2011: URL: https://github.com/apache/zookeeper/pull/2011#issuecomment-1595094644 > I think that we have to commit this only on the default branch ("master" in our case) That is correct. .asf.yaml is not processed in any of the other branches and does not

[GitHub] [zookeeper] anmolnar commented on pull request #2002: ZOOKEEPER-4700 Update Jetty for fixing CVE-2023-26048 and CVE-2023-26049

anmolnar commented on PR #2002: URL: https://github.com/apache/zookeeper/pull/2002#issuecomment-1595211559 Already submitted for branch-3.8 with https://github.com/apache/zookeeper/pull/2007 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] anmolnar closed pull request #2002: ZOOKEEPER-4700 Update Jetty for fixing CVE-2023-26048 and CVE-2023-26049

anmolnar closed pull request #2002: ZOOKEEPER-4700 Update Jetty for fixing CVE-2023-26048 and CVE-2023-26049 URL: https://github.com/apache/zookeeper/pull/2002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [zookeeper] anmolnar commented on pull request #1953: ZOOKEEPER-4554 : upgrade netty 4.1.76.Final to 4.1.77.Final

anmolnar commented on PR #1953: URL: https://github.com/apache/zookeeper/pull/1953#issuecomment-1595216543 ZooKeeper 3.6 is already EoL since 30th December, 2022. Please upgrade to a more recent version. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] anmolnar closed pull request #1953: ZOOKEEPER-4554 : upgrade netty 4.1.76.Final to 4.1.77.Final

anmolnar closed pull request #1953: ZOOKEEPER-4554 : upgrade netty 4.1.76.Final to 4.1.77.Final URL: https://github.com/apache/zookeeper/pull/1953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zookeeper] kezhuw commented on pull request #2013: ZOOKEEPER-3615: [ADDENDUM] fix rat error

kezhuw commented on PR #2013: URL: https://github.com/apache/zookeeper/pull/2013#issuecomment-1595625515 @tisonkun @eolivelli @anmolnar Could you please take a look ? `master` branch fails to `apache-rat:check` after #1690 merged. -- This is an automated message from the Apache Git

[GitHub] [zookeeper] tisonkun merged pull request #2013: ZOOKEEPER-3615: [ADDENDUM] fix rat error

tisonkun merged PR #2013: URL: https://github.com/apache/zookeeper/pull/2013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zookeeper] kezhuw opened a new pull request, #2013: ZOOKEEPER-3615: [ADDENDUM] fix rat error

kezhuw opened a new pull request, #2013: URL: https://github.com/apache/zookeeper/pull/2013 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,