[GitHub] [zookeeper] GavinAlison closed pull request #966: Branch 3.5.5 running zookeeper can't start on linux_64 system

GavinAlison closed pull request #966: Branch 3.5.5running zookeeper can't start on linux_64 system URL: https://github.com/apache/zookeeper/pull/966 This is an automated message from the Apache Git Service. To respond to

[GitHub] [zookeeper] GavinAlison opened a new pull request #966: Branch 3.5.5 running zookeeper can't start on linux_64 system

GavinAlison opened a new pull request #966: Branch 3.5.5running zookeeper can't start on linux_64 system URL: https://github.com/apache/zookeeper/pull/966 running zookeeper can't start on linux_64 system zookeeper vesion: 3.5.5 linux : centos x64 exception: ``` 错误

[GitHub] [zookeeper] hanm commented on a change in pull request #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted …

hanm commented on a change in pull request #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted … URL: https://github.com/apache/zookeeper/pull/944#discussion_r290112464 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFa

[GitHub] [zookeeper] hanm commented on a change in pull request #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted …

hanm commented on a change in pull request #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted … URL: https://github.com/apache/zookeeper/pull/944#discussion_r290111854 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFa

[GitHub] [zookeeper] maoling commented on issue #960: Fix typos and grammar in zookeeper docs

maoling commented on issue #960: Fix typos and grammar in zookeeper docs URL: https://github.com/apache/zookeeper/pull/960#issuecomment-498483418 retest this please This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] enixon commented on issue #939: ZOOKEEPER-3385: Add admin command to display leader

enixon commented on issue #939: ZOOKEEPER-3385: Add admin command to display leader URL: https://github.com/apache/zookeeper/pull/939#issuecomment-498457960 retest maven build This is an automated message from the Apache Git

[GitHub] [zookeeper] enixon commented on issue #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor

enixon commented on issue #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor URL: https://github.com/apache/zookeeper/pull/905#issuecomment-498457278 Some numbers: I set up a basic ensemble of five peers and ran a job that created 2k mutations per second and 2k reads per s

[GitHub] [zookeeper] asfgit closed pull request #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

asfgit closed pull request #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [zookeeper] vladimirivic commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out

vladimirivic commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#discussion_r289949284 ## File path: conf/zoo_sample.cfg ## @@ -6,6 +6,9 @@ initLimit=10 # The

[GitHub] [zookeeper] eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498341300 retest maven build This is an automated message from the Apache Git S

[GitHub] [zookeeper] eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498282034 @nkalmar the error seems not related to this patch ``` java.lang.AssertionError at org.junit.Assert.fail(Assert.java:

[GitHub] [zookeeper] eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498282085 retest maven build This is an automated message from the Apache Git S

[GitHub] [zookeeper] nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498239868 I'm not sure why the maven build failed the last run? This is an automa

[GitHub] [zookeeper] eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498238325 @nkalmar if javac does not complaint I won't take care of them as we cannot enforce. I can clean up them now, this way we can start

[GitHub] [zookeeper] nkalmar edited a comment on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

nkalmar edited a comment on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498194477 Actually, I do have some javadoc warnings left :( edit: deleted the output, too long. ---

[GitHub] [zookeeper] nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498194477 Actually, I do have some javadoc warnings left :( `[WARNING] Javadoc Warnings [WARNING] /Users/norbertkalmar/workspace/upstrea

[GitHub] [zookeeper] nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498191954 That's strange indeed. I can see it and it causes build failure. I checked out master and applied your patch (although it doesn't even to

[GitHub] [zookeeper] eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498192940 I had an old version of "master" locally. Thank you very much @nkalmar for your support. I have pushed the fix. Maybe I wi

[GitHub] [zookeeper] eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498191594 Oh, maybe I have to rebase :-( This is an automated message from the

[GitHub] [zookeeper] eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498190929 @nkalmar this is weird here on github I can see the line, but I can't see that line on my local copy https://github.com/apac

[GitHub] [zookeeper] eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498191055 ``` /** * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTI

[GitHub] [zookeeper] nkalmar edited a comment on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

nkalmar edited a comment on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498188536 Why not just remove the > sign and use "bigger" on the line "If both flushDelay and maxMaxBatchSize are set (> 0)" ?

[GitHub] [zookeeper] eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498190223 > Why not just remove the > sign and use "bigger" on the line > "If both flushDelay and maxMaxBatchSize are set (> 0)" ? @nka

[GitHub] [zookeeper] nkalmar edited a comment on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

nkalmar edited a comment on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498188536 Why not just remove the > sign and use "bigger" on the line "If both flushDelay and maxMaxBatchSize are set (> 0)" ? Ed

[GitHub] [zookeeper] nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498188536 Why not just remove the > sing and use "smaller" on the line "If both flushDelay and maxMaxBatchSize are set (> 0)" ? ---

[GitHub] [zookeeper] maoling commented on a change in pull request #833: ZOOKEEPER-3288:add a new doc:ZookeeperCLI.md

maoling commented on a change in pull request #833: ZOOKEEPER-3288:add a new doc:ZookeeperCLI.md URL: https://github.com/apache/zookeeper/pull/833#discussion_r289740854 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperCLI.md ## @@ -0,0 +1,542 @@ + + +# Zoo

[GitHub] [zookeeper] grgrzybek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

grgrzybek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-498168041 Excuse me for being late to the party. Let me introduce myself - I'm OSGi dinosaur