[GitHub] [zookeeper] maoling opened a new pull request #974: ZOOKEEPER-3344:write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter and doc the usage
maoling opened a new pull request #974: ZOOKEEPER-3344:write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter and doc the usage URL: https://github.com/apache/zookeeper/pull/974 - A test case about `zkSnapShotToolkit.cmd` in the `Windows` os was included in the [JIRA](https://issues.apache.org/jira/browse/ZOOKEEPER-3344) - more details in [ZOOKEEPER-3344](https://issues.apache.org/jira/browse/ZOOKEEPER-3344) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] lvfangmin commented on a change in pull request #712: Maintain the configuration will be used by server stabilizer.It can be overridden based on the server type and the server sys
lvfangmin commented on a change in pull request #712: Maintain the
configuration will be used by server stabilizer.It can be overridden based on
the server type and the server system internals.
URL: https://github.com/apache/zookeeper/pull/712#discussion_r291765165
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/common/ZookeeperServerStabilizerConfig.java
##
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.common;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class ZookeeperServerStabilizerConfig {
Review comment:
Can you add some simple description for this class.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out
eolivelli commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#issuecomment-500047290 @hanm @lvfangmim Does this patch look good to you now? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] vladimirivic commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out
vladimirivic commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#discussion_r291758431 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md ## @@ -861,6 +862,11 @@ of servers -- that is, when deploying clusters of servers. connect and sync to a leader. Increased this value as needed, if the amount of data managed by ZooKeeper is large. +* *connectToLearnerMasterLimit* : +(No Java system property) +Amount of time, in ticks (see [tickTime](#id_tickTime)), to allow followers to +connect to the learner master after leader election. Review comment: Default value in the example config is 5. Also if the value is not specified or it's not greater than 0, then the `initLimit` value will be used instead. Will update the docs shortly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] vladimirivic commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out
vladimirivic commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#discussion_r291758431 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md ## @@ -861,6 +862,11 @@ of servers -- that is, when deploying clusters of servers. connect and sync to a leader. Increased this value as needed, if the amount of data managed by ZooKeeper is large. +* *connectToLearnerMasterLimit* : +(No Java system property) +Amount of time, in ticks (see [tickTime](#id_tickTime)), to allow followers to +connect to the learner master after leader election. Review comment: Default value in the example config is 5. Also if the value is not specified or it's not greater than 0, then the `initLimit` value will be used instead. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] eolivelli commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out
eolivelli commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#discussion_r291733345 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md ## @@ -861,6 +862,11 @@ of servers -- that is, when deploying clusters of servers. connect and sync to a leader. Increased this value as needed, if the amount of data managed by ZooKeeper is large. +* *connectToLearnerMasterLimit* : +(No Java system property) +Amount of time, in ticks (see [tickTime](#id_tickTime)), to allow followers to +connect to the learner master after leader election. Review comment: We must tell about the default value This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] nkalmar commented on issue #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor
nkalmar commented on issue #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor URL: https://github.com/apache/zookeeper/pull/905#issuecomment-499867500 retest ant build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] asfgit closed pull request #969: ZOOKEEPER-3416: Remove redundant ServerCnxnFactoryAccessor.
asfgit closed pull request #969: ZOOKEEPER-3416: Remove redundant ServerCnxnFactoryAccessor. URL: https://github.com/apache/zookeeper/pull/969 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
