[GitHub] [zookeeper] eolivelli closed pull request #332: Port of ZOOKEEPER-1416 Persistent Recursive Watches

2019-11-08 Thread GitBox
eolivelli closed pull request #332: Port of ZOOKEEPER-1416 Persistent Recursive Watches URL: https://github.com/apache/zookeeper/pull/332 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] eolivelli commented on issue #332: Port of ZOOKEEPER-1416 Persistent Recursive Watches

2019-11-08 Thread GitBox
eolivelli commented on issue #332: Port of ZOOKEEPER-1416 Persistent Recursive Watches URL: https://github.com/apache/zookeeper/pull/332#issuecomment-551896944 In my opinion we can close this PR, branch 3.5 is closed for new feature and expecially wire protocol changes. The feature

[GitHub] [zookeeper] asfgit closed pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers

2019-11-08 Thread GitBox
asfgit closed pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers URL: https://github.com/apache/zookeeper/pull/1106 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] arshadmohammad commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-11-08 Thread GitBox
arshadmohammad commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers. URL: https://github.com/apache/zookeeper/pull/1133#discussion_r344239092 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md ## @@ -956,6

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-11-08 Thread GitBox
anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers. URL: https://github.com/apache/zookeeper/pull/1133#discussion_r344181499 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md ## @@ -956,6

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-11-08 Thread GitBox
anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers. URL: https://github.com/apache/zookeeper/pull/1133#discussion_r344186167 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-11-08 Thread GitBox
anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers. URL: https://github.com/apache/zookeeper/pull/1133#discussion_r344181499 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md ## @@ -956,6

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-11-08 Thread GitBox
anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers. URL: https://github.com/apache/zookeeper/pull/1133#discussion_r344157467 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/audit/Log4jAuditLogger.java

[GitHub] [zookeeper] eolivelli commented on issue #1106: ZOOKEEPER-1416 - Persistent, recursive watchers

2019-11-08 Thread GitBox
eolivelli commented on issue #1106: ZOOKEEPER-1416 - Persistent, recursive watchers URL: https://github.com/apache/zookeeper/pull/1106#issuecomment-551569255 @anmolnar shall I have the honour of merging this patch ?