maoling commented on PR #2056:
URL: https://github.com/apache/zookeeper/pull/2056#issuecomment-1698758756
- Thanks for this contribution. It's better to create a
[JIRA](https://issues.apache.org/jira/projects/ZOOKEEPER/) issue (sign up JIRA
if you don't have an account) to bind this PR to
kezhuw closed pull request #2058: ZOOKEEPER-4508: Expire session in client side
to avoid endless connection loss
URL: https://github.com/apache/zookeeper/pull/2058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
eolivelli merged PR #2001:
URL: https://github.com/apache/zookeeper/pull/2001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kezhuw opened a new pull request, #2059:
URL: https://github.com/apache/zookeeper/pull/2059
It is somewhat well-known that ZooKeeper's sequential node number will
overflow finally. It is ok for most usages, but it could also be annoying to
handle this overflow in client side in certain
SiyaoIsHiding opened a new pull request, #2060:
URL: https://github.com/apache/zookeeper/pull/2060
As in the class `FileTxnSnapLog`
```java
//the directory containing
//the transaction logs
final File dataDir;
//the directory containing
//the snapshot
tisonkun merged PR #1988:
URL: https://github.com/apache/zookeeper/pull/1988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Fabrice-TIERCELIN commented on PR #2056:
URL: https://github.com/apache/zookeeper/pull/2056#issuecomment-1714288302
@maoling, I also have a suggestion for you. GitHub redirects people like me
to [this page of
tisonkun opened a new pull request, #2063:
URL: https://github.com/apache/zookeeper/pull/2063
Pick up something good.
Ref - ZOOKEEPER-910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
zhaohaidao opened a new pull request, #2064:
URL: https://github.com/apache/zookeeper/pull/2064
Description:
As shown in the title, see the jira link description for the background
jira: https://issues.apache.org/jira/projects/ZOOKEEPER/issues/ZOOKEEPER-4743
--
This is an automated
zhaohaidao commented on PR #2064:
URL: https://github.com/apache/zookeeper/pull/2064#issuecomment-1721577050
Hey, @tisonkun Please help me review this PR when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kezhuw commented on PR #2058:
URL: https://github.com/apache/zookeeper/pull/2058#issuecomment-1719334929
Mail thread for the proposal:
https://lists.apache.org/thread/0hf81c1tdsp6mm130gw1h5xglkx48vv0
--
This is an automated message from the Apache Git Service.
To respond to the message,
zhaohaidao commented on code in PR #2064:
URL: https://github.com/apache/zookeeper/pull/2064#discussion_r1327992417
##
zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java:
##
@@ -735,10 +735,18 @@ private String getParentPathAndValidate(String
kezhuw commented on code in PR #2064:
URL: https://github.com/apache/zookeeper/pull/2064#discussion_r1327947410
##
zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java:
##
@@ -735,10 +735,18 @@ private String getParentPathAndValidate(String path)
kezhuw commented on code in PR #2064:
URL: https://github.com/apache/zookeeper/pull/2064#discussion_r1327947410
##
zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java:
##
@@ -735,10 +735,18 @@ private String getParentPathAndValidate(String path)
kezhuw commented on code in PR #1996:
URL: https://github.com/apache/zookeeper/pull/1996#discussion_r1328041454
##
zookeeper-server/src/test/java/org/apache/zookeeper/test/ConfigWatcherPathTest.java:
##
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
kezhuw commented on PR #1996:
URL: https://github.com/apache/zookeeper/pull/1996#issuecomment-1722388012
Superceded by #2065.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
kezhuw closed pull request #1996: ZOOKEEPER-4601: Fix get config watcher path
to "/zookeeper/config"
URL: https://github.com/apache/zookeeper/pull/1996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Fabrice-TIERCELIN opened a new pull request, #2056:
URL: https://github.com/apache/zookeeper/pull/2056
Hi,
This is a PR to learn how to code tests using an AI.
It's a draft but I plan to make it mergeable.
--
This is an automated message from the Apache Git Service.
To
kezhuw closed pull request #1847: ZOOKEEPER-4508: Fix endless-loop in
ClientCnxn.SendThread.run when all zk servers down
URL: https://github.com/apache/zookeeper/pull/1847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kezhuw commented on PR #1847:
URL: https://github.com/apache/zookeeper/pull/1847#issuecomment-1702367578
Superceded by #2058 which propose a client side session expiration timeout
formally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
whyer6 commented on code in PR #2045:
URL: https://github.com/apache/zookeeper/pull/2045#discussion_r1309434684
##
zookeeper-client/zookeeper-client-c/tests/TestReconfig.cc:
##
@@ -499,7 +499,7 @@ class Zookeeper_reconfig : public CPPUNIT_NS::TestFixture
found =
Taher-Ghaleb commented on PR #2055:
URL: https://github.com/apache/zookeeper/pull/2055#issuecomment-1698350938
Hi, any updates, please? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
tisonkun commented on PR #2055:
URL: https://github.com/apache/zookeeper/pull/2055#issuecomment-1698356572
I'm retriggering the CI workflow. Will merge it once CI passed or I'll check
these changes unrelated locally.
A ticket is still appreciated.
--
This is an automated message
Taher-Ghaleb commented on PR #2055:
URL: https://github.com/apache/zookeeper/pull/2055#issuecomment-1698422285
Thanks @tisonkun. Sure, I have created a Jira ticket and prefixed its id on
the PR title.
--
This is an automated message from the Apache Git Service.
To respond to the
tisonkun merged PR #2055:
URL: https://github.com/apache/zookeeper/pull/2055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tisonkun commented on PR #2055:
URL: https://github.com/apache/zookeeper/pull/2055#issuecomment-1698430600
Thank you! Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
vibhutisawant opened a new pull request, #2057:
URL: https://github.com/apache/zookeeper/pull/2057
As netty-tc-native is not supported for s390x arch, there were TC failures
observed in ClientSSLTest, hence skipping this TC for s390x arch only.
--
This is an automated message
vibhutisawant commented on code in PR #2038:
URL: https://github.com/apache/zookeeper/pull/2038#discussion_r1311793349
##
zookeeper-server/src/test/java/org/apache/zookeeper/test/ClientSSLTest.java:
##
@@ -147,6 +148,8 @@ public void testClientServerSSLWithCnxnClassName()
vibhutisawant commented on code in PR #2038:
URL: https://github.com/apache/zookeeper/pull/2038#discussion_r1311656633
##
zookeeper-server/src/test/java/org/apache/zookeeper/test/ClientSSLTest.java:
##
@@ -147,6 +148,8 @@ public void testClientServerSSLWithCnxnClassName()
eolivelli commented on code in PR #2038:
URL: https://github.com/apache/zookeeper/pull/2038#discussion_r1311657615
##
zookeeper-server/src/test/java/org/apache/zookeeper/test/ClientSSLTest.java:
##
@@ -147,6 +148,8 @@ public void testClientServerSSLWithCnxnClassName() throws
vibhutisawant commented on code in PR #2038:
URL: https://github.com/apache/zookeeper/pull/2038#discussion_r1311555048
##
Jenkinsfile-s390x:
##
@@ -48,7 +48,7 @@ pipeline {
stage('BuildAndTest') {
steps {
sh "git
eolivelli commented on code in PR #2038:
URL: https://github.com/apache/zookeeper/pull/2038#discussion_r1311648006
##
zookeeper-server/src/test/java/org/apache/zookeeper/test/ClientSSLTest.java:
##
@@ -147,6 +148,8 @@ public void testClientServerSSLWithCnxnClassName() throws
vibhutisawant commented on code in PR #2038:
URL: https://github.com/apache/zookeeper/pull/2038#discussion_r1311656633
##
zookeeper-server/src/test/java/org/apache/zookeeper/test/ClientSSLTest.java:
##
@@ -147,6 +148,8 @@ public void testClientServerSSLWithCnxnClassName()
kezhuw commented on code in PR #1996:
URL: https://github.com/apache/zookeeper/pull/1996#discussion_r1325874176
##
zookeeper-server/src/test/java/org/apache/zookeeper/test/ChrootTest.java:
##
@@ -63,25 +60,6 @@ public boolean matches() throws InterruptedException {
}
-
kezhuw commented on code in PR #1996:
URL: https://github.com/apache/zookeeper/pull/1996#discussion_r1326831655
##
zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java:
##
@@ -855,10 +855,22 @@ class SendThread extends ZooKeeperThread {
private boolean
tisonkun commented on code in PR #2062:
URL: https://github.com/apache/zookeeper/pull/2062#discussion_r1327013852
##
zookeeper-server/src/test/java/org/apache/zookeeper/test/ChrootTest.java:
##
@@ -65,7 +65,9 @@ public boolean matches() throws InterruptedException {
tisonkun commented on PR #2062:
URL: https://github.com/apache/zookeeper/pull/2062#issuecomment-1720932722
Here is a patch:
```diff
diff --git
a/zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
tisonkun commented on code in PR #1996:
URL: https://github.com/apache/zookeeper/pull/1996#discussion_r1326764484
##
zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java:
##
@@ -855,10 +855,22 @@ class SendThread extends ZooKeeperThread {
private boolean
tisonkun commented on code in PR #1996:
URL: https://github.com/apache/zookeeper/pull/1996#discussion_r1326764080
##
zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java:
##
@@ -855,10 +855,22 @@ class SendThread extends ZooKeeperThread {
private boolean
kezhuw opened a new pull request, #2062:
URL: https://github.com/apache/zookeeper/pull/2062
Currently, `ClientCnxn` will strip path "/zookeeper/config" to
"keeper/config" for chroot "/zoo". This causes exception and finally connection
loss.
This is a leftover of ZOOKEEPER-4565.
--
kezhuw commented on PR #2062:
URL: https://github.com/apache/zookeeper/pull/2062#issuecomment-1720812292
Hi @tisonkun, I split this from #1996, I think this will make both pr more
concentrated. And also, we once considered ZOOKEEPER-4601 as a [breaking change
due to misinformation from my
kezhuw commented on PR #2062:
URL: https://github.com/apache/zookeeper/pull/2062#issuecomment-1721003134
@tisonkun Thank you for reviwing. I have assigned ZOOKEEPER-838 to myself
and try to work out a solution for evaluation.
--
This is an automated message from the Apache Git Service.
kezhuw commented on code in PR #2062:
URL: https://github.com/apache/zookeeper/pull/2062#discussion_r1327083090
##
zookeeper-server/src/test/java/org/apache/zookeeper/test/ChrootTest.java:
##
@@ -65,7 +65,9 @@ public boolean matches() throws InterruptedException {
@Test
vibhutisawant commented on PR #2038:
URL: https://github.com/apache/zookeeper/pull/2038#issuecomment-1711255961
Hi @eolivelli , @ctubbsii Could you please take a look . Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
vibhutisawant commented on PR #2057:
URL: https://github.com/apache/zookeeper/pull/2057#issuecomment-1711256815
Hi @eolivelli , @ctubbsii Could you please review the changes . Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
smoldenhauer-ish opened a new pull request, #2061:
URL: https://github.com/apache/zookeeper/pull/2061
allows a more flexible usage of the ZK_SERVER_HEAP/ZK_CLIENT_HEAP
environment variable to specify heap related JVM settings.
It also keeps the old setting of a megabyte number for -Xmx
tisonkun commented on PR #2020:
URL: https://github.com/apache/zookeeper/pull/2020#issuecomment-1764410312
We can of course do so. @Shawyeok if you can help with cherry-picking and
prepare PRs, it will be great. I may not have too much time to drive this pick
but can help in merging.
Shawyeok commented on PR #2020:
URL: https://github.com/apache/zookeeper/pull/2020#issuecomment-1764364102
@horizonzy @tisonkun @eolivelli @symat
I encountered this issue while running the unit tests for branch-3.8 on a
computer with an Apple chip. It seems this commit has not been
tisonkun commented on PR #2079:
URL: https://github.com/apache/zookeeper/pull/2079#issuecomment-1764616564
Seems `CheckTest.testCluster` is quite unstable. @kezhuw do you have some
inputs here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
anmolnar commented on PR #1991:
URL: https://github.com/apache/zookeeper/pull/1991#issuecomment-1764315163
@jmalopoy Please create a Jira for this issue and explain the details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kezhuw commented on PR #2079:
URL: https://github.com/apache/zookeeper/pull/2079#issuecomment-1764649128
I opened #2067. Also, I have some thoughts on `OpCode.check` posted in
https://github.com/apache/zookeeper/pull/1988#issuecomment-1758870370.
--
This is an automated message from the
tsaarni commented on PR #1919:
URL: https://github.com/apache/zookeeper/pull/1919#issuecomment-1758121420
> @tisonkun @tsaarni Would you like this to be backported to other branches?
> branch-3.9 looks reasonable to me.
@anmolnar It would be great, at least no objections from my
janhoy commented on PR #2076:
URL: https://github.com/apache/zookeeper/pull/2076#issuecomment-1757969724
Ok, I think this is ready then for final review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
anmolnar commented on PR #1988:
URL: https://github.com/apache/zookeeper/pull/1988#issuecomment-1758004601
Looks like an old and nasty bug. Congrats @kezhuw for fixing it. Shouldn't
we backport it to `branch-3.9` too?
Maybe `branch-3.8` as well?
--
This is an automated message from
anmolnar commented on PR #2076:
URL: https://github.com/apache/zookeeper/pull/2076#issuecomment-1757950908
> Questions:
>
> * Is there a central place where all env.vars are mentioned?
No, there isn't.
> * Should we mention in docs that system property
kezhuw commented on PR #1988:
URL: https://github.com/apache/zookeeper/pull/1988#issuecomment-1765632143
This pr make CI unstable, I have opened #2067 to solve it.
Also, I wonder whether UNIMPLEMENTED is more appropriate. I sent
tisonkun merged PR #2067:
URL: https://github.com/apache/zookeeper/pull/2067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tisonkun merged PR #2081:
URL: https://github.com/apache/zookeeper/pull/2081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tisonkun commented on PR #2081:
URL: https://github.com/apache/zookeeper/pull/2081#issuecomment-1765488152
Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
tisonkun merged PR #2080:
URL: https://github.com/apache/zookeeper/pull/2080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Shawyeok opened a new pull request, #2080:
URL: https://github.com/apache/zookeeper/pull/2080
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
Shawyeok opened a new pull request, #2081:
URL: https://github.com/apache/zookeeper/pull/2081
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
Shawyeok commented on PR #2020:
URL: https://github.com/apache/zookeeper/pull/2020#issuecomment-1765409266
> We can of course do so. @Shawyeok if you can help with cherry-picking and
prepare PRs, it will be great. I may not have too much time to drive this pick
but can help in merging and
anmolnar commented on PR #2040:
URL: https://github.com/apache/zookeeper/pull/2040#issuecomment-1766033717
@showuon Sorry. This is done now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
apupier opened a new pull request, #2082:
URL: https://github.com/apache/zookeeper/pull/2082
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
apupier closed pull request #2078: ZOOKEEPER-4759: Handle Netty CVE-2023-44487
and CVE-2023-39325
URL: https://github.com/apache/zookeeper/pull/2078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
apupier commented on PR #2078:
URL: https://github.com/apache/zookeeper/pull/2078#issuecomment-1765816151
I guess it is because the vulnerability is still under investigation
https://nvd.nist.gov/vuln/detail/CVE-2023-44487
I created a neutral Pull Request just mentioning the upgrade
showuon commented on PR #2040:
URL: https://github.com/apache/zookeeper/pull/2040#issuecomment-1766286368
@anmolnar , thanks for the help! Could you also help review this PR:
https://github.com/apache/zookeeper/pull/2041 . They are basically trying to
fix the similar issue.
--
This is
tisonkun merged PR #2079:
URL: https://github.com/apache/zookeeper/pull/2079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tisonkun commented on PR #2079:
URL: https://github.com/apache/zookeeper/pull/2079#issuecomment-1766519457
Trivial fix. Merging...
Thanks for your contribution @gycherish!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
alexfernandez commented on PR #262:
URL: https://github.com/apache/zookeeper/pull/262#issuecomment-1779586780
Hi @asdf2014 , please do! It would be a great improvement for my company
too. Do you need any help?
--
This is an automated message from the Apache Git Service.
To respond to the
horizonzy opened a new pull request, #2083:
URL: https://github.com/apache/zookeeper/pull/2083
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
rishabh-src opened a new pull request, #2085:
URL: https://github.com/apache/zookeeper/pull/2085
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Shawyeok opened a new pull request, #2087:
URL: https://github.com/apache/zookeeper/pull/2087
If the `io.prometheus.client.hotspot.DefaultExports#initialize` method has
been executed by other test cases before running the
JJBRT opened a new pull request, #2088:
URL: https://github.com/apache/zookeeper/pull/2088
Update to the latest version of the Burningwave Tools library
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
eolivelli merged PR #2087:
URL: https://github.com/apache/zookeeper/pull/2087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
VinodAnandan opened a new pull request, #2084:
URL: https://github.com/apache/zookeeper/pull/2084
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
showuon commented on PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#issuecomment-1770124305
The compatibility test failed on java 11 in 3.6.3, but passed on java 8 in
3.6.3. I think it should be fine. Thanks.
--
This is an automated message from the Apache Git Service.
To
kezhuw opened a new pull request, #2067:
URL: https://github.com/apache/zookeeper/pull/2067
All tests are refactored to fail before #1988 and resist more than 100 runs
locally without failure after #1988.
## Context
I saw several failed ci actions due to flaky
zhaohaidao commented on PR #2064:
URL: https://github.com/apache/zookeeper/pull/2064#issuecomment-1729126723
@kezhuw @tisonkun Hi, the comments have been addressed. Can you continue to
review if you have time.
--
This is an automated message from the Apache Git Service.
To respond to the
kezhuw commented on PR #2065:
URL: https://github.com/apache/zookeeper/pull/2065#issuecomment-1732448319
> I'm going to send a PR against your PR. Please wait a bit for pushing
commits.
Great! I realized that this pr will be updated just after the moment I
clicked the merge button
tisonkun commented on code in PR #2065:
URL: https://github.com/apache/zookeeper/pull/2065#discussion_r1335038422
##
zookeeper-server/src/main/java/org/apache/zookeeper/ZKWatchManager.java:
##
@@ -52,7 +54,7 @@ class ZKWatchManager implements ClientWatchManager {
tisonkun commented on code in PR #2065:
URL: https://github.com/apache/zookeeper/pull/2065#discussion_r1335038509
##
zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java:
##
@@ -357,7 +355,6 @@ public String toString() {
* @param canBeReadOnly whether the
tisonkun merged PR #2065:
URL: https://github.com/apache/zookeeper/pull/2065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tisonkun commented on code in PR #2064:
URL: https://github.com/apache/zookeeper/pull/2064#discussion_r1334915069
##
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java:
##
@@ -1962,4 +1962,18 @@ public static StatPersisted createStat(long zxid, long
time,
tisonkun commented on code in PR #2064:
URL: https://github.com/apache/zookeeper/pull/2064#discussion_r1334915069
##
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java:
##
@@ -1962,4 +1962,18 @@ public static StatPersisted createStat(long zxid, long
time,
kezhuw commented on PR #2059:
URL: https://github.com/apache/zookeeper/pull/2059#issuecomment-1732318519
> IIRC zxid only use the least significant 32 bit as sequential id, so it's
still overflow with Integer.MAX_VALUE bound.
No, overflow of the lower 32-bits means re-election.
kezhuw commented on code in PR #2064:
URL: https://github.com/apache/zookeeper/pull/2064#discussion_r1328506083
##
zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java:
##
@@ -735,10 +735,18 @@ private String getParentPathAndValidate(String path)
kezhuw closed pull request #2067: ZOOKEEPER-2623: [ADDENDUM] Fix flaky
CheckTest::testCluster
URL: https://github.com/apache/zookeeper/pull/2067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kezhuw commented on PR #2067:
URL: https://github.com/apache/zookeeper/pull/2067#issuecomment-1727402558
I ran ci twice and both failed but for different reasons(ZOOKEEPER-4746,
ZOOKEEPER-4745). I think ci is not a blocker for us to go.
@anmolnar @eolivelli @maoling @symat @tisonkun
ctubbsii commented on code in PR #1919:
URL: https://github.com/apache/zookeeper/pull/1919#discussion_r1336181672
##
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java:
##
@@ -81,7 +87,32 @@ public abstract class X509Util implements Closeable,
tsaarni commented on code in PR #1919:
URL: https://github.com/apache/zookeeper/pull/1919#discussion_r1336257400
##
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java:
##
@@ -81,7 +87,32 @@ public abstract class X509Util implements Closeable,
tsaarni commented on code in PR #1919:
URL: https://github.com/apache/zookeeper/pull/1919#discussion_r1336257400
##
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java:
##
@@ -81,7 +87,32 @@ public abstract class X509Util implements Closeable,
ctubbsii commented on code in PR #1919:
URL: https://github.com/apache/zookeeper/pull/1919#discussion_r1340759056
##
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java:
##
@@ -81,7 +87,32 @@ public abstract class X509Util implements Closeable,
kezhuw commented on PR #2069:
URL: https://github.com/apache/zookeeper/pull/2069#issuecomment-174022
> trying to dynamically set a system property prior to calling an API method
doesn't seem like a great option.
`quorumSync` is a server side property, client are innocent to
ctubbsii commented on code in PR #2068:
URL: https://github.com/apache/zookeeper/pull/2068#discussion_r1340830026
##
zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java:
##
@@ -2708,6 +2708,31 @@ public void
getEphemerals(AsyncCallback.EphemeralsCallback cb,
kezhuw commented on PR #2069:
URL: https://github.com/apache/zookeeper/pull/2069#issuecomment-1740246426
> Have separate public APIs so the user can rely on the behavior they expect
for the API they used
Will this cause much confusion in world after 3.10.0 ? Does client really
want
ctubbsii commented on PR #2069:
URL: https://github.com/apache/zookeeper/pull/2069#issuecomment-1740264152
> Will this cause much confusion in world after 3.10.0 ? Does client really
want to choose to "dated data" ?
No, you are probably right. I can't imagine anybody would want this.
vibhutisawant commented on PR #2038:
URL: https://github.com/apache/zookeeper/pull/2038#issuecomment-1740387395
Hi @ctubbsii, could this PR be merged? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
vibhutisawant commented on PR #2057:
URL: https://github.com/apache/zookeeper/pull/2057#issuecomment-1740387527
Hi @ctubbsii, could this PR be merged? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
1 - 100 of 1202 matches
Mail list logo
