eolivelli commented on issue #1049: ZOOKEEPER-3475 Enable Checkstyle
configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#issuecomment-521763584
I think we are on our way.
Ping me when you are done
If the other guys (@hanm @enixon) that started a re
eolivelli commented on issue #1049: ZOOKEEPER-3475 Enable Checkstyle
configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#issuecomment-520714542
If we continue in this PR we won't lose the comments, so it may be better.
In my experience when a PR has too m
eolivelli commented on issue #1049: ZOOKEEPER-3475 Enable Checkstyle
configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#issuecomment-520700461
@tisunkun thank you for this effort.
I don't know if you have to start from scratch or fix up this branch.
A
eolivelli commented on issue #1049: ZOOKEEPER-3475 Enable Checkstyle
configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#issuecomment-520239486
Thank you @TisonKun
our commit script (zk-merge.py) will squash all of the commits.
I will review.