[GitHub] [zookeeper] nkalmar commented on issue #610: [ZOOKEEPER-3124] Add the correct comment to show why we need the special logic to handle cversion and pzxid

2019-09-10 Thread GitBox
nkalmar commented on issue #610: [ZOOKEEPER-3124] Add the correct comment to 
show why we need the special logic to handle cversion and pzxid
URL: https://github.com/apache/zookeeper/pull/610#issuecomment-529818415
 
 
   Pushed to master. Thanks @lvfangmin 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] nkalmar commented on issue #610: [ZOOKEEPER-3124] Add the correct comment to show why we need the special logic to handle cversion and pzxid

2019-09-10 Thread GitBox
nkalmar commented on issue #610: [ZOOKEEPER-3124] Add the correct comment to 
show why we need the special logic to handle cversion and pzxid
URL: https://github.com/apache/zookeeper/pull/610#issuecomment-529815520
 
 
   Sure, I'll wait maven build, ant failing is fine from my point of view. On 
master it will be decommissioned anyway.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] nkalmar commented on issue #610: [ZOOKEEPER-3124] Add the correct comment to show why we need the special logic to handle cversion and pzxid

2019-08-12 Thread GitBox
nkalmar commented on issue #610: [ZOOKEEPER-3124] Add the correct comment to 
show why we need the special logic to handle cversion and pzxid
URL: https://github.com/apache/zookeeper/pull/610#issuecomment-520373434
 
 
   Sure, I can commit, just please rebase @lvfangmin , unfortunately it became 
conflicted.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services