[GitHub] [accumulo] keith-turner commented on issue #1317: Provide single-line output of tablet info.
keith-turner commented on issue #1317: URL: https://github.com/apache/accumulo/issues/1317#issuecomment-724278849 >. What do you think about a new type in core.metadata (similar to what I did for TabletFile) that could be used everywhere? And would we want to keep the ZK session Id? I like that. That Location type in TabletMetadata could possibly extend it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo] keith-turner commented on issue #1317: Provide single-line output of tablet info.
keith-turner commented on issue #1317: URL: https://github.com/apache/accumulo/issues/1317#issuecomment-722764991 For my previous comment, the Location type will not really work for this case. Need a type that just encapsulates `(server,session)` for the set of live tservers. TabletMetadata.Location has those plus LocationType, which makes no sense for a live tserver. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo] keith-turner commented on issue #1317: Provide single-line output of tablet info.
keith-turner commented on issue #1317:
URL: https://github.com/apache/accumulo/issues/1317#issuecomment-722763864
@milleruntime I suspect the code could be moved to accumulo core OR
reimplemented in core (and existing code migrated to Ample). One possible way
to add it to ample would be to modify TabletMetadata class to add a method like
the following.
```java
TabletState getTabletState(Set liveTservers) {
//use tablet metadata + liveTservers to determine the state of this
tablet.
// Location is an inner class TabletMetadata
}
```
Then maybe Ample could have a getLiveTservers() method.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [accumulo] keith-turner commented on issue #1317: Provide single-line output of tablet info.
keith-turner commented on issue #1317: Provide single-line output of tablet info. URL: https://github.com/apache/accumulo/issues/1317#issuecomment-521765040 > What is the proper way to determine status? Could use [TabletLocationState.getState()][2]. One way to get TabletLocationState objects is via [TabletStateStore][1]. The set of live tservers can be obtained using [LiveTServerSet][3]. > The original ticket mentioned that some information could be pulled from zookeeper - with the current implementation, all information is coming from the metadata table. What information is missing / would be helpful? [LiveTServerSet][3] pulls the set of active tablet servers from zookeeper. [1]: https://github.com/apache/accumulo/blob/f39c2fef1c1c911e86985ce6352c5d1bc9967c5b/server/base/src/main/java/org/apache/accumulo/server/master/state/TabletStateStore.java [2]: https://github.com/apache/accumulo/blob/f39c2fef1c1c911e86985ce6352c5d1bc9967c5b/server/base/src/main/java/org/apache/accumulo/server/master/state/TabletLocationState.java#L104 [3]: https://github.com/apache/accumulo/blob/f39c2fef1c1c911e86985ce6352c5d1bc9967c5b/server/base/src/main/java/org/apache/accumulo/server/master/LiveTServerSet.java This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
