keith-turner commented on a change in pull request #371: ACCUMULO-4792 Improve
crypto configuration checks
URL: https://github.com/apache/accumulo/pull/371#discussion_r168202225
##########
File path:
core/src/test/java/org/apache/accumulo/core/conf/ConfigSanityCheckTest.java
##########
@@ -93,4 +91,18 @@ public void testFail_cipherSuiteNotSetKeyAlgorithmSet() {
m.put(Property.CRYPTO_CIPHER_KEY_ALGORITHM_NAME.getKey(), "AES");
ConfigSanityCheck.validate(m.entrySet());
}
+
Review comment:
It would be nice to add the combos that are expected to pass to the
`testPass()` function. For example when CRYPTO_MODULE_CLASS and
CRYPTO_SECRET_KEY_ENCRYPTION_STRATEGY_CLASS are both null AND when both are not
null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
