[jira] [Commented] (ACCUMULO-4702) Use of Beta or deprecated Guava methods
[ https://issues.apache.org/jira/browse/ACCUMULO-4702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362841#comment-16362841 ] Michael Miller commented on ACCUMULO-4702: -- I think we have done as much as we can for now. We took the modest approach of fixing Guava Beta that has been dropped, replacing simple uses and adding the plugin to detect any new Beta classes introduced in future versions. > Use of Beta or deprecated Guava methods > --- > > Key: ACCUMULO-4702 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4702 > Project: Accumulo > Issue Type: Bug >Reporter: Michael Miller >Assignee: Michael Miller >Priority: Major > Labels: pull-request-available > Fix For: 1.7.4, 1.9.0, 2.0.0 > > Time Spent: 6h > Remaining Estimate: 0h > > Google releases Guava with beta and deprecated code that should not be used. > From Guava README: > bq. If your code is a library itself (i.e. it is used on the CLASSPATH of > users outside your own control), you should not use beta API -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ACCUMULO-4702) Use of Beta or deprecated Guava methods
[
https://issues.apache.org/jira/browse/ACCUMULO-4702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284244#comment-16284244
]
Michael Miller commented on ACCUMULO-4702:
--
I built the [library-detectors|https://github.com/overstock/library-detectors]
findbugs plugin locally (they updated to 1.2 but haven't released to maven
central yet) and configured it to skip all the Beta classes. This was
basically a test to create a list of all the Beta classes remaining in Accumulo
2.0. Here is what I came up:
{code:xml}
-Dcom.overstock.findbugs.ignore=
com.google.common.util.concurrent.RateLimiter,
com.google.common.hash.Hasher,
com.google.common.hash.HashCode,
com.google.common.hash.HashFunction,
com.google.common.hash.Hashing,
com.google.common.cache.Cache,
com.google.common.io.CountingOutputStream,
com.google.common.io.ByteStreams,
com.google.common.cache.LoadingCache,
com.google.common.base.Stopwatch,
com.google.common.cache.RemovalNotification,
com.google.common.util.concurrent.Uninterruptibles,
com.google.common.reflect.ClassPath,
com.google.common.reflect.ClassPath$ClassInfo,
com.google.common.base.Throwables
{code}
> Use of Beta or deprecated Guava methods
> ---
>
> Key: ACCUMULO-4702
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4702
> Project: Accumulo
> Issue Type: Bug
>Reporter: Michael Miller
>Assignee: Michael Miller
> Labels: pull-request-available
> Fix For: 1.7.4, 1.8.2, 2.0.0
>
> Time Spent: 6h
> Remaining Estimate: 0h
>
> Google releases Guava with beta and deprecated code that should not be used.
> From Guava README:
> bq. If your code is a library itself (i.e. it is used on the CLASSPATH of
> users outside your own control), you should not use beta API
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ACCUMULO-4702) Use of Beta or deprecated Guava methods
[ https://issues.apache.org/jira/browse/ACCUMULO-4702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161819#comment-16161819 ] Christopher Tubbs commented on ACCUMULO-4702: - To prevent the use of beta classes from Guava, we could create a regex rule in checkstyle to ban any Guava imports that aren't in the vetted list. And, we should check everything we're currently using from Guava to ensure it's not marked beta. If a new Guava class is used in an import statement, we can explicitly check if it's beta and then add it to the vetted list in the regex. This is not an ideal solution, but we need to do something to avoid beta classes. > Use of Beta or deprecated Guava methods > --- > > Key: ACCUMULO-4702 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4702 > Project: Accumulo > Issue Type: Bug >Reporter: Michael Miller >Assignee: Michael Miller > Fix For: 1.7.4, 1.8.2, 2.0.0 > > > Google releases Guava with beta and deprecated code that should not be used. > From Guava README: > bq. If your code is a library itself (i.e. it is used on the CLASSPATH of > users outside your own control), you should not use beta API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
