[
https://issues.apache.org/jira/browse/ACCUMULO-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher Tubbs resolved ACCUMULO-3331.
-----------------------------------------
Resolution: Fixed
Assignee: Christopher Tubbs (was: Josh Elser)
Fix Version/s: (was: 1.7.4)
(was: 1.9.0)
> Dead/invalid code in TabletServer#verifyTabletInformation
> ---------------------------------------------------------
>
> Key: ACCUMULO-3331
> URL: https://issues.apache.org/jira/browse/ACCUMULO-3331
> Project: Accumulo
> Issue Type: Improvement
> Components: tserver
> Affects Versions: 1.5.2, 1.6.1
> Reporter: Josh Elser
> Assignee: Christopher Tubbs
> Priority: Trivial
> Fix For: 2.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A couple of things: tabletsKeyValues is passed in but not returned -- the
> original map has to be updated, can't assign a new map to the variable
> otherwise the caller won't see it.
> Additionally, the caller always passes in a new map (never null). We should
> just assert that to be non-null. Checking for a non-null map is nonsensical
> for the previous reason as well.
> {code}
> // only populate map after success
> if (tabletsKeyValues == null) {
> tabletsKeyValues = tkv;
> } else {
> tabletsKeyValues.clear();
> tabletsKeyValues.putAll(tkv);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
