[jira] [Updated] (ACCUMULO-4789) Scans spend significant time constructing debug string.
[ https://issues.apache.org/jira/browse/ACCUMULO-4789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] taro siwa updated ACCUMULO-4789: a > Scans spend significant time constructing debug string. > --- > > Key: ACCUMULO-4789 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4789 > Project: Accumulo > Issue Type: Improvement >Affects Versions: 1.7.3, 1.8.1 >Reporter: Keith Turner >Assignee: Keith Turner >Priority: Major > Labels: pull-request-available > Fix For: 1.9.0, 2.0.0 > > Time Spent: 1h > Remaining Estimate: 0h > > While profiling a Fluo test running lots of little scans, I noticed a string > builder operation showing up prominently in the profiling results. Below is > a link to the problematic code. Calling range toString was the most > expensive part followed by KeyExtent toString. > [https://github.com/apache/accumulo/blob/rel/1.7.3/core/src/main/java/org/apache/accumulo/core/client/impl/ThriftScanner.java#L405] > > I am not sure if we can change this in 1.7 and 1.8/1.9 because people may > rely on this for debugging. In 2.0 we may want to consider removing this (or > moving it inside the logging code block). > Also, while looking at this I noticed that some of the log statements called > String.format. Those should be placed in a if(llog.traceEnabled()) block. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ACCUMULO-4789) Scans spend significant time constructing debug string.
[ https://issues.apache.org/jira/browse/ACCUMULO-4789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Turner updated ACCUMULO-4789: --- Affects Version/s: 1.7.3 1.8.1 > Scans spend significant time constructing debug string. > --- > > Key: ACCUMULO-4789 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4789 > Project: Accumulo > Issue Type: Improvement >Affects Versions: 1.7.3, 1.8.1 >Reporter: Keith Turner >Assignee: Keith Turner >Priority: Major > Labels: pull-request-available > Fix For: 1.9.0, 2.0.0 > > Time Spent: 1h > Remaining Estimate: 0h > > While profiling a Fluo test running lots of little scans, I noticed a string > builder operation showing up prominently in the profiling results. Below is > a link to the problematic code. Calling range toString was the most > expensive part followed by KeyExtent toString. > [https://github.com/apache/accumulo/blob/rel/1.7.3/core/src/main/java/org/apache/accumulo/core/client/impl/ThriftScanner.java#L405] > > I am not sure if we can change this in 1.7 and 1.8/1.9 because people may > rely on this for debugging. In 2.0 we may want to consider removing this (or > moving it inside the logging code block). > Also, while looking at this I noticed that some of the log statements called > String.format. Those should be placed in a if(llog.traceEnabled()) block. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ACCUMULO-4789) Scans spend significant time constructing debug string.
[ https://issues.apache.org/jira/browse/ACCUMULO-4789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Turner updated ACCUMULO-4789: --- Fix Version/s: 2.0.0 1.9.0 > Scans spend significant time constructing debug string. > --- > > Key: ACCUMULO-4789 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4789 > Project: Accumulo > Issue Type: Improvement >Affects Versions: 1.7.3, 1.8.1 >Reporter: Keith Turner >Assignee: Keith Turner >Priority: Major > Labels: pull-request-available > Fix For: 1.9.0, 2.0.0 > > Time Spent: 1h > Remaining Estimate: 0h > > While profiling a Fluo test running lots of little scans, I noticed a string > builder operation showing up prominently in the profiling results. Below is > a link to the problematic code. Calling range toString was the most > expensive part followed by KeyExtent toString. > [https://github.com/apache/accumulo/blob/rel/1.7.3/core/src/main/java/org/apache/accumulo/core/client/impl/ThriftScanner.java#L405] > > I am not sure if we can change this in 1.7 and 1.8/1.9 because people may > rely on this for debugging. In 2.0 we may want to consider removing this (or > moving it inside the logging code block). > Also, while looking at this I noticed that some of the log statements called > String.format. Those should be placed in a if(llog.traceEnabled()) block. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ACCUMULO-4789) Scans spend significant time constructing debug string.
[ https://issues.apache.org/jira/browse/ACCUMULO-4789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ACCUMULO-4789: - Labels: pull-request-available (was: ) > Scans spend significant time constructing debug string. > --- > > Key: ACCUMULO-4789 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4789 > Project: Accumulo > Issue Type: Improvement >Reporter: Keith Turner >Priority: Major > Labels: pull-request-available > > While profiling a Fluo test running lots of little scans, I noticed a string > builder operation showing up prominently in the profiling results. Below is > a link to the problematic code. Calling range toString was the most > expensive part followed by KeyExtent toString. > [https://github.com/apache/accumulo/blob/rel/1.7.3/core/src/main/java/org/apache/accumulo/core/client/impl/ThriftScanner.java#L405] > > I am not sure if we can change this in 1.7 and 1.8/1.9 because people may > rely on this for debugging. In 2.0 we may want to consider removing this (or > moving it inside the logging code block). > Also, while looking at this I noticed that some of the log statements called > String.format. Those should be placed in a if(llog.traceEnabled()) block. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
