Repository: ant
Updated Branches:
  refs/heads/master 81882fe74 -> fb22a1a2e


Java8 refactoring introduced the evil PrintWriter


Project: http://git-wip-us.apache.org/repos/asf/ant/repo
Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/fb22a1a2
Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/fb22a1a2
Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/fb22a1a2

Branch: refs/heads/master
Commit: fb22a1a2eb68f7b7d997b0466b19d6163149e946
Parents: 81882fe
Author: Stefan Bodewig <bode...@apache.org>
Authored: Tue Feb 13 18:29:34 2018 +0100
Committer: Stefan Bodewig <bode...@apache.org>
Committed: Tue Feb 13 18:29:34 2018 +0100

----------------------------------------------------------------------
 .../tools/ant/taskdefs/optional/depend/Depend.java      | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ant/blob/fb22a1a2/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java 
b/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java
index 3b6d341..e31b496 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java
@@ -23,7 +23,6 @@ import java.io.File;
 import java.io.FileReader;
 import java.io.FileWriter;
 import java.io.IOException;
-import java.io.PrintWriter;
 import java.net.URL;
 import java.util.ArrayList;
 import java.util.Enumeration;
@@ -222,12 +221,15 @@ public class Depend extends MatchingTask {
         if (cache != null) {
             cache.mkdirs();
             File depFile = new File(cache, CACHE_FILE_NAME);
-            try (PrintWriter pw =
-                new PrintWriter(new BufferedWriter(new FileWriter(depFile)))) {
+            try (BufferedWriter pw =
+                new BufferedWriter(new FileWriter(depFile))) {
                 for (Map.Entry<String, List<String>> e : dependencyMap
                     .entrySet()) {
-                    pw.printf("%s%s%n", CLASSNAME_PREPEND, e.getKey());
-                    e.getValue().forEach(pw::println);
+                    pw.write(String.format("%s%s%n", CLASSNAME_PREPEND, 
e.getKey()));
+                    for (String s : e.getValue()) {
+                        pw.write(s);
+                        pw.newLine();
+                    }
                 }
             }
         }

Reply via email to